From: Greg KH <gregkh@suse.de>
To: Josh Boyer <jwboyer@gmail.com>
Cc: Dave Jones <davej@redhat.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: pciehp borkage.
Date: Tue, 27 Jun 2006 09:08:54 -0700 [thread overview]
Message-ID: <20060627160854.GA10332@suse.de> (raw)
In-Reply-To: <625fc13d0606270519wc506fsa7b1c7e55044ec78@mail.gmail.com>
On Tue, Jun 27, 2006 at 07:19:37AM -0500, Josh Boyer wrote:
> On 6/26/06, Greg KH <gregkh@suse.de> wrote:
> >On Mon, Jun 26, 2006 at 11:37:49PM -0400, Dave Jones wrote:
> >> My head hurts..
> >>
> >> drivers/pci/pcie/Kconfig ..
> >>
> >> config HOTPLUG_PCI_PCIE
> >> tristate "PCI Express Hotplug driver"
> >> depends on HOTPLUG_PCI && PCIEPORTBUS && (BROKEN || ACPI)
> >>
> >>
> >>
> >> but drivers/pci/hotplug/Makefile has..
> >>
> >> pciehp-objs := pciehp_core.o \
> >> pciehp_ctrl.o \
> >> pciehp_pci.o \
> >> pciehp_hpc.o
> >>
> >> So it gets built regardless of the option, which leaves ppc (among
> >others)
> >> totally busted..
> >
> >Yes, this driver does have issues on ppc, see the archives for Anton
> >trying to fix it up to get it to build. But as ppc currently doesn't
> >_have_ pci express hotplug hardware it really doesn't matter much :)
> >
> >> In file included from include/acpi/platform/acenv.h:140,
> >> from include/acpi/acpi.h:54,
> >> from drivers/pci/hotplug/pciehp_hpc.c:41:
> >> include/acpi/platform/aclinux.h:59:22: error: asm/acpi.h: No such file
> >or directory
> >> In file included from include/acpi/acpi.h:55,
> >> from drivers/pci/hotplug/pciehp_hpc.c:41:
> >> include/acpi/actypes.h:129: error: expected '=', ',', ';', 'asm' or
> >'__attribute__' before 'UINT64'
> >> include/acpi/actypes.h:130: error: expected '=', ',', ';', 'asm' or
> >'__attribute__' before 'INT64'
> >> make[3]: *** [drivers/pci/hotplug/pciehp_hpc.o] Error 1
> >> make[2]: *** [drivers/pci/hotplug] Error 2
> >> make[1]: *** [drivers/pci] Error 2
> >>
> >>
> >> Should that Makefile be more along the lines of..
> >>
> >> pciehp-$(CONFIG_PCI_PCIE) := pciehp_core.o \
> >> pciehp_ctrl.o \
> >> pciehp_pci.o \
> >> pciehp_hpc.o
> >>
> >> perhaps ?
> >
> >No, look up a bit higher:
> > obj-$(CONFIG_HOTPLUG_PCI_PCIE) += pciehp.o
> >
> >which will build pciehp or not. Just don't enable the option for now
> >on ppc please. Until people sanitize the ACPI headers for non-acpi
> >arches (which is currently underway...)
>
> Would it be sane to make the Kconfig refuse to enable the option for
> archs that this is known to be broken on?
Sure, no objection from me there.
thanks,
greg k-h
prev parent reply other threads:[~2006-06-27 16:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-27 3:37 pciehp borkage Dave Jones
2006-06-27 4:27 ` Greg KH
2006-06-27 12:19 ` Josh Boyer
2006-06-27 16:08 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060627160854.GA10332@suse.de \
--to=gregkh@suse.de \
--cc=davej@redhat.com \
--cc=jwboyer@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox