* [PATCH] Restore set_nmi_callback export on x86_64
@ 2006-06-27 15:24 Jean Delvare
2006-06-27 15:50 ` Andi Kleen
0 siblings, 1 reply; 2+ messages in thread
From: Jean Delvare @ 2006-06-27 15:24 UTC (permalink / raw)
To: LKML; +Cc: Andi Kleen
Commit 2ee60e17896c65da1df5780d3196c050bccb7d10 broke modular
oprofile (amongst others I suspect) on x86_64 by killing the
exports of set_nmi_callback and unset_nmi_callback. Let's
restore the exports next to the functions as is prefered now.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Andi Kleen <ak@suse.de>
---
arch/x86_64/kernel/nmi.c | 2 ++
1 files changed, 2 insertions(+)
--- linux-2.6.17-git.orig/arch/x86_64/kernel/nmi.c 2006-06-27 16:22:17.000000000 +0200
+++ linux-2.6.17-git/arch/x86_64/kernel/nmi.c 2006-06-27 17:08:18.000000000 +0200
@@ -607,11 +607,13 @@
vmalloc_sync_all();
rcu_assign_pointer(nmi_callback, callback);
}
+EXPORT_SYMBOL_GPL(set_nmi_callback);
void unset_nmi_callback(void)
{
nmi_callback = dummy_nmi_callback;
}
+EXPORT_SYMBOL_GPL(unset_nmi_callback);
#ifdef CONFIG_SYSCTL
--
Jean Delvare
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] Restore set_nmi_callback export on x86_64
2006-06-27 15:24 [PATCH] Restore set_nmi_callback export on x86_64 Jean Delvare
@ 2006-06-27 15:50 ` Andi Kleen
0 siblings, 0 replies; 2+ messages in thread
From: Andi Kleen @ 2006-06-27 15:50 UTC (permalink / raw)
To: Jean Delvare; +Cc: LKML
On Tuesday 27 June 2006 17:24, Jean Delvare wrote:
> Commit 2ee60e17896c65da1df5780d3196c050bccb7d10 broke modular
> oprofile (amongst others I suspect) on x86_64 by killing the
> exports of set_nmi_callback and unset_nmi_callback. Let's
> restore the exports next to the functions as is prefered now.
Hmm yes this happened because I got unsubmitted patches
that remove set_nmi_callback/unset_nmi_callback
But for 2.6.18 the patch is good, thanks.
-Andi
>
> Signed-off-by: Jean Delvare <khali@linux-fr.org>
> Cc: Andi Kleen <ak@suse.de>
> ---
> arch/x86_64/kernel/nmi.c | 2 ++
> 1 files changed, 2 insertions(+)
>
> --- linux-2.6.17-git.orig/arch/x86_64/kernel/nmi.c 2006-06-27 16:22:17.000000000 +0200
> +++ linux-2.6.17-git/arch/x86_64/kernel/nmi.c 2006-06-27 17:08:18.000000000 +0200
> @@ -607,11 +607,13 @@
> vmalloc_sync_all();
> rcu_assign_pointer(nmi_callback, callback);
> }
> +EXPORT_SYMBOL_GPL(set_nmi_callback);
>
> void unset_nmi_callback(void)
> {
> nmi_callback = dummy_nmi_callback;
> }
> +EXPORT_SYMBOL_GPL(unset_nmi_callback);
>
> #ifdef CONFIG_SYSCTL
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-06-27 15:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-27 15:24 [PATCH] Restore set_nmi_callback export on x86_64 Jean Delvare
2006-06-27 15:50 ` Andi Kleen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox