The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Nigel Cunningham <nigel@suspend2.net>
To: Pavel Machek <pavel@ucw.cz>
Cc: "Rafael J. Wysocki" <rjw@sisk.pl>, linux-kernel@vger.kernel.org
Subject: Re: [Suspend2][ 2/2] [Suspend2] Freezer upgrade.
Date: Tue, 27 Jun 2006 22:13:14 +1000	[thread overview]
Message-ID: <200606272213.18263.nigel@suspend2.net> (raw)
In-Reply-To: <20060627110933.GA11763@elf.ucw.cz>

[-- Attachment #1: Type: text/plain, Size: 1476 bytes --]

Hi.

On Tuesday 27 June 2006 21:09, Pavel Machek wrote:
> Hi!
>
> > > > This patch represents the Suspend2 upgrades to the freezer
> > > > implementation. Due to recent changes in the vanilla version, I
> > > > should be able to greatly reduce the size of this patch. TODO.
> > >
> > > So I assume the patch will change in the future.
> >
> > This is after the changes. Sorry - forgot to update the comment.
>
> Also please explain why we want those patches. "upgrades the freezer"
> is not good enough reason to apply a patch.

I guess you missed the reply to Rafael. In it, I wrote:

"XFS. Did you see Nathan's reply not long ago, confirming that it doesn't stop 
all activity if you don't freeze bdevs? That isn't critical for swsusp 
(although I guess you could end up with some filesystem inconsistency if XFS 
writes something after the atomic copy), but keeping the LRU static is 
important for suspend2."

In another email, I mentioned that trying to free memory with swap on a 
journalled filesystem is a potential deadlock situation without the 
capability of thawing kernel threads alone. You could potentially thaw all 
threads while eating memory, but then there's a greater chance of racing 
against another program that's trying to allocate memory (if you're in this 
situation, you're low on memory to start with).

Regards,

Nigel

-- 
See http://www.suspend2.net for Howtos, FAQs, mailing
lists, wiki and bugzilla info.

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

      reply	other threads:[~2006-06-27 12:13 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-26 16:38 [Suspend2][ 0/2] Freezer Upgrade Nigel Cunningham
2006-06-26 16:38 ` [Suspend2][ 1/2] [Suspend2] Disable load updating during suspending Nigel Cunningham
2006-06-27 12:07   ` Pavel Machek
2006-06-27 12:16     ` Nigel Cunningham
2006-06-27 12:35       ` Andreas Mohr
2006-06-26 16:38 ` [Suspend2][ 2/2] [Suspend2] Freezer upgrade Nigel Cunningham
2006-06-26 20:01   ` Rafael J. Wysocki
2006-06-26 22:48     ` Nigel Cunningham
2006-06-27 11:09       ` Pavel Machek
2006-06-27 12:13         ` Nigel Cunningham [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200606272213.18263.nigel@suspend2.net \
    --to=nigel@suspend2.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox