Re: USB input ati_remote autorepeat problem

Vojtech Pavlik
2006-06-28T06:52:29Z

On Tue, Jun 27, 2006 at 02:46:39PM -0700, Nish Aravamudan wrote:
> On 6/27/06, Marko Macek <Marko.Macek@gmx.net> wrote:
> >Hello!
> >
> >I have problems with autorepeat in ati_remote (drivers/usb/input) driver
> >in "recent" kernels: all keys start repeating immediately without some
> >delay.
> >
> >This makes some things, like changing the channel prev/next or toggling
> >fullscreen, etc... impossible/hard.
> >
> >The problem seems to be related to FILTER_TIME and HZ=250 (which I
> >forgot to change).
> >
> >FILTER_TIME is defined to HZ / 20, and since 250 is not divisible by 20,
> >the time will be too short to ignore enough events.
> >
> >Defining FILTER_TIME to HZ / 20 + 1 seems to fix things, but I'm not
> >sure if there are any bad side effects.
>
> Can you try just defining it to msecs_to_jiffies(50)? That should
> handle the various HZ cases just fine.

Indeed, that would be thr right solution. Even better would be to

#define FILTER_TIME 50 /* 50 msec */

and later use

msecs_to_jiffies(FILTER_TIME)

in the code.

--
Vojtech Pavlik
Director SuSE Labs