broken auto-repeat on PS/2 keyboard

broken auto-repeat on PS/2 keyboard

[Paolo Ornati]

Hello,

with current git kernel keyboard repeat for my plain PS/2 keyboard
stopped working.

Reverting
	0ae051a19092d36112b5ba60ff8b5df7a5d5d23b

fixes the problem...

-- 
	Paolo Ornati
	Linux 2.6.17-gd2581eb4 on x86_64

Re: broken auto-repeat on PS/2 keyboard

[Dmitry Torokhov]

[-- Attachment #1: Type: text/plain, Size: 370 bytes --]

On 6/27/06, Paolo Ornati <ornati@fastwebnet.it> wrote:
> Hello,
>
> with current git kernel keyboard repeat for my plain PS/2 keyboard
> stopped working.
>
> Reverting
>        0ae051a19092d36112b5ba60ff8b5df7a5d5d23b
>
> fixes the problem...
>

Paolo,

Thank you for identifying the problem commit. Please try the attached
patch, it should fix the problem.

-- 
Dmitry

[-- Attachment #2: atkbd-fix-hardware-autorepeat.patch --]
[-- Type: text/plain, Size: 625 bytes --]

Input: atkbd - fix hardware autorepeat

Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
---
 drivers/input/keyboard/atkbd.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: linux/drivers/input/keyboard/atkbd.c
===================================================================
--- linux.orig/drivers/input/keyboard/atkbd.c
+++ linux/drivers/input/keyboard/atkbd.c
@@ -459,7 +459,7 @@ static irqreturn_t atkbd_interrupt(struc
 			}
 
 			input_regs(dev, regs);
-			input_report_key(dev, keycode, value);
+			input_event(dev, EV_KEY, keycode, value);
 			input_sync(dev);
 
 			if (value && add_release_event) {

Re: broken auto-repeat on PS/2 keyboard

[Daniel Ritz]

i noticed the problem as well here...and i can confirm that your patch
fixes the problem...

andrew, have a look at:
	http://marc.theaimsgroup.com/?l=linux-kernel&m=115142991330291&w=4

thanks
-daniel

Re: broken auto-repeat on PS/2 keyboard

[Paolo Ornati]

On Tue, 27 Jun 2006 13:34:26 -0400
"Dmitry Torokhov" <dmitry.torokhov@gmail.com> wrote:

> Paolo,
> 
> Thank you for identifying the problem commit. Please try the attached
> patch, it should fix the problem.

It works :)

-- 
	Paolo Ornati
	Linux 2.6.17-ga39727f2-dirty on x86_64

Re: broken auto-repeat on PS/2 keyboard

[Jean Delvare]

Hi Dmitry,

> > with current git kernel keyboard repeat for my plain PS/2 keyboard
> > stopped working.
> >
> > Reverting
> >        0ae051a19092d36112b5ba60ff8b5df7a5d5d23b
> >
> > fixes the problem...
> 
> Thank you for identifying the problem commit. Please try the attached
> patch, it should fix the problem.

Fixed it for me as well, thanks! Can this fix be pushed upstream now?
The lack of repeat was a real pain.

-- 
Jean Delvare

Re: broken auto-repeat on PS/2 keyboard

[Paolo Ornati]

On Wed, 28 Jun 2006 13:36:30 +0200
Jean Delvare <khali@linux-fr.org> wrote:

> Hi Dmitry,
> 
> > > with current git kernel keyboard repeat for my plain PS/2 keyboard
> > > stopped working.
> > >
> > > Reverting
> > >        0ae051a19092d36112b5ba60ff8b5df7a5d5d23b
> > >
> > > fixes the problem...
> > 
> > Thank you for identifying the problem commit. Please try the attached
> > patch, it should fix the problem.
> 
> Fixed it for me as well, thanks! Can this fix be pushed upstream now?

http://groups.google.it/group/linux.kernel/browse_frm/thread/17700355fcda1923/05f38a40a23d0ef1?lnk=st&q=group%3Alinux.kernel+author%3ADmitry&rnum=1&hl=en#05f38a40a23d0ef1

-- 
	Paolo Ornati
	Linux 2.6.17-ga39727f2-dirty on x86_64

Re: broken auto-repeat on PS/2 keyboard

[Dmitry Torokhov]

On Wednesday 28 June 2006 07:36, Jean Delvare wrote:
> Hi Dmitry,
> 
> > > with current git kernel keyboard repeat for my plain PS/2 keyboard
> > > stopped working.
> > >
> > > Reverting
> > >        0ae051a19092d36112b5ba60ff8b5df7a5d5d23b
> > >
> > > fixes the problem...
> > 
> > Thank you for identifying the problem commit. Please try the attached
> > patch, it should fix the problem.
> 
> Fixed it for me as well, thanks! Can this fix be pushed upstream now?
> The lack of repeat was a real pain.
> 

Heh, that means noone but me uses softrepeat option, I didn't even notice
it was broken. ;)

I already sent pull request to Linus so you should see it soon.
 
-- 
Dmitry