public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: linux-kernel@vger.kernel.org, Ram Pai <linuxram@us.ibm.com>,
	Sam Ravnborg <sam@ravnborg.org>
Subject: Re: 2.6.17-mm3: segvs in modpost with out-of-tree modules
Date: Wed, 28 Jun 2006 11:29:25 -0700	[thread overview]
Message-ID: <20060628112925.f96fcfc4.akpm@osdl.org> (raw)
In-Reply-To: <44A2B37F.4030500@goop.org>

On Wed, 28 Jun 2006 09:51:11 -0700
Jeremy Fitzhardinge <jeremy@goop.org> wrote:

> I'm seeing SIGSEGVs in modpost when compiling the out-of-tree madwifi 
> driver:
> 
>     /bin/sh: line 1: 3701 Segmentation fault scripts/mod/modpost -m -a
>     -i /home/jeremy/hg/linux-2.6/Module.symvers -I
>     /home/jeremy/svn/madwifi-ng/Modules.symvers -o
>     /home/jeremy/svn/madwifi-ng/Modules.symvers vmlinux
>     /home/jeremy/svn/madw ifi-ng/ath/ath_hal.o
>     /home/jeremy/svn/madwifi-ng/ath/ath_pci.o /home/jeremy/svn/
>     madwifi-ng/ath_rate/sample/ath_rate_sample.o
>     /home/jeremy/svn/madwifi-ng/net8021 1/wlan.o
>     /home/jeremy/svn/madwifi-ng/net80211/wlan_acl.o
>     /home/jeremy/svn/madwif i-ng/net80211/wlan_ccmp.o
>     /home/jeremy/svn/madwifi-ng/net80211/wlan_scan_ap.o
>     /home/jeremy/svn/madwifi-ng/net80211/wlan_scan_sta.o
>     /home/jeremy/svn/madwifi-ng/n et80211/wlan_tkip.o
>     /home/jeremy/svn/madwifi-ng/net80211/wlan_wep.o /home/jeremy
>     /svn/madwifi-ng/net80211/wlan_xauth.o
> 
> The backtrace is:
> 
> #0  0x4e8017da in strcmp () from /lib/libc.so.6
> #1  0x080491a7 in export_no (s=0x0) at modpost.c:209
> #2  0x0804b5c3 in read_dump (
>     fname=0xbff5fa9d "/home/jeremy/svn/madwifi-ng/Modules.symvers", kernel=0)
>     at modpost.c:1312
> #3  0x0804b88b in main (argc=21, argv=0xbff5def4) at modpost.c:1390
> 
> I haven't really looked at yet, but I was hoping someone had already 
> tracked it down.
> 

Not that I'm aware of.

		if ((export = strchr(modname, '\t')) != NULL)
			*export++ = '\0';

if `export' can be NULL,

		crc = strtoul(line, &d, 16);
		if (*symname == '\0' || *modname == '\0' || *d != '\0')
			goto fail;

		if (!(mod = find_module(modname))) {
			if (is_vmlinux(modname)) {
				have_vmlinux = 1;
			}
			mod = new_module(NOFAIL(strdup(modname)));
			mod->skip = 1;
		}
		s = sym_add_exported(symname, mod, export_no(export));

that was a bad idea.



  reply	other threads:[~2006-06-28 18:29 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-28 16:51 2.6.17-mm3: segvs in modpost with out-of-tree modules Jeremy Fitzhardinge
2006-06-28 18:29 ` Andrew Morton [this message]
2006-06-28 18:44   ` Jeremy Fitzhardinge
2006-07-01  9:47     ` Sam Ravnborg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060628112925.f96fcfc4.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxram@us.ibm.com \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox