From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751446AbWF1RU7 (ORCPT ); Wed, 28 Jun 2006 13:20:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751476AbWF1RU7 (ORCPT ); Wed, 28 Jun 2006 13:20:59 -0400 Received: from mailout.stusta.mhn.de ([141.84.69.5]:19461 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S1751446AbWF1RU6 (ORCPT ); Wed, 28 Jun 2006 13:20:58 -0400 Date: Wed, 28 Jun 2006 19:20:57 +0200 From: Adrian Bunk To: Dave Jones , linux-kernel@vger.kernel.org Subject: Re: [2.6 patch] AGP_AMD64 must depend on PCI Message-ID: <20060628172057.GL13915@stusta.de> References: <20060628165529.GI13915@stusta.de> <20060628170222.GA23396@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20060628170222.GA23396@redhat.com> User-Agent: Mutt/1.5.11+cvs20060403 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jun 28, 2006 at 01:02:22PM -0400, Dave Jones wrote: > On Wed, Jun 28, 2006 at 06:55:30PM +0200, Adrian Bunk wrote: > > This patch fixes the following compile error: > > > > <-- snip --> > > > > ... > > CC arch/i386/kernel/../../x86_64/kernel/k8.o > > arch/i386/kernel/../../x86_64/kernel/k8.c: In function ‘next_k8_northbridge’: > > arch/i386/kernel/../../x86_64/kernel/k8.c:34: error: implicit declaration of function ‘pci_match_id’ > > > > <-- snip --> > > > > Signed-off-by: Adrian Bunk > > > > --- linux-2.6.17-mm3-full/drivers/char/agp/Kconfig.old 2006-06-28 12:56:20.000000000 +0200 > > +++ linux-2.6.17-mm3-full/drivers/char/agp/Kconfig 2006-06-28 12:56:55.000000000 +0200 > > @@ -56,7 +56,7 @@ > > > > config AGP_AMD64 > > tristate "AMD Opteron/Athlon64 on-CPU GART support" if !IOMMU > > - depends on AGP && X86 > > + depends on AGP && PCI && X86 > > default y if IOMMU > > help > > This option gives you AGP support for the GLX component of > > What makes this driver special ? The other AGP drivers also use > various PCI functions, and don't have a similar dependancy. The usage of pci_match_id() was the only case where an AGP driver didn't compile with CONFIG_PCI=n (the other used PCI functions have dummies for CONFIG_PCI=n). > Adding depends on PCI to 'AGP' may make more sense than adding > it to the individual drivers, especially as the core AGP code also > uses the pci layer. As AGP is just a bastardised variant of PCI > anyway, adding an explicit dependancy should be sane on all archs, > even alpha with its wierdo 'faked pci bridge'. Fine with me. > Dave cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed