From: "Paul E. McKenney" <paulmck@us.ibm.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [-mm patch] kernel/rcutorture.c: make code static
Date: Wed, 28 Jun 2006 10:49:41 -0700 [thread overview]
Message-ID: <20060628174941.GF1293@us.ibm.com> (raw)
In-Reply-To: <20060628171751.GK13915@stusta.de>
On Wed, Jun 28, 2006 at 07:17:51PM +0200, Adrian Bunk wrote:
> On Wed, Jun 28, 2006 at 10:13:09AM -0700, Paul E. McKenney wrote:
> > On Wed, Jun 28, 2006 at 06:54:45PM +0200, Adrian Bunk wrote:
> > > This patch makes needlessly global code static.
> >
> > Looks good to me -- but have you tested it? If so, I will ack, otherwise
> > I will test and ack/nack depending on the results.
>
> I've only tested the compilation (which should be enough considering the
> nature of the patch).
Perhaps it should be, but I am paranoid. Too many ways for compilers,
include files, and CPP macros to play tricks. I will test it.
Thanx, Paul
next prev parent reply other threads:[~2006-06-28 17:49 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-27 8:52 2.6.17-mm3 Andrew Morton
2006-06-27 9:14 ` 2.6.17-mm3: no help text for READAHEAD_ALLOW_OVERHEADS Adrian Bunk
[not found] ` <20060627134337.GA6117@mail.ustc.edu.cn>
2006-06-27 13:43 ` Wu Fengguang
2006-06-27 14:40 ` Adrian Bunk
[not found] ` <20060627155227.GA6014@mail.ustc.edu.cn>
2006-06-27 15:52 ` Wu Fengguang
2006-06-27 17:46 ` Randy.Dunlap
2006-06-27 17:55 ` Adrian Bunk
2006-06-27 9:28 ` [patch] irq: fix arch/i386/kernel/irq.c gcc warning Ingo Molnar
2006-06-27 11:06 ` Björn Steinbrink
2006-06-27 11:14 ` x86_64-mm-ieee1394-early.patch (was Re: 2.6.17-mm3) Stefan Richter
2006-06-27 11:17 ` 2.6.17-mm3 Reuben Farrelly
2006-06-27 11:48 ` 2.6.17-mm3 Reuben Farrelly
2006-06-27 14:12 ` 2.6.17-mm3 Michal Piotrowski
2006-06-27 21:38 ` 2.6.17-mm3 Steve Fox
2006-06-27 23:12 ` 2.6.17-mm3 Martin Bligh
2006-06-27 22:40 ` 2.6.17-mm3: arm: *_irq_wake compile error Adrian Bunk
2006-06-28 7:09 ` Thomas Gleixner
2006-06-28 7:12 ` Andrew Morton
2006-06-28 7:20 ` Thomas Gleixner
2006-06-28 8:13 ` Ingo Molnar
2006-06-28 8:30 ` [patch] genirq: rename desc->handler to desc->chip, sparc64 fix Ingo Molnar
2006-06-28 8:39 ` David Miller
2006-06-28 8:48 ` Andrew Morton
2006-06-28 8:47 ` Ingo Molnar
2006-06-28 9:24 ` David Miller
2006-06-29 4:58 ` Paul Mackerras
2006-06-29 6:42 ` Ingo Molnar
2006-06-28 12:03 ` 2.6.17-mm3 - mutex warning in usbhid, battery problem, and slab corruption Rafael J. Wysocki
2006-06-28 12:09 ` Andrew Morton
2006-06-28 14:14 ` 2.6.17-mm3 Cedric Le Goater
2006-06-28 16:54 ` [-mm patch] make drivers/scsi/aic7xxx/aic79xx_core.:ahd_set_tags() static Adrian Bunk
2006-06-28 16:54 ` [-mm patch] kernel/rcutorture.c: make code static Adrian Bunk
2006-06-28 17:13 ` Paul E. McKenney
2006-06-28 17:17 ` Adrian Bunk
2006-06-28 17:49 ` Paul E. McKenney [this message]
2006-06-28 20:18 ` Paul E. McKenney
2006-06-28 16:55 ` [-mm patch] kernel/lockdep.c: possible cleanups Adrian Bunk
2006-06-29 13:49 ` Ingo Molnar
2006-06-28 16:55 ` [-mm patch] fs/ecryptfs/: " Adrian Bunk
2006-06-28 18:40 ` Michael Halcrow
-- strict thread matches above, loose matches on Subject: below --
2006-07-09 9:11 2.6.18-rc1-mm1 Andrew Morton
2006-07-09 17:53 ` [-mm patch] kernel/rcutorture.c: make code static Adrian Bunk
2006-07-10 14:58 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060628174941.GF1293@us.ibm.com \
--to=paulmck@us.ibm.com \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox