public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* 2.6.17-mm3
@ 2006-06-27  8:52 Andrew Morton
  2006-06-27  9:14 ` 2.6.17-mm3: no help text for READAHEAD_ALLOW_OVERHEADS Adrian Bunk
                   ` (13 more replies)
  0 siblings, 14 replies; 42+ messages in thread
From: Andrew Morton @ 2006-06-27  8:52 UTC (permalink / raw)
  To: linux-kernel


ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.17/2.6.17-mm3/


- Added the x86 Geode development tree to the -mm lineup, as git-geode.patch
  (Jordan Crouse).

- The locking validator patches are back, in a reworked series.



Boilerplate:

- See the `hot-fixes' directory for any important updates to this patchset.

- To fetch an -mm tree using git, use (for example)

  git fetch git://git.kernel.org/pub/scm/linux/kernel/git/smurf/linux-trees.git v2.6.16-rc2-mm1

- -mm kernel commit activity can be reviewed by subscribing to the
  mm-commits mailing list.

        echo "subscribe mm-commits" | mail majordomo@vger.kernel.org

- If you hit a bug in -mm and it is not obvious which patch caused it, it is
  most valuable if you can perform a bisection search to identify which patch
  introduced the bug.  Instructions for this process are at

        http://www.zip.com.au/~akpm/linux/patches/stuff/bisecting-mm-trees.txt

  But beware that this process takes some time (around ten rebuilds and
  reboots), so consider reporting the bug first and if we cannot immediately
  identify the faulty patch, then perform the bisection search.

- When reporting bugs, please try to Cc: the relevant maintainer and mailing
  list on any email.



Changes since 2.6.17-mm2:


 origin.patch
 git-agpgart.patch
 git-cifs.patch
 git-geode.patch
 git-gfs2.patch
 git-ia64.patch
 git-infiniband.patch
 git-jfs.patch
 git-klibc.patch
 git-klibc-fixup.patch
 git-hdrinstall2.patch
 git-libata-all.patch
 git-mtd.patch
 git-netdev-all.patch
 git-parisc.patch
 git-pcmcia.patch
 git-s390.patch
 git-scsi-misc.patch
 git-scsi-target.patch
 git-supertrak.patch
 git-watchdog.patch
 git-wireless.patch
 git-xfs.patch

 git trees.

-fix-typo-in-acpi-video-brightness-changes.patch
-initramfs-overwrite-fix.patch
-remove-for_each_cpu.patch
-more-for_each_cpu-removal.patch
-fix-drivers-mfd-ucb1x00-corec-irq-probing-bug.patch
-cifs-build-fix.patch
-remove-useless-checks-in-cifs-connectc.patch
-cifs-remove-f_ownerlock-use.patch
-tea575x-tuner-build-fix.patch
-git-dvb-versus-matroxfb.patch
-git-dvb-printk-warning-fix.patch
-fix-use-after-free-bug-in-cpia2-driver.patch
-drivers-media-video-vivic-make-2-functions-static.patch
-drivers-media-video-pwc-make-code-static.patch
-fix-up-funky-logic-in-dvb.patch
-ieee1394-nodemgr-do-not-peek-into-struct.patch
-via-pmu-add-input-device.patch
-input-mouse-sermouse-fix-memleak-and-potential-buffer-overflow.patch
-kbuild-export-symbol-usage-report-generator-2.patch
-add-a-pci-vendor-id-definition-for-aculab.patch
-ppp_async-hang-fix.patch
-netpoll-dont-spin-forever-sending-to-blocked-queues.patch
-netpoll-break-recursive-loop-in-netpoll-rx-path.patch
-irda-add-some-ibm-think-pads.patch
-atm-mpcc-warning-fix.patch
-nfs-remove-nfs_put_link.patch
-8250_pnp-add-support-for-other-wacom-tablets.patch
-64-bit-resources-kconfig-change.patch
-64-bit-resources-lose-some-ifdefs.patch
-64bit-resource-fix-up-printks-for-resources-in-arch-and-core-code-fix.patch
-fix-pciehp-driver-on-non-acpi-systems.patch
-drivers-scsi-sdc-fix-uninitialized-variable-in-handling-medium-errors.patch
-lpfc-sparse-null-warnings.patch
-random-remove-redundant-sa_sample_random-from-ninjascsi.patch
-add-scsi_add_host-failure-handling-for-nsp32.patch
-bogus-disk-geometry-on-large-disks.patch
-megaraid_sas-zcr-with-fix.patch
-usb-move-linux-usb_input.h-to-linux-usb-input-fix.patch
-usb-new-driver-for-cypress-cy7c63xxx-mirco-controllers-fix.patch
-x86_64-mm-defconfig-update.patch
-x86_64-mm-phys-apicid.patch
-x86_64-mm-memset-always-inline.patch
-x86_64-mm-amd-core-cpuid.patch
-x86_64-mm-amd-cpuid4.patch
-x86_64-mm-alternatives.patch
-x86_64-mm-pci-dma-cleanup.patch
-x86_64-mm-ia32-unistd-cleanup.patch
-x86_64-mm-large-bzimage.patch
-x86_64-mm-topology-comment.patch
-x86_64-mm-iommu_gart_bitmap-search-to-cross-next_bit.patch
-x86_64-mm-new-compat-ptrace.patch
-x86_64-mm-disable-agp-resource-check.patch
-x86_64-mm-gart-direct-call.patch
-x86_64-mm-new-northbridge.patch
-x86_64-mm-serialize-assign_irq_vector-use-of-static-variables.patch
-x86_64-mm-simplify-ioapic_register_intr.patch
-x86_64-mm-i386-up-generic-arch.patch
-x86_64-mm-iommu-enodev.patch
-x86_64-mm-compat-printk.patch
-x86_64-mm-add-end-endproc-annotations-to-entrys.patch
-x86_64-mm-i386-numa-summit-check.patch
-x86_64-mm-fix-unlikely-profiling--vsyscalls-on-x86_64.patch
-x86_64-mm-nmi-watchdog-header-cleanup.patch
-x86_64-mm-add-performance-counter-reservation-framework-for-up-kernels.patch
-x86_64-mm-utilize-performance-counter-reservation-framework-in-oprofile.patch
-x86_64-mm-add-smp-support-on-x86_64-to-reservation-framework.patch
-x86_64-mm-add-smp-support-on-i386-to-reservation-framework.patch
-x86_64-mm-cleanup-nmi-interrupt-path.patch
-x86_64-mm-remove-un-set_nmi_callback-and-reserve-release_lapic_nmi-functions.patch
-x86_64-mm-add-abilty-to-enable-disable-nmi-watchdog-from-sysfs.patch
-x86_64-mm-acpi-blacklist-xw9300.patch
-x86_64-mm-remove-ids.patch
-x86_64-mm-remove-ia32-export.patch
-x86_64-mm-optimize-bitmap-weight.patch
-x86_64-mm-allow-users-to-force-a-panic-on-nmi.patch
-x86_64-mm-make-functions-static.patch
-x86_64-mm-remove-unused-gart-header-file.patch
-x86_64-mm-fix-vector_lock-deadlock-in-io_apicc.patch
-x86_64-mm-x86_64-mm-remove-un-set_nmi_callback-and-reserve-release_lapic_nmi-functions-x86-fix.patch
-x86_64-mm-x86_64-mm-remove-un-set_nmi_callback-and-reserve-release_lapic_nmi-functions-x86-fix-fix.patch
-x86_64-mm-x86_64-mm-remove-un-set_nmi_callback-and-reserve-release_lapic_nmi-functions-x86_64-fix.patch
-x86_64-mm-kdump-x86_64-nmi-event-notification-fix.patch
-x86_64-mm-kdump-i386-nmi-event-notification-fix.patch
-x86_64-mm-set-compat-early.patch
-x86_64-mm-i386-enable-nmi-wdog.patch
-x86_64-mm-iommu-clarification.patch
-x86_64-mm-reliable-stack-trace-support.patch
-x86_64-mm-reliable-stack-trace-support-x86-64.patch-x86_64-mm-reliable-stack-trace-support-x86-64-irq-stack.patch
-x86_64-mm-reliable-stack-trace-support-x86-64-syscall.patch
-x86_64-mm-reliable-stack-trace-support-i386.patch
-x86_64-mm-x86_86-msi-miss-one-entry-handler.patch
-x86_64-mm-reliable-stack-trace-support-i386-entrys.patch
-x86_64-mm-fall-back-to-old-style-call-trace-if-no-unwinding.patch
-x86_64-mm-allow-unwinder-to-build-without-module-support.patch
-x86_64-mm-consoldidate-boot-compressed.patch
-x86_64-mm-remove-pud_offset_k.patch
-x86_64-mm-use-halt-instead-of-raw-inline-assembly.patch
-x86_64-mm-change-assembly-to-use-regular-cpuid_count-macro.patch
-x86_64-mm-iommu-detected.patch
-x86_64-mm-valid-dma-direction.patch
-x86_64-mm-iommu-abstraction.patch
-x86_64-mm-calgary-iommu.patch
-x86_64-mm-moving-phys_proc_id-and-cpu_core_id-to-cpuinfo_x86.patch
-x86_64-mm-add-nmi-watchdog-support-for-new-intel-cpus.patch
-x86_64-mm-rdtscp-macros.patch
-x86_64-mm-time-constants.patch
-x86_64-mm-rename-force-hpet.patch
-x86_64-mm-rdtscp-feature.patch
-x86_64-mm-remove-hpet-hack.patch
-x86_64-mm-use-time-constants.patch
-x86_64-mm-init-rdtscp.patch
-x86_64-mm-explain-double-hpet-init.patch
-x86_64-mm-update-copyright.patch
-x86_64-mm-getcpu-vsyscall.patch
-x86_64-mm-time-init-gtod-prototype.patch
-x86_64-mm-x86-clean-up-nmi-panic-messages.patch
-x86_64-mm-i386-move-vm86-config.patch
-x86_64-mm-apic-support-for-extended-apic-interrupt.patch
-x86_64-mm-mce_amd-relocate-sysfs-files.patch
-x86_64-mm-mce_amd-support-for-family-0x10-processors.patch
-x86_64-mm-mce_amd-cleanup.patch
-x86_64-mm-miscellaneous-mm-initc-fixes.patch
-x86_64-mm-check_addr-cleanups.patch
-x86_64-mm-remove-redzone-comment.patch
-x86_64-mm-polling-thread-status.patch
-x86_64-mm-twofish-cipher---split-out-common-c-code.patch
-x86_64-mm-twofish-cipher---priority-fix.patch
-x86_64-mm-twofish-cipher---i586-assembler.patch
-x86_64-mm-twofish-cipher---x86_64-assembler.patch
-x86_64-mm-unify-cpu-boottime-output.patch
-aop_truncated_page-victims-in-read_pages-belong-in-the-lru.patch
-mm-remove-vm_locked-before-remap_pfn_range-and-drop-vm_shm.patch
-page-migration-support-a-vma-migration-function.patch
-allow-migration-of-mlocked-pages.patch
-clean-up-and-refactor-i386-sub-architecture-setup.patch
-cpu_relax-smpbootc.patch
-cpu_relax-smpbootc-fix.patch
-x86-apic-fix-apic-error-on-bootup.patch
-i386-cpu_relax-in-crashc-and-doublefaultc.patch
-m68k-fix-uaccessh-for-gcc-3x.patch
-m68k-fix-constraints-of-the-signal-functions-and-some-cleanup.patch
-m68k-fix-__iounmap-for-030.patch
-m68k-small-flush_icache-cleanup.patch
-m68k-add-the-generic-dma-api-functions.patch
-m68k-dma-api-addition.patch
-m68k-fix-show_registers.patch
-m68k-separate-handler-for-auto-and-user-vector-interrupt.patch
-m68k-cleanup-generic-irq-names.patch
-m68k-cleanup-amiga-irq-numbering.patch
-m68k-introduce-irq-controller.patch
-m68k-convert-generic-irq-code-to-irq-controller.patch
-m68k-convert-amiga-irq-code.patch
-m68k-convert-apollo-irq-code.patch
-m68k-convert-atari-irq-code.patch
-m68k-convert-hp300-irq-code.patch
-m68k-convert-mac-irq-code.patch
-m68k-convert-q40-irq-code.patch
-m68k-convert-sun3-irq-code.patch
-m68k-convert-vme-irq-code.patch
-x86_64-unexport-ia32_sys_call_table.patch
-work-around-ppc64-bootup-bug-by-making-mutex-debugging-save-restore-irqs.patch
-kernel-kernel-cpuc-to-mutexes.patch
-make-sure-nobodys-leaking-resources.patch
-rewritten-backlight-infrastructure-for-portable-apple-computers.patch
-rewritten-backlight-infrastructure-for-portable-apple-computers-fix.patch
-ensure-null-deref-cant-possibly-happen-in-is_exported.patch
-bluetooth-fix-potential-null-ptr-deref-in-dtl1_cscdtl1_hci_send_frame.patch
-bloat-o-meter-gcc-4-fix.patch
-random-remove-sa_sample_random-from-floppy-driver.patch
-random-make-cciss-use-add_disk_randomness.patch
-random-change-cpqarray-to-use-add_disk_randomness.patch
-random-remove-redundant-sa_sample_random-from-touchscreen-drivers.patch
-define-__raw_get_cpu_var-and-use-it.patch
 deprecate-smbfs-in-favour-of-cifs.patch
-allow-raw_notifier-callouts-to-unregister-themselves.patch
-fs-freevxfs-cleanup-of-spelling-errors.patch
-pnp-card_probe-fix-memory-leak.patch
-ufs-ufs_trunc_indirect-infinite-cycle.patch
-ufs-right-block-allocation.patch
-ufs-change-block-number-on-the-fly.patch
-ufs-directory-and-page-cache-install-aops.patch
-ufs-directory-and-page-cache-from-blocks-to-pages.patch
-ufs-wrong-type-cast.patch
-ufs-not-usual-amounts-of-fragments-per-block.patch
-ufs-unmark-config_ufs_fs_write-as-broken-mm-tree.patch
-ufs-easy-debug.patch
-ufs-little-directory-lookup-optimization.patch
-ufs-i_blocks-wrong-count.patch
-ufs-unlock_super-without-lock.patch
-ufs-zero-metadata.patch
-ufs-printk-warning-fixes.patch
-ufs-missed-brelse-and-wrong-baseblk.patch
-ufs-one-way-to-access-super-block.patch
-ufs-fsync-implementation.patch
-ufs-make-fsck-f-happy.patch
-ufs-ubh_ll_rw_block-cleanup.patch
-fs-ufs-inodec-make-2-functions-static.patch
-oprofile-fix-unnecessary-cleverness.patch
-msnd-section-fix.patch
-oprofile-convert-from-semaphores-to-mutexes.patch
-drivers-char-applicomc-proper-module_initexit.patch
-remove-dead-entry-in-net-wan-kconfig.patch
-openpromfs-fix-missing-nul.patch
-openpromfs-remove-unnecessary-casts.patch
-openpromfs-factorize-out.patch
-openpromfs-factorize-out-tidy.patch
-idetape-gcc-41-warning-fix.patch
-add-driver-for-arm-amba-pl031-rtc.patch
-add-driver-for-arm-amba-pl031-rtc-fix.patch
-make-printk-work-for-really-early-debugging.patch
-kernel-sysc-cleanups.patch
-kernel-sysc-cleanups-fix.patch
-nbd-kill-obsolete-changelog-add-gpl.patch
-fix-listh-kernel-doc.patch
-listh-doc-change-counter-to-control.patch
-fix-magic-sysrq-on-strange-keyboards.patch
-ide-cd-end-of-media-error-fix.patch
-cpqarray-section-fix.patch
-pdflush-handle-resume-wakeups.patch
-edd-isnt-experimental-anymore.patch
-kernel-doc-drop-leading-space-in-sections.patch
-kernel-doc-script-cleanups.patch
-schedule_on_each_cpu-reduce-kmalloc-size.patch
-avoid-disk-sector_t-overflow-for-2tb-ext3-filesystem.patch
-cleanup-dead-code-from-ext2-mount-code.patch
-fix-memory-leak-when-the-ext3s-journal-file-is-corrupted.patch
-remove-inconsistent-space-before-exclamation-point-in-ext3s-mount-code.patch
-moxa-remove-pointless-casts.patch
-moxa-remove-pointless-check-of-tty-argument-vs-null.patch
-moxa-partial-codingstyle-cleanup-spelling-fixes.patch
-updated-kdump-documentation.patch
-cpuset-remove-extra-cpuset_zone_allowed-check-in-__alloc_pages.patch
 spin-rwlock-init-cleanups.patch
-make-debug_mutex_on-__read_mostly.patch
-constify-parts-of-kernel-power.patch
-constify-libcrc32c-table.patch
-prepare-for-__copy_from_user_inatomic-to-not-zero-missed-bytes.patch
-make-copy_from_user_inatomic-not-zero-the-tail-on-i386.patch
-remove-unecessary-null-check-in-kernel-acctc.patch
-ax88796-parallel-port-driver.patch
-ax88796-parallel-port-driver-build-fix.patch
-wd7000-fix-section-mismatch-warnings.patch
-megaraid_mbox-fix-section-mismatch-warnings.patch
-ext3_fsblk_t-filesystem-group-blocks-and-bug-fixes.patch
-ext3_fsblk_t-the-rest-of-in-kernel-filesystem-blocks.patch
-list_del-debug.patch
-kernel-doc-mm-readhead-fixup.patch
-make-procfs-obligatory-except-under-config_embedded.patch
-lock-validator-introduce-warn_on_oncecond.patch
-lock-validator-introduce-warn_on_oncecond-speedup.patch
-make-sysctl-obligatory-except-under-config_embedded.patch
-for_each_cpu_mask-warning-fix.patch
-emu10k1-mark-midi_spinlock-as-used.patch
-make-ext2_debug-work-again.patch
-nbd-endian-annotations.patch
-epoll-use-unlocked-wqueue-operations.patch
-radixtree-normalize-radix_tree_tag_get-return-value.patch
-printk-time-parameter.patch
-correct-sak-description-in-sysrqtxt.patch
-rtc-framework-driver-for-ds1307-and-similar-rtc-chips.patch
-rtc-rtc-dev-uie-emulation.patch
-drivers-acorn-char-pcf8583-vs-rtc-subsystem.patch
-rtc-subsystem-fix-capability-checks-in-kernel-interface.patch
-rtc-subsystem-add-capability-checks.patch
-add-max6902-rtc-support.patch
-add-max6902-rtc-support-update.patch
-add-max6902-rtc-support-tidy.patch
-rtc-small-documentation-update.patch
-add-v3020-rtc-support.patch
-add-v3020-rtc-support-tidy.patch
-rtc-add-rtc_year_days-to-calculate-tm_yday.patch
-at91rm9200-rtc-driver.patch
-at91rm9200-rtc-driver-tidy.patch
-rtc-add-rtc-ds1553-driver.patch
-rtc-add-rtc-ds1553-driver-tidy.patch
-rtc-add-rtc-ds1553-driver-fix.patch
-rtc-add-rtc-ds1742-driver.patch
-rtc-add-rtc-ds1742-driver-tidy.patch
-rtc-add-rtc-ds1742-driver-fix.patch
-correct-tty-doc.patch
-checkstack-pirnt-module-names.patch
-get-rid-of-proc-sys-proc.patch
-9pfs-missing-result-check-in-v9fs_vfs_readlink-and-v9fs_vfs_link.patch
-ext3-cleanup-dead-code-in-ext3_add_entry.patch
-n32-sigset-and-__compat_endian_swap__.patch
-ftruncate-does-not-always-update-m-ctime.patch
-wan-sdla-section-fixes.patch
-trident-fb-section-fixes.patch
-cdrom-mcdx-section-fixes.patch
-char-ip2-more-section-fixes-replacement.patch
-advansys-section-fixes.patch
-r3964-fix-gfp_kernel-allocations-in-timer-function.patch
-readahead-backoff-on-i-o-error.patch
-readahead-backoff-on-i-o-error-tweaks.patch
-rcu-documentation-self-limiting-updates-and-call_rcu.patch
-link-error-when-futexes-are-disabled-on-64bit-architectures.patch
-cyclades-cleanup.patch
-cyclades-cleanup-cleanup.patch
-cleanup-char-espc.patch
-autofs4-need-to-invalidate-children-on-tree-mount-expire.patch
-update-contact-information-in-credits.patch
-more-tty-cleanups-in-drivers-char.patch
-another-couple-of-alterations-to-the-memory-barrier-doc.patch
-fuse-use-misc_major.patch
-fuse-no-backgrounding-on-interrupt.patch
-fuse-add-control-filesystem.patch
-fuse-add-control-filesystem-get_sb_single-fix.patch
-fuse-add-control-filesystem-printk-fix.patch
-fuse-add-control-filesystem-fuse-comment-control-filesystem.patch
-fuse-add-posix-file-locking-support.patch
-fuse-ensure-flush-reaches-userspace.patch
-fuse-rename-the-interrupted-flag.patch
-fuse-add-request-interruption.patch
-fuse-scramble-lock-owner-id.patch
-mark-profile-notifier-blocks-__read_mostly.patch
-kernel-doc-warn-on-malformed-function-docs.patch
-ide-floppy-fix-debug-only-syntax-error.patch
-remove-needless-checks-in-fs-9p-vfs_inodec.patch
-kernel-doc-for-lib-bitmapc.patch
-kernel-doc-for-lib-cmdlinec.patch
-kernel-doc-for-lib-crcc.patch
-kthread-update-loopc-to-use-kthread.patch
-kthread-update-loopc-to-use-kthread-fix.patch
-kthread-convert-smbiod.patch
-kthread-convert-smbiod-tidy.patch
-initramfs-docs-update.patch
-cciss-disable-device-when-returning-failure.patch
-cciss-request-all-pci-resources.patch
-cciss-announce-cciss%d-devices-with-pci-address-irq-dac-info.patch
-cciss-use-array_size-without-intermediates.patch
-cciss-fix-a-few-spelling-errors.patch
-cciss-remove-parens-around-return-values.patch
-cciss-run-through-lindent.patch
-cciss-tidy-up-product-table-indentation.patch
-i-force-joystick-remove-some-pointless-casts.patch
-affs_fill_super-%s-abuses-2.patch
-kthread-convert-stop_machine-into-a-kthread.patch
-fs-sys_poll-with-timeout-1-bug-fix.patch
-cpu-hotplug-fix-cpu_up_cancel-handling.patch
-add-select-gpio_vr41xx-for-tanbac_tb0229.patch
-implement-at_symlink_follow-flag-for-linkat.patch
-fix-memory-leak-in-rocketport-rp_do_receive.patch
-kernel-doc-dont-use-xml-escapes-in-text-or-man-output.patch
-kernel-doc-use-members-for-struct-fields-consistently.patch
-reed-solomon-fix-kernel-doc-comments.patch
-ktime-hrtimer-fix-kernel-doc-comments.patch
-led-add-led-heartbeat-trigger.patch
-led-add-led-heartbeat-trigger-update.patch
-fix-bounds-check-in-vsnprintf-to-allow-for-a-0-size-and.patch
-fix-bounds-check-in-vsnprintf-to-allow-for-a-0-size-and-tidy.patch
-implement-kasprintf.patch
-dmi-cleanup-kernel-doc-add-to-docbook.patch
-kthread-move-kernel-doc-and-put-it-into-docbook.patch
-irda-usb-printk-fix.patch
-add-synclink_gt-custom-hdlc-idle.patch
-add-synclink_gt-crc-return-feature.patch
-fix-synclink_gt-diagnostics-error-reporting.patch
-synclink_gt-add-gt2-adapter-support.patch
-corrections-to-memory-barrier-doc.patch
-add-option-for-stripping-modules-while-installing-them.patch
-pacct-two-phase-process-accounting.patch
-pacct-avoidance-to-refer-the-last-thread-as-a-representation-of-the-process.patch
-pacct-none-delayed-process-accounting-accumulation.patch
-ext2-cleanup-put_page-and-comment-fix.patch
-au1550_ac97-spin_unlock-in-error-path.patch
-parport-add-to-kernel-doc.patch
-drivers-char-agp-nvidia-agpc-remove-unused-variable.patch
-au1xxx-oss-sound-support-for-au1200.patch
-s390-setupc-cleanup-build-fix.patch
-fix-kdump-crash-kernel-boot-memory-reservation-for-numa.patch
-fix-biovec-256-in-proc-slabinfo.patch
-remove-unlikelysb-in-prune_dcache.patch
-use-list_add_tail-instead-of-list_add.patch
-arch-use-list_move.patch
-core-use-list_move.patch
-net-rxrpc-use-list_move.patch
-drivers-use-list_move.patch
-fs-use-list_move.patch
-keys-sort-out-key-quota-system.patch
-keys-discard-the-contents-of-a-key-on-revocation.patch
-keys-let-keyctl_chown-change-a-keys-owner.patch
-keys-allocate-key-serial-numbers-randomly.patch
-keys-restrict-contents-of-proc-keys-to-viewable-keys.patch
-keys-add-a-way-to-store-the-appropriate-context-for-newly-created-keys.patch
-reiserfs-remove-reiserfs_aio_write.patch
-remove-old-hw-rng-support.patch
-add-new-generic-hw-rng-core.patch
-add-new-generic-hw-rng-core-cleanups.patch
-add-new-generic-hw-rng-core-hw_random-core-rewrite-chrdev-read-method.patch
-add-new-generic-hw-rng-core-maintainers.patch
-add-new-generic-hw-rng-core-hw_random-core-rewrite-chrdev-read-method-hw_random-core-block-read-if-o_nonblock.patch
-add-intel-hw-rng-driver.patch
-add-intel-hw-rng-driver-cleanups.patch
-add-amd-hw-rng-driver.patch
-add-geode-hw-rng-driver.patch
-add-geode-hw-rng-driver-cleanups.patch
-add-via-hw-rng-driver.patch
-add-via-hw-rng-driver-fix.patch
-add-via-hw-rng-driver-cleanups.patch
-add-ixp4xx-hw-rng-driver.patch
-add-ti-omap-cpu-family-hw-rng-driver.patch
-add-bcm43xx-hw-rng-support.patch
-add-bcm43xx-hw-rng-support-locking-update.patch
-ext3-add-o-bh-option.patch
-time-clocksource-infrastructure.patch
-time-clocksource-infrastructure-dont-enable-irq-too-early.patch
-time-use-clocksource-infrastructure-for-update_wall_time.patch
-time-use-clocksource-infrastructure-for-update_wall_time-mark-few-functions-as-__init.patch
-time-let-user-request-precision-from-current_tick_length.patch
-time-use-clocksource-abstraction-for-ntp-adjustments.patch
-time-use-clocksource-abstraction-for-ntp-adjustments-optimize-out-some-mults-since-gcc-cant-avoid-them.patch
-time-introduce-arch-generic-time-accessors.patch
-hangcheck-remove-monotomic_clock-on-x86.patch
-time-i386-conversion-part-1-move-timer_pitc-to-i8253c.patch
-time-i386-conversion-part-2-rework-tsc-support.patch
-time-i386-conversion-part-3-enable-generic-timekeeping.patch
-time-i386-conversion-part-4-remove-old-timer_opts-code.patch
-time-i386-clocksource-drivers.patch
-time-i386-clocksource-drivers-pm-timer-doesnt-use-workaround-if-chipset-is-not-buggy.patch
-time-i386-clocksource-drivers-pm-timer-doesnt-use-workaround-if-chipset-is-not-buggy-acpi_pm-cleanup.patch
-time-i386-clocksource-drivers-pm-timer-doesnt-use-workaround-if-chipset-is-not-buggy-acpi_pm-cleanup-fix-missing-to-rename-pmtmr_good-to-acpi_pm_good.patch
-time-i386-clocksource-drivers-fix-spelling-typos.patch
-time-rename-clocksource-functions.patch
-make-pmtmr_ioport-__read_mostly.patch
-generic-time-add-macro-to-simplify-hide-mask.patch
-time-fix-time-going-backward-w-clock=pit.patch
-fix-and-optimize-clock-source-update.patch
-kprobe-boost-2byte-opcodes-on-i386.patch
-kprobemulti-kprobe-posthandler-for-booster.patch
-kprobemulti-kprobe-posthandler-for-booster-kprobes-bugfix-of-kprobe-booster-reenable-kprobe-booster.patch
-notify-page-fault-call-chain-for-x86_64.patch
-notify-page-fault-call-chain-for-i386.patch
-notify-page-fault-call-chain-for-ia64.patch
-notify-page-fault-call-chain-for-powerpc.patch
-notify-page-fault-call-chain-for-sparc64.patch
-kprobes-registers-for-notify-page-fault.patch
-notify-page-fault-call-chain.patch
-capi-crash--race-condition.patch
-fix-typo-in-drivers-isdn-hisax-q931c.patch
-isdn4linux-gigaset-base-driver-improve-error-recovery.patch
-isdn4linux-gigaset-driver-cleanup.patch
-i4l-gigaset-drivers-add-ioctls-to-compat_ioctlh.patch
-kconfig-select-things-at-the-closest-tristate-instead-of-bool.patch
-proc-fix-the-inode-number-on-proc-pid-fd.patch
-proc-remove-useless-bkl-in-proc_pid_readlink.patch
-proc-remove-unnecessary-and-misleading-assignments.patch
-proc-simplify-the-ownership-rules-for-proc.patch
-proc-replace-proc_inodetype-with-proc_inodefd.patch
-proc-remove-bogus-proc_task_permission.patch
-proc-kill-proc_mem_inode_operations.patch
-proc-properly-filter-out-files-that-are-not-visible.patch
-proc-fix-the-link-count-for-proc-pid-task.patch
-proc-move-proc_maps_operations-into-task_mmuc.patch
-proc-rewrite-the-proc-dentry-flush-on-exit.patch
-proc-close-the-race-of-a-process-dying-durning.patch
-proc-refactor-reading-directories-of-tasks.patch
-proc-remove-tasklist_lock-from-proc_pid_readdir.patch
-proc-remove-tasklist_lock-from-proc_pid_lookup-and.patch
-proc-remove-tasklist_lock-from-proc_pid_readdir-simply-fix-first_tgid.patch
-proc-make-proc_numbuf-the-buffer-size-for-holding-a.patch
-proc-dont-lock-task_structs-indefinitely.patch
-proc-dont-lock-task_structs-indefinitely-task_mmu-small-fixes.patch
-proc-use-struct-pid-not-struct-task_ref.patch
-proc-optimize-proc_check_dentry_visible.patch
-proc-use-sane-permission-checks-on-the-proc-pid-fd.patch
-proc-cleanup-proc_fd_access_allowed.patch
-proc-remove-tasklist_lock-from-proc_task_readdir.patch
-simplify-fix-first_tid.patch
-cleanup-next_tid.patch
-selinux-add-sockcreate-node-to-procattr-api.patch
-de_thread-fix-lockless-do_each_thread.patch
-coredump-optimize-mm-users-traversal.patch
-coredump-speedup-sigkill-sending.patch
-coredump-kill-ptrace-related-stuff.patch
-coredump-kill-ptrace-related-stuff-fix.patch
-coredump-dont-take-tasklist_lock.patch
-coredump-some-code-relocations.patch
-coredump-shutdown-current-process-first.patch
-coredump-copy_process-dont-check-signal_group_exit.patch
-ide-pdc202xx_oldc-remove-unneeded-tuneproc-call.patch
-ide-remove-dma_base2-field-form-ide_hwif_t.patch
-fix-ide-locking-error.patch
-ide-io-increase-timeout-value-to-allow-for-slave-wakeup.patch
-ide-actually-honor-drives-minimum-pio-dma-cycle-times.patch
-ide-pdc202xx_old-remove-the-obsolete-busproc.patch
-fix-ide-deadlock-in-error-reporting-code.patch
-pdc202xx_old-depends-on-config_blk_dev_idedma.patch
-remove-code-that-has-long-been-commented-out-from-pdc20265_old.patch
-radeonfb-powerdrain-issue-on-ibm-thinkpads-and-suspend-to-d2.patch
-savagefb-allocate-space-for-current-and-saved-register.patch
-savagefb-add-state-save-and_restore-hooks.patch
-savagefb-add-state-save-and_restore-hooks-tidy.patch
-savagefb-add-state-save-and_restore-hooks-fix.patch
-backlight-locomo-backlight-driver-updates.patch
-fbdev-cleanup-the-config_video_select-mess.patch
-fbdev-remove-duplicate-includes.patch
-fbdev-more-accurate-sync-range-extrapolation.patch
-nvidiafb-revise-pci_device_id-table.patch
-atyfb-fix-hardware-cursor-handling.patch
-atyfb-remove-unneeded-calls-to-wait_for_idle.patch
-atyfb-set-correct-acceleration-flags.patch
-epson1355fb-update-platform-code.patch
-vesafb-update-platform-code.patch
-vfb-update-platform-code.patch
-vga16fb-update-platform-code.patch
-fbdev-static-pseudocolor-with-depth-less-than-4-does.patch
-savagefb-whitespace-cleanup.patch
-fbdev-firmware-edid-fixes.patch
-fbdev-firmware-edid-fixes-fix.patch
-nvidiafb-add-support-for-geforce-6100-and-related-chipsets.patch
-fbdev-add-1366x768-wxga-mode-to-mode-database.patch
-vesafb-fix-return-code-of-vesafb_setcolreg.patch
-vesafb-prefer-vga-registers-over-pmi.patch
-vt-delay-the-update-of-the-visible-console.patch
-atyfb-fix-dead-code.patch
-fbdev-coverity-bug-85.patch
-fbdev-coverity-bug-90.patch
-fbdev-remove-unused-exports.patch
-s3c2410fb-fix-resume.patch
-backlight-fix-kconfig-dependency.patch
-au1100fb-add-power-management-support.patch
-au1100fb-add-power-management-support-tidy.patch
-skeletonfb-remove-duplicate-module-init-exit-license-lines.patch
-neofb-fix-unblank-logic-interfering-with-lid-toggled-backlight.patch
-gxfb-get-the-frambuffer-size-from-the-bios.patch
-fbdev-fix-logo-rotation-if-width-=-height.patch
-macmodes-fix-section-warning.patch
-atyfb-fix-section-warnings.patch
-detaching-fbcon-fix-vgacon-to-allow-retaking-of-the.patch
-detaching-fbcon-fix-give_up_console.patch
-detaching-fbcon-remove-calls-to-pci_disable_device.patch
-detaching-fbcon-add-sysfs-class-device-entry-for-fbcon.patch
-detaching-fbcon-clean-up-exit-code.patch
-detaching-fbcon-add-capability-to-attach-detach-fbcon.patch
-detaching-fbcon-update-documentation.patch
-vt-binding-add-binding-unbinding-support-for-the-vt.patch
-vt-binding-update-fbcon-to-support-binding.patch
-vt-binding-fbcon-update-documentation.patch
-vt-binding-add-new-doc-file-describing-the-feature.patch
-vt-binding-add-sysfs-control-to-the-vt-layer.patch
-vt-binding-add-sysfs-control-to-the-vt-layer-fix.patch
-vt-binding-make-vt-binding-a-kconfig-option.patch
-vt-binding-do-not-create-a-device-file-for-class-device.patch
-vt-binding-update-documentation.patch
-vt-binding-make-mdacon-support-binding.patch
-vt-binding-make-newport_con-support-binding.patch
-vt-binding-make-promcon-support-binding.patch
-vt-binding-make-sticon-support-binding.patch
-dm-snapshot-unify-chunk_size.patch
-lib-add-idr_replace.patch
-lib-add-idr_replace-tidy.patch
-dm-fix-idr-minor-allocation.patch
-dm-move-idr_pre_get.patch
-dm-change-minor_lock-to-spinlock.patch
-dm-add-dmf_freeing.patch
-dm-fix-mapped-device-ref-counting.patch
-dm-add-module-ref-counting.patch
-dm-fix-block-device-initialisation.patch
-dm-mirror-sector-offset-fix.patch
-dm-table-get_target-fix-last-index.patch
-dm-mirror-log-sector-size-fix.patch
-dm-mirror-log-refactor-context.patch
-dm-mirror-log-bitset_size-fix.patch
-dm-mirror-log-sync_count-fix.patch
-dm-kcopyd-error-accumulation-fix.patch
-dm-table-split_args-handle-no-input.patch
-dm-consolidate-creation-functions.patch
-dm-add-exports-2.patch
-dm-create-error-table.patch
-dm-prevent-removal-if-open.patch
-dm-improve-error-message-consistency.patch
-md-reformat-code-in-raid1_end_write_request-to-avoid-goto.patch
-md-remove-arbitrary-limit-on-chunk-size.patch
-md-remove-useless-ioctl-warning.patch
-md-increase-the-delay-before-marking-metadata-clean-and-make-it-configurable.patch
-md-merge-raid5-and-raid6-code.patch
-md-remove-nuisance-message-at-shutdown.patch
-md-allow-checkpoint-of-recovery-with-version-1-superblock.patch
-md-allow-checkpoint-of-recovery-with-version-1-superblock-fix.patch
-md-allow-a-linear-array-to-have-drives-added-while-active.patch
-md-support-stripe-offset-mode-in-raid10.patch
-md-make-md_print_devices-static.patch
-md-split-reshape-portion-of-raid5-sync_request-into-a-separate-function.patch
-md-bitmap-fix-online-removal-of-file-backed-bitmaps.patch
-md-bitmap-remove-bitmap-writeback-daemon.patch
-md-bitmap-cleaner-separation-of-page-attribute-handlers-in-md-bitmap.patch
-md-bitmap-use-set_bit-etc-for-bitmap-page-attributes.patch
-md-bitmap-remove-unnecessary-page-reference-manipulations-from-md-bitmap-code.patch
-md-bitmap-remove-dead-code-from-md-bitmap.patch
-md-bitmap-tidy-up-i_writecount-handling-in-md-bitmap.patch
-md-bitmap-change-md-bitmap-file-handling-to-use-bmap-to-file-blocks.patch
-md-change-md-bitmap-file-handling-to-use-bmap-to-file-blocks-fix.patch
-md-calculate-correct-array-size-for-raid10-in-new-offset-mode.patch
-md-md-kconfig-speeling-feex.patch
-md-fix-kconfig-error.patch
-md-fix-bug-that-stops-raid5-resync-from-happening.patch
-md-allow-re-add-to-work-on-array-without-bitmaps.patch
-md-dont-write-dirty-clean-update-to-spares-leave-them-alone.patch
-md-set-get-state-of-array-via-sysfs.patch
-md-allow-rdev-state-to-be-set-via-sysfs.patch
-md-allow-raid-layout-to-be-read-and-set-via-sysfs.patch
-md-allow-resync_start-to-be-set-and-queried-via-sysfs.patch
-md-allow-the-write_mostly-flag-to-be-set-via-sysfs.patch
-drivers-md-mdc-make-code-static.patch

 Merged into mainline or a subsystem tree.
 
+patch-kernel-acct-fix-function-definition.patch
+zlib-inflate-fix-function-definitions.patch
+pm_trace-is-bust.patch

 misc 2.6.17 stuff.

-disable-acpi-on-some-phoenix-bios.patch

 Dropped.

-cpu_relax-use-in-acpi-lock-fix.patch

 Folded into cpu_relax-use-in-acpi-lock.patch

+gregkh-driver-driver-core-fix-driver-core-kernel-doc.patch

 driver trees update

+gregkh-i2c-w1-remove-w1-mail-list-from-lm_sensors.patch

 i2c tree update

+git-geode-fixup.patch

 Fix reject due to git-geode.patch.

+git-gfs2-fixup.patch

 Fix reject due to git-gfs2.patch

-git-kbuild-revert-kbuild-ignore-makes-built-in-rules-variables.patch

 Dropped.

+revert-ignore-makes-built-in-rules-variables.patch

 Then restored.

+make-variables-static-after-klibc-merge.patch

 klibc cleanup

-git-hdrinstall-fixup.patch

 Dropped.

-via-pata-fails-on-some-atapi-drives.patch

 Dropped (I think)

+via-pata-controller-xfer-fixes.patch
+make-drivers-scsi-pata_it821xcit821x_passthru_dev_select-static.patch

 ata fixes

-s2io-driver-irq-fix-tidy.patch

 Folded into s2io-driver-irq-fix.patch

-qla3xxx-is-bust.patch

 Dropped.

+qla3xxx-nic-driver-updates.patch

 Update qla3xxx-NIC-driver.patch

+ioat-fix-sparse-ulong-warning.patch

 IOAT driver fix

+serial-add-tsi108-8250-serial-support-fix.patch

 serial device support

+git-scsi-misc-fixup.patch

 Fix reject due to git-scsi-misc.patch

+drivers-scsi-arcmsr-cleanups.patch

 Tidy areca-raid-linux-scsi-driver.patch

+dc395x-fix-printk-format-warning.patch

 scsi driver fixlet.

+gregkh-usb-usb-au1xxx-compile-fixes-for-ohci-for-au1200.patch
+gregkh-usb-usb-au1200-ehci-and-ohci-fixes.patch
+gregkh-usb-usb-ohci-bits-for-the-cirrus-ep93xx.patch
+gregkh-usb-usb-fix-usb-kernel-doc.patch
+gregkh-usb-usb-addition-of-vendor-product-id-pair-for-pl2303-driver.patch
+gregkh-usb-usb-new-device-id-for-thorlabs-motor-driver.patch
+gregkh-usb-usb-new-device-ids-for-ftdi_sio-driver.patch
+gregkh-usb-usb-ohci-hub-code-unaligned-access.patch
+gregkh-usb-usb-fix-usb-serial-leaks-oopses-on-disconnect.patch
+gregkh-usb-usb-fix-visor-leaks.patch
+gregkh-usb-usb-add-some-basic-wusb-definitions.patch
+gregkh-usb-usb-support-for-susteen-datapilot-universal-2-cable-in-pl2303.patch
+gregkh-usb-usbfs-use-the-correct-signal-number-for-disconnection.patch
+gregkh-usb-usb-rename-cypress-cy7c63xxx-driver-to-proper-name-and-fix-up-some-tiny-things.patch
+gregkh-usb-usb-update-for-acm-in-quirks-and-debug.patch
+gregkh-usb-usb-storage-fix-race-between-reset-and-disconnect.patch
+gregkh-usb-usb-hub-don-t-return-status-0-from-resume.patch
+gregkh-usb-usb-storage-unusual_devs-entry-for-motorola-razr-v3x.patch

 USB tree updates (be afraid)

-ipaqc-timing-parameters-fix.patch

 Folded into ipaqc-timing-parameters.patch

+x86_64-mm-ieee1394-early.patch

 x86_64 tree update

-revert-x86_64-mm-twofish-cipher---x86_64-assembler.patch
-revert-x86_64-mm-twofish-cipher---i586-assembler.patch
-revert-x86_64-mm-twofish-cipher---priority-fix.patch
-revert-x86_64-mm-twofish-cipher---split-out-common-c-code.patch

 Unneeded.

-x86_64-mm-moving-phys_proc_id-and-cpu_core_id-to-cpuinfo_x86-warning-fix.patch
-x86_64-msi-apic-build-fix.patch
-x86-nmi-fix.patch
-x86-nmi-fix-2.patch
-x86_64-apic-fix-apic-error-on-bootup.patch

 Mostly dropped.

-flatmem-relax-requirement-for-memory-to-start-at-pfn-0.patch

 Dropped.

+adix-tree-rcu-lockless-readside-fix-2.patch

 fix radix-tree patches in -mm.

-zoned-vm-counters-conversion-of-nr_dirty-to-per-zone-counter-nfs-fix.patch

 Dropped, I think.

+use-zoned-vm-counters-for-numa-statistics-v3.patch
+light-weight-event-counters-v5.patch

 More VM counters work.

+selinux-inherit-proc-self-attr-keycreate-across-fork.patch

 SELinux update

-x86-re-enable-generic-numa.patch

 Dropped, it broke.

+fix-subarchitecture-breakage-with-config_sched_smt.patch
+voyager-fix-compile-after-setup-rework.patch
+fix-boot-on-efi-32-bit-machines.patch

 x86 stuff.

+apple-motion-sensor-driver-update.patch
+apple-motion-sensor-driver-update-2.patch

 Fix apple-motion-sensor-driver.patch

+rtc-add-a-comment-for-enoioctlcmd-in-ds1553_rtc_ioctl.patch
+ufs-ufs_read_inode-cleanup.patch
+tty-fix-tcsbrk-comment.patch
+fix-kernel-doc-in-kernel-dir.patch
+remove-active-field-from-tty-buffer-structure.patch
+rcutorture-catchup-doc-fixes-for-idle-hz-tests.patch
+rcutorture-add-ops-vector-and-classic-rcu-ops.patch
+rcutorture-add-call_rcu_bh-operations.patch
+ipmi-use-schedule-in-kthread.patch
+kdump-introduce-reset_devices-command-line-option.patch
+stallion-clean-up.patch
+rtc-fix-idr-locking.patch

 Misc patches.

-introduce-crashboot-kernel-command-line-parameter.patch
-kdump-cciss-driver-initialization-issue-fix.patch

 Dropped.

+cpu-hotplug-make-register_cpu_notifier-init-time-only-fix-fix.patch

 Fix cpu-hotplug-make-register_cpu_notifier-init-time-only.patch some more.

+cpu-hotplug-make-cpu_notifier-related-notifier-calls-__cpuinit-only-fix-fix.patch

 Fix
 cpu-hotplug-make-cpu_notifier-related-notifier-calls-__cpuinit-only.patch
 some more.

+delay-accounting-taskstats-interface-send-tgid-once.patch
+delay-accounting-taskstats-interface-send-tgid-once-fixes.patch
+per-task-delay-accounting-avoid-send-without-listeners.patch

 Update the task accounting patches.

-chardev-gpio-for-scx200-pc-8736x-add-platforn_device-static-numpins.patch
-chardev-gpio-for-scx200-pc-8736x-add-platforn_device-enomem-on-device_add-failure.patch
-chardev-gpio-for-scx200-pc-8736x-add-platforn_device-scx200-init-undo-malloc.patch

 Folded into chardev-gpio-for-scx200-pc-8736x-add-platforn_device.patch

-chardev-gpio-for-scx200-pc-8736x-add-new-pc8736x_gpio-no-static-init.patch
-chardev-gpio-for-scx200-pc-8736x-add-new-pc8736x_gpio-no-weird-comment-placement.patch
-chardev-gpio-for-scx200-pc-8736x-add-new-pc8736x_gpio-fixups.patch

 Folded into chardev-gpio-for-scx200-pc-8736x-add-new-pc8736x_gpio.patch

-chardev-gpio-for-scx200-pc-8736x-add-platform_device-request-region.patch
-chardev-gpio-for-scx200-pc-8736x-add-platform_device-request-region-series.patch

 Folded into chardev-gpio-for-scx200-pc-8736x-add-platform_device.patch

-chardev-gpio-for-scx200-pc-8736x-use-dev_dbg-extern-to-header.patch

 Folded into chardev-gpio-for-scx200-pc-8736x-use-dev_dbg.patch

-chardev-gpio-for-scx200-pc-8736x-fix-gpio_current-make-precedence-explicit.patch

 Folded into chardev-gpio-for-scx200-pc-8736x-fix-gpio_current.patch

-chardev-gpio-for-scx200-pc-8736x-replace-spinlocks-fix.patch

 Folded into chardev-gpio-for-scx200-pc-8736x-replace-spinlocks.patch

+knfsd-improve-the-test-for-cross-device-rename-in-nfsd.patch
+knfsd-fixing-missing-expkey-support-for-fsid-type-3.patch
+knfsd-remove-noise-about-filehandle-being-uptodate.patch
+knfsd-ignore-ref_fh-when-crossing-a-mountpoint.patch
+knfsd-nfsd4-fix-open_confirm-locking.patch
+knfsd-nfsd-call-nfsd_setuser-on-fh_compose-fix-nfsd4-permissions-problem.patch
+knfsd-nfsd4-remove-superfluous-grace-period-checks.patch
+knfsd-nfsd-fix-misplaced-fh_unlock-in-nfsd_link.patch
+knfsd-svcrpc-gss-simplify-rsc_parse.patch
+knfsd-nfsd4-fix-some-open-argument-tests.patch
+knfsd-nfsd4-fix-open-flag-passing.patch
+knfsd-svcrpc-simplify-nfsd-rpcsec_gss-integrity-code.patch
+knfsd-nfsd-mark-rqstp-to-prevent-use-of-sendfile-in-privacy-case.patch
+knfsd-svcrpc-gss-server-side-implementation-of-rpcsec_gss-privacy.patch

 nfsd updates

-sched_exit-fix-parent-time_slice-calculation.patch
-sched_exit-move-the-callsite-to-do_exit.patch

 Dropped.

-ecryptfs-superblock-operations-ecryptfs-build-fix.patch

 Dropped.

+ecryptfs-superblock-operations-ecryptfs_statfs-api-change.patch

 ecryptfs update

+readahead-kconfig-option-readahead_allow_overheads.patch
+readahead-state-based-method-aging-accounting-readahead-kconfig-option-readahead_smooth_aging.patch
+readahead-context-based-method-slow-start.patch
+readahead-call-scheme-no-fastcall-for-readahead_cache_hit-kconfig-option-readahead_hit_feedback.patch
+readahead-backward-prefetching-method-fix.patch
+readahead-remove-the-size-limit-of-max_sectors_kb-on-read_ahead_kb.patch

 readahead updates

+old-ide-fix-sata-detection-for-cabling.patch
+ide-clean-up-siimage.patch
+ide-sc1200-debug-printk.patch
+ide-fix-error-handling-for-drives-which-clear-the-fifo-on-error.patch
+ide-housekeeping-on-ide-drivers.patch
+ide-clean-up-pdc202xx_old-so-its-more-readable-done-so-i-could-work-on-libata-ports.patch
+ide-set-err_stops_fifo-for-newer-promise-as-well.patch

 IDE updates

+drivers-md-raid5c-remove-an-unused-variable.patch
+md-possible-fix-for-unplug-problem.patch
+md-set-desc_nr-correctly-for-version-1-superblocks.patch
+md-delay-starting-md-threads-until-array-is-completely-setup.patch
+md-fix-resync-speed-calculation-for-restarted-resyncs.patch
+md-fix-a-plug-unplug-race-in-raid5.patch
+md-fix-some-small-races-in-bitmap-plugging-in-raid5.patch
+md-fix-usage-of-wrong-variable-in-raid1.patch
+md-unify-usage-of-symbolic-names-for-perms.patch
+md-require-cap_sys_admin-for-re-configuring-md-devices-via-sysfs.patch
+md-fix-will-configure-message-when-interpreting-md=-kernel-parameter.patch
+md-include-sector-number-in-messages-about-corrected-read-errors.patch

 RAID updates

+genirq-core-revert-noisiness-on-spurious-interrupts.patch

 Fixlet for genirq-core.patch

+lockdep-floppyc-irq-release-fix.patch
+lockdep-acpi-locking-fix.patch
+lockdep-console_init-after-local_irq_enable.patch
+lockdep-add-is_module_address.patch
+lockdep-add-print_ip_sym.patch
+lockdep-add-per_cpu_offset.patch
+lockdep-add-disable-enable_irq_lockdep-api.patch
+lockdep-add-local_irq_enable_in_hardirq-api.patch
+lockdep-add-declare_completion_onstack-api.patch
+lockdep-clean-up-rwsems.patch
+lockdep-remove-rwsem_debug-remnants.patch
+lockdep-rename-debug_warn_on.patch
+lockdep-remove-debug_bug_on.patch
+lockdep-remove-mutex-deadlock-checking-code.patch
+lockdep-better-lock-debugging.patch
+lockdep-mutex-section-binutils-workaround.patch
+lockdep-locking-init-debugging-improvement.patch
+lockdep-beautify-x86_64-stacktraces.patch
+lockdep-x86_64-document-stack-frame-internals.patch
+lockdep-i386-remove-multi-entry-backtraces.patch
+lockdep-stacktrace-subsystem-core.patch
+lockdep-s390-config_frame_pointer-support.patch
+lockdep-stacktrace-subsystem-i386-support.patch
+lockdep-stacktrace-subsystem-x86_64-support.patch
+lockdep-stacktrace-subsystem-s390-support.patch
+lockdep-irqtrace-subsystem-core.patch
+lockdep-irqtrace-subsystem-docs.patch
+lockdep-irqtrace-subsystem-i386-support.patch
+lockdep-irqtrace-cleanup-of-include-asm-i386-irqflagsh.patch
+lockdep-irqtrace-subsystem-x86_64-support.patch
+lockdep-irqtrace-subsystem-x86_64-support-fix.patch
+lockdep-irqtrace-subsystem-x86_64-support-fix-2.patch
+lockdep-irqtrace-cleanup-of-include-asm-x86_64-irqflagsh.patch
+lockdep-irqtrace-subsystem-s390-support.patch
+lockdep-locking-api-self-tests.patch
+lockdep-core.patch
+lockdep-design-docs.patch
+lockdep-procfs.patch
+lockdep-prove-rwsem-locking-correctness.patch
+lockdep-prove-spinlock-rwlock-locking-correctness.patch
+lockdep-prove-mutex-locking-correctness.patch
+lockdep-kconfig.patch
+lockdep-print-all-lock-classes-on-sysrq-d.patch
+lockdep-x86_64-early-init.patch
+lockdep-x86-smp-alternatives-workaround.patch
+lockdep-do-not-recurse-in-printk.patch
+lockdep-fix-rt_hash_lock_sz.patch
+lockdep-s390-turn-validator-off-in-machine-check-handler.patch
+lockdep-enable-on-i386.patch
+lockdep-enable-on-x86_64.patch
+lockdep-enable-on-s390.patch
+lockdep-annotate-direct-io.patch
+lockdep-annotate-serial.patch
+lockdep-annotate-dcache.patch
+lockdep-annotate-i_mutex.patch
+lockdep-annotate-futex.patch
+lockdep-annotate-genirq.patch
+lockdep-annotate-waitqueues.patch
+lockdep-annotate-mm.patch
+lockdep-annotate-serio.patch
+lockdep-annotate-skb_queue_head_init.patch
+lockdep-annotate-timer-base-locks.patch
+lockdep-annotate-scheduler-runqueue-locks.patch
+lockdep-annotate-hrtimer-base-locks.patch
+lockdep-annotate-sock_lock_init.patch
+lockdep-annotate-af_unix-locking.patch
+lockdep-annotate-bh_lock_sock.patch
+lockdep-annotate-ieee1394-skb-queue-head-locking.patch
+lockdep-annotate-mmap_sem.patch
+lockdep-annotate-sunrpc-code.patch
+lockdep-annotate-ntfs-locking-rules.patch
+lockdep-annotate-the-quota-code.patch
+lockdep-annotate-usbfs.patch
+lockdep-annotate-sound-core-seq-seq_portsc.patch
+lockdep-annotate-sound-core-seq-seq_devicec.patch
+lockdep-annotate-8390c-disable_irq.patch
+lockdep-annotate-3c59xc-disable_irq.patch
+lockdep-annotate-forcedethc-disable_irq.patch
+lockdep-annotate-enable_in_hardirq.patch
+lockdep-annotate-on-stack-completions.patch
+lockdep-annotate-qeth-driver.patch
+lockdep-annotate-s_lock.patch
+lockdep-annotate-sb-s_umount.patch
+lockdep-annotate-slab-code.patch
+lockdep-annotate-blkdev-nesting.patch
+lockdep-annotate-vlan-net-device-as-being-a-special-class.patch

 Locking validator

-acpi-reduce-code-size-clean-up-fix-validator-message.patch

 Dropped.

+srcu-rcu-variant-permitting-read-side-blocking.patch
+srcu-rcu-variant-permitting-read-side-blocking-fixes.patch
+srcu-add-srcu-operations-to-rcutorture.patch
+srcu-add-srcu-operations-to-rcutorture-fix.patch

 New RCU features

+ioctl-messtxt-xfs-typos.patch

 Update documentation-ioctl-messtxt-start-tree-wide-ioctl-registry.patch


All 825 patches:

ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.17/2.6.17-mm3/patch-list



^ permalink raw reply	[flat|nested] 42+ messages in thread

* 2.6.17-mm3: no help text for READAHEAD_ALLOW_OVERHEADS
  2006-06-27  8:52 2.6.17-mm3 Andrew Morton
@ 2006-06-27  9:14 ` Adrian Bunk
       [not found]   ` <20060627134337.GA6117@mail.ustc.edu.cn>
  2006-06-27  9:28 ` [patch] irq: fix arch/i386/kernel/irq.c gcc warning Ingo Molnar
                   ` (12 subsequent siblings)
  13 siblings, 1 reply; 42+ messages in thread
From: Adrian Bunk @ 2006-06-27  9:14 UTC (permalink / raw)
  To: Andrew Morton, Wu Fengguang; +Cc: linux-kernel

On Tue, Jun 27, 2006 at 01:52:11AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.17-mm2:
> +readahead-kconfig-option-readahead_allow_overheads.patch
>...
>  readahead updates
>...

The READAHEAD_ALLOW_OVERHEADS option lacks a help text.

Additionally, the "default n" is pointless and should be removed.
 
cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] 42+ messages in thread

* [patch] irq: fix arch/i386/kernel/irq.c gcc warning
  2006-06-27  8:52 2.6.17-mm3 Andrew Morton
  2006-06-27  9:14 ` 2.6.17-mm3: no help text for READAHEAD_ALLOW_OVERHEADS Adrian Bunk
@ 2006-06-27  9:28 ` Ingo Molnar
  2006-06-27 11:06   ` Björn Steinbrink
  2006-06-27 11:14 ` x86_64-mm-ieee1394-early.patch (was Re: 2.6.17-mm3) Stefan Richter
                   ` (11 subsequent siblings)
  13 siblings, 1 reply; 42+ messages in thread
From: Ingo Molnar @ 2006-06-27  9:28 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel, Linus Torvalds


* Andrew Morton <akpm@osdl.org> wrote:

> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.17/2.6.17-mm3/

> Changes since 2.6.17-mm2:
> 
>  origin.patch

upstream grew a new compiler warning in i386 irq.c. Patch below fixes 
it. No change in resulting irq.o code.

	Ingo

-------------
Subject: irq: fix arch/i386/kernel/irq.c gcc warning
From: Ingo Molnar <mingo@elte.hu>

add parantheses. (code was fine because & has a higher precedence than |,
but it's a dangerous construct in general and gcc also emits a warning)

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/i386/kernel/irq.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: linux/arch/i386/kernel/irq.c
===================================================================
--- linux.orig/arch/i386/kernel/irq.c
+++ linux/arch/i386/kernel/irq.c
@@ -104,8 +104,8 @@ fastcall unsigned int do_IRQ(struct pt_r
 		 * softirq checks work in the hardirq context.
 		 */
 		irqctx->tinfo.preempt_count =
-			irqctx->tinfo.preempt_count & ~SOFTIRQ_MASK |
-			curctx->tinfo.preempt_count & SOFTIRQ_MASK;
+			(irqctx->tinfo.preempt_count & ~SOFTIRQ_MASK) |
+			(curctx->tinfo.preempt_count & SOFTIRQ_MASK);
 
 		asm volatile(
 			"       xchgl   %%ebx,%%esp      \n"

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: [patch] irq: fix arch/i386/kernel/irq.c gcc warning
  2006-06-27  9:28 ` [patch] irq: fix arch/i386/kernel/irq.c gcc warning Ingo Molnar
@ 2006-06-27 11:06   ` Björn Steinbrink
  0 siblings, 0 replies; 42+ messages in thread
From: Björn Steinbrink @ 2006-06-27 11:06 UTC (permalink / raw)
  To: Ingo Molnar; +Cc: Andrew Morton, linux-kernel, Linus Torvalds

On 2006.06.27 11:28:01 +0200, Ingo Molnar wrote:
> 
> * Andrew Morton <akpm@osdl.org> wrote:
> 
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.17/2.6.17-mm3/
> 
> > Changes since 2.6.17-mm2:
> > 
> >  origin.patch
> 
> upstream grew a new compiler warning in i386 irq.c. Patch below fixes 
> it. No change in resulting irq.o code.

Yep, that's my fault, Jean Delvare did also sent a patch yesterday.

http://lkml.org/lkml/2006/6/26/380

Björn

^ permalink raw reply	[flat|nested] 42+ messages in thread

* x86_64-mm-ieee1394-early.patch  (was Re: 2.6.17-mm3)
  2006-06-27  8:52 2.6.17-mm3 Andrew Morton
  2006-06-27  9:14 ` 2.6.17-mm3: no help text for READAHEAD_ALLOW_OVERHEADS Adrian Bunk
  2006-06-27  9:28 ` [patch] irq: fix arch/i386/kernel/irq.c gcc warning Ingo Molnar
@ 2006-06-27 11:14 ` Stefan Richter
  2006-06-27 11:17 ` 2.6.17-mm3 Reuben Farrelly
                   ` (10 subsequent siblings)
  13 siblings, 0 replies; 42+ messages in thread
From: Stefan Richter @ 2006-06-27 11:14 UTC (permalink / raw)
  To: Andi Kleen; +Cc: Andrew Morton, linux1394-devel, linux-kernel

Andrew Morton wrote:
> +x86_64-mm-ieee1394-early.patch
> 
>  x86_64 tree update

>From the patch:
|| Initialize ieee1394 early when built in
||
|| This makes debugging with firescope easier.
||
|| Cc: linux1394-devel@lists.sourceforge.net
||
|| Signed-off-by: Andi Kleen <ak@suse.de>
...
|| +++ linux/drivers/ieee1394/ieee1394_core.c
...
|| +#ifndef MODULE
|| +fs_initcall(ieee1394_init);
|| +#else
||  module_init(ieee1394_init);
|| +#endif
...
|| +++ linux/drivers/ieee1394/ohci1394.c
...
|| +/* Try to register 1394 early to get the DMA engine running for
debugging purposes */
|| +#ifndef MODULE
|| +fs_initcall(ohci1394_init);
|| +#else
||  module_init(ohci1394_init);
|| +#endif
...

Perhaps it doesn't matter, but shouldn't it rather be a
subsys_initcall(ieee1394_init)?

[fs_initcall(ohci1394_init) instead of device_initcall(ohci1394_init) is
certainly appropriate if you want to have it up and running before other
device drivers.]

Also, I suggest an 80 columns friendly comment:
/* Register early.  Useful for remote debugging via physical DMA */
-- 
Stefan Richter
-=====-=-==- -==- ==-=-
http://arcgraph.de/sr/

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: 2.6.17-mm3
  2006-06-27  8:52 2.6.17-mm3 Andrew Morton
                   ` (2 preceding siblings ...)
  2006-06-27 11:14 ` x86_64-mm-ieee1394-early.patch (was Re: 2.6.17-mm3) Stefan Richter
@ 2006-06-27 11:17 ` Reuben Farrelly
  2006-06-27 11:48 ` 2.6.17-mm3 Reuben Farrelly
                   ` (9 subsequent siblings)
  13 siblings, 0 replies; 42+ messages in thread
From: Reuben Farrelly @ 2006-06-27 11:17 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel, Neil Brown



On 27/06/2006 8:52 p.m., Andrew Morton wrote:
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.17/2.6.17-mm3/
> 
> 
> - Added the x86 Geode development tree to the -mm lineup, as git-geode.patch
>   (Jordan Crouse).
> 
> - The locking validator patches are back, in a reworked series.

Hrm:

md: sdc6 has different UUID to sdc7
md: sdc5 has different UUID to sdc7
md: sdc3 has different UUID to sdc7
md: sdc2 has different UUID to sdc7
md:  adding sda7 ...
md: sda6 has different UUID to sdc7
md: sda5 has different UUID to sdc7
md: sda3 has different UUID to sdc7
md: sda2 has different UUID to sdc7
md: created md4
md: bind<sda7>
md: bind<sdc7>
md: running: <sdc7><sda7>
md: kicking non-fresh sda7 from array!
md: unbind<sda7>
md: export_rdev(sda7)
BUG: warning at fs/block_dev.c:1109/__blkdev_put()

Call Trace:
  [<ffffffff802c00b2>] __blkdev_put+0x9c/0x1bb
  [<ffffffff802c01df>] blkdev_put_partition+0xe/0x10
  [<ffffffff8041f174>] unlock_rdev+0x49/0x50
  [<ffffffff8041f1fb>] export_rdev+0x80/0x90
  [<ffffffff80285919>] printk+0x67/0x69
  [<ffffffff8041f2c2>] kick_rdev_from_array+0x19/0x27
  [<ffffffff8042126c>] do_md_run+0x11c/0x7b8
  [<ffffffff8041fc35>] bind_rdev_to_array+0x1f5/0x210
  [<ffffffff8041fe6b>] mddev_find+0x82/0x1dd
  [<ffffffff8042012f>] md_probe+0x169/0x17a
  [<ffffffff80421bf4>] autorun_devices+0x2ec/0x379
  [<ffffffff8033b5da>] selinux_capable+0x24/0x29
  [<ffffffff804247c5>] md_ioctl+0x135/0x154f
  [<ffffffff8033ace3>] avc_has_perm+0x49/0x5b
  [<ffffffff80350c72>] blkdev_driver_ioctl+0x62/0x80
  [<ffffffff80351386>] blkdev_ioctl+0x6f6/0x75a
  [<ffffffff8023f584>] wake_up_inode+0x18/0x24
  [<ffffffff8033b463>] inode_has_perm+0x62/0x71
  [<ffffffff802c0982>] blkdev_open+0x0/0x61
  [<ffffffff802c09ae>] blkdev_open+0x2c/0x61
  [<ffffffff8033b51c>] file_has_perm+0xaa/0xb9
  [<ffffffff802bfa32>] block_ioctl+0x1b/0x1f
  [<ffffffff8024328a>] do_ioctl+0x2a/0x8f
  [<ffffffff802316eb>] vfs_ioctl+0x27b/0x2a0
  [<ffffffff8024e7ca>] sys_ioctl+0x5f/0x82
  [<ffffffff8022f97d>] sys_fcntl+0x33d/0x34f
  [<ffffffff8025ff7a>] system_call+0x7e/0x83

BUG: warning at fs/block_dev.c:1128/__blkdev_put()

Call Trace:
  [<ffffffff80357be8>] kobject_put+0x19/0x21
  [<ffffffff802c0194>] __blkdev_put+0x17e/0x1bb
  [<ffffffff802c01df>] blkdev_put_partition+0xe/0x10
  [<ffffffff8041f174>] unlock_rdev+0x49/0x50
  [<ffffffff8041f1fb>] export_rdev+0x80/0x90
  [<ffffffff80285919>] printk+0x67/0x69
  [<ffffffff8041f2c2>] kick_rdev_from_array+0x19/0x27
  [<ffffffff8042126c>] do_md_run+0x11c/0x7b8
  [<ffffffff8041fc35>] bind_rdev_to_array+0x1f5/0x210
  [<ffffffff8041fe6b>] mddev_find+0x82/0x1dd
  [<ffffffff8042012f>] md_probe+0x169/0x17a
  [<ffffffff80421bf4>] autorun_devices+0x2ec/0x379
  [<ffffffff8033b5da>] selinux_capable+0x24/0x29
  [<ffffffff804247c5>] md_ioctl+0x135/0x154f
  [<ffffffff8033ace3>] avc_has_perm+0x49/0x5b
  [<ffffffff80350c72>] blkdev_driver_ioctl+0x62/0x80
  [<ffffffff80351386>] blkdev_ioctl+0x6f6/0x75a
  [<ffffffff8023f584>] wake_up_inode+0x18/0x24
  [<ffffffff8033b463>] inode_has_perm+0x62/0x71
  [<ffffffff802c0982>] blkdev_open+0x0/0x61
  [<ffffffff802c09ae>] blkdev_open+0x2c/0x61
  [<ffffffff8033b51c>] file_has_perm+0xaa/0xb9
  [<ffffffff802bfa32>] block_ioctl+0x1b/0x1f
  [<ffffffff8024328a>] do_ioctl+0x2a/0x8f
  [<ffffffff802316eb>] vfs_ioctl+0x27b/0x2a0
  [<ffffffff8024e7ca>] sys_ioctl+0x5f/0x82
  [<ffffffff8022f97d>] sys_fcntl+0x33d/0x34f
  [<ffffffff8025ff7a>] system_call+0x7e/0x83

raid1: raid set md4 active with 1 out of 2 mirrors
md4: bitmap initialized from disk: read 4/4 pages, set 80 bits, status: 0
created bitmap (61 pages) for device md4
md: considering sdc6 ...
md:  adding sdc6 ...
md: sdc5 has different UUID to sdc6
md: sdc3 has different UUID to sdc6
md: sdc2 has different UUID to sdc6
md:  adding sda6 ...
md: sda5 has different UUID to sdc6
md: sda3 has different UUID to sdc6
md: sda2 has different UUID to sdc6
md: created md3
md: bind<sda6>
md: bind<sdc6>
md: running: <sdc6><sda6>
md: kicking non-fresh sda6 from array!
md: unbind<sda6>
md: export_rdev(sda6)
BUG: warning at fs/block_dev.c:1109/__blkdev_put()

Call Trace:
  [<ffffffff802c00b2>] __blkdev_put+0x9c/0x1bb
  [<ffffffff802c01df>] blkdev_put_partition+0xe/0x10
  [<ffffffff8041f174>] unlock_rdev+0x49/0x50
  [<ffffffff8041f1fb>] export_rdev+0x80/0x90
  [<ffffffff80285919>] printk+0x67/0x69
  [<ffffffff8041f2c2>] kick_rdev_from_array+0x19/0x27
  [<ffffffff8042126c>] do_md_run+0x11c/0x7b8
  [<ffffffff8041fc35>] bind_rdev_to_array+0x1f5/0x210
  [<ffffffff8041fe6b>] mddev_find+0x82/0x1dd
  [<ffffffff8042012f>] md_probe+0x169/0x17a
  [<ffffffff80421bf4>] autorun_devices+0x2ec/0x379
  [<ffffffff8033b5da>] selinux_capable+0x24/0x29
  [<ffffffff804247c5>] md_ioctl+0x135/0x154f
  [<ffffffff8033ace3>] avc_has_perm+0x49/0x5b
  [<ffffffff80350c72>] blkdev_driver_ioctl+0x62/0x80
  [<ffffffff80351386>] blkdev_ioctl+0x6f6/0x75a
  [<ffffffff8023f584>] wake_up_inode+0x18/0x24
  [<ffffffff8033b463>] inode_has_perm+0x62/0x71
  [<ffffffff802c0982>] blkdev_open+0x0/0x61
  [<ffffffff802c09ae>] blkdev_open+0x2c/0x61
  [<ffffffff8033b51c>] file_has_perm+0xaa/0xb9
  [<ffffffff802bfa32>] block_ioctl+0x1b/0x1f
  [<ffffffff8024328a>] do_ioctl+0x2a/0x8f
  [<ffffffff802316eb>] vfs_ioctl+0x27b/0x2a0
  [<ffffffff8024e7ca>] sys_ioctl+0x5f/0x82
  [<ffffffff8022f97d>] sys_fcntl+0x33d/0x34f
  [<ffffffff8025ff7a>] system_call+0x7e/0x83

BUG: warning at fs/block_dev.c:1128/__blkdev_put()

Call Trace:
  [<ffffffff80357be8>] kobject_put+0x19/0x21
  [<ffffffff802c0194>] __blkdev_put+0x17e/0x1bb
  [<ffffffff802c01df>] blkdev_put_partition+0xe/0x10
  [<ffffffff8041f174>] unlock_rdev+0x49/0x50
  [<ffffffff8041f1fb>] export_rdev+0x80/0x90
  [<ffffffff80285919>] printk+0x67/0x69
  [<ffffffff8041f2c2>] kick_rdev_from_array+0x19/0x27
  [<ffffffff8042126c>] do_md_run+0x11c/0x7b8
  [<ffffffff8041fc35>] bind_rdev_to_array+0x1f5/0x210
  [<ffffffff8041fe6b>] mddev_find+0x82/0x1dd
  [<ffffffff8042012f>] md_probe+0x169/0x17a
  [<ffffffff80421bf4>] autorun_devices+0x2ec/0x379
  [<ffffffff8033b5da>] selinux_capable+0x24/0x29
  [<ffffffff804247c5>] md_ioctl+0x135/0x154f
  [<ffffffff8033ace3>] avc_has_perm+0x49/0x5b
  [<ffffffff80350c72>] blkdev_driver_ioctl+0x62/0x80
  [<ffffffff80351386>] blkdev_ioctl+0x6f6/0x75a
  [<ffffffff8023f584>] wake_up_inode+0x18/0x24
  [<ffffffff8033b463>] inode_has_perm+0x62/0x71
  [<ffffffff802c0982>] blkdev_open+0x0/0x61
  [<ffffffff802c09ae>] blkdev_open+0x2c/0x61
  [<ffffffff8033b51c>] file_has_perm+0xaa/0xb9
  [<ffffffff802bfa32>] block_ioctl+0x1b/0x1f
  [<ffffffff8024328a>] do_ioctl+0x2a/0x8f
  [<ffffffff802316eb>] vfs_ioctl+0x27b/0x2a0
  [<ffffffff8024e7ca>] sys_ioctl+0x5f/0x82
  [<ffffffff8022f97d>] sys_fcntl+0x33d/0x34f
  [<ffffffff8025ff7a>] system_call+0x7e/0x83

raid1: raid set md3 active with 1 out of 2 mirrors
md3: bitmap initialized from disk: read 1/1 pages, set 1 bits, status: 0
created bitmap (13 pages) for device md3
md: considering sdc5 ...
md:  adding sdc5 ...
md: sdc3 has different UUID to sdc5
md: sdc2 has different UUID to sdc5
md:  adding sda5 ...
md: sda3 has different UUID to sdc5
md: sda2 has different UUID to sdc5
md: created md2
md: bind<sda5>
md: bind<sdc5>
md: running: <sdc5><sda5>
md: kicking non-fresh sda5 from array!
md: unbind<sda5>
md: export_rdev(sda5)
BUG: warning at fs/block_dev.c:1109/__blkdev_put()

Call Trace:
  [<ffffffff802c00b2>] __blkdev_put+0x9c/0x1bb
  [<ffffffff802c01df>] blkdev_put_partition+0xe/0x10
  [<ffffffff8041f174>] unlock_rdev+0x49/0x50
  [<ffffffff8041f1fb>] export_rdev+0x80/0x90
  [<ffffffff80285919>] printk+0x67/0x69
  [<ffffffff8041f2c2>] kick_rdev_from_array+0x19/0x27
  [<ffffffff8042126c>] do_md_run+0x11c/0x7b8
  [<ffffffff8041fc35>] bind_rdev_to_array+0x1f5/0x210
  [<ffffffff8041fe6b>] mddev_find+0x82/0x1dd
  [<ffffffff8042012f>] md_probe+0x169/0x17a
  [<ffffffff80421bf4>] autorun_devices+0x2ec/0x379
  [<ffffffff8033b5da>] selinux_capable+0x24/0x29
  [<ffffffff804247c5>] md_ioctl+0x135/0x154f
  [<ffffffff8033ace3>] avc_has_perm+0x49/0x5b
  [<ffffffff80350c72>] blkdev_driver_ioctl+0x62/0x80
  [<ffffffff80351386>] blkdev_ioctl+0x6f6/0x75a
  [<ffffffff8023f584>] wake_up_inode+0x18/0x24
  [<ffffffff8033b463>] inode_has_perm+0x62/0x71
  [<ffffffff802c0982>] blkdev_open+0x0/0x61
  [<ffffffff802c09ae>] blkdev_open+0x2c/0x61
  [<ffffffff8033b51c>] file_has_perm+0xaa/0xb9
  [<ffffffff802bfa32>] block_ioctl+0x1b/0x1f
  [<ffffffff8024328a>] do_ioctl+0x2a/0x8f
  [<ffffffff802316eb>] vfs_ioctl+0x27b/0x2a0
  [<ffffffff8024e7ca>] sys_ioctl+0x5f/0x82
  [<ffffffff8022f97d>] sys_fcntl+0x33d/0x34f
  [<ffffffff8025ff7a>] system_call+0x7e/0x83

BUG: warning at fs/block_dev.c:1128/__blkdev_put()

Call Trace:
  [<ffffffff80357be8>] kobject_put+0x19/0x21
  [<ffffffff802c0194>] __blkdev_put+0x17e/0x1bb
  [<ffffffff802c01df>] blkdev_put_partition+0xe/0x10
  [<ffffffff8041f174>] unlock_rdev+0x49/0x50
  [<ffffffff8041f1fb>] export_rdev+0x80/0x90
  [<ffffffff80285919>] printk+0x67/0x69
  [<ffffffff8041f2c2>] kick_rdev_from_array+0x19/0x27
  [<ffffffff8042126c>] do_md_run+0x11c/0x7b8
  [<ffffffff8041fc35>] bind_rdev_to_array+0x1f5/0x210
  [<ffffffff8041fe6b>] mddev_find+0x82/0x1dd
  [<ffffffff8042012f>] md_probe+0x169/0x17a
  [<ffffffff80421bf4>] autorun_devices+0x2ec/0x379
  [<ffffffff8033b5da>] selinux_capable+0x24/0x29
  [<ffffffff804247c5>] md_ioctl+0x135/0x154f
  [<ffffffff8033ace3>] avc_has_perm+0x49/0x5b
  [<ffffffff80350c72>] blkdev_driver_ioctl+0x62/0x80
  [<ffffffff80351386>] blkdev_ioctl+0x6f6/0x75a
  [<ffffffff8023f584>] wake_up_inode+0x18/0x24
  [<ffffffff8033b463>] inode_has_perm+0x62/0x71
  [<ffffffff802c0982>] blkdev_open+0x0/0x61
  [<ffffffff802c09ae>] blkdev_open+0x2c/0x61
  [<ffffffff8033b51c>] file_has_perm+0xaa/0xb9
  [<ffffffff802bfa32>] block_ioctl+0x1b/0x1f
  [<ffffffff8024328a>] do_ioctl+0x2a/0x8f
  [<ffffffff802316eb>] vfs_ioctl+0x27b/0x2a0
  [<ffffffff8024e7ca>] sys_ioctl+0x5f/0x82
  [<ffffffff8022f97d>] sys_fcntl+0x33d/0x34f
  [<ffffffff8025ff7a>] system_call+0x7e/0x83

raid1: raid set md2 active with 1 out of 2 mirrors
md2: bitmap initialized from disk: read 10/10 pages, set 4842 bits, status: 0
created bitmap (150 pages) for device md2
md: considering sdc3 ...
md:  adding sdc3 ...
md: sdc2 has different UUID to sdc3
md:  adding sda3 ...
md: sda2 has different UUID to sdc3
md: created md1
md: bind<sda3>
md: bind<sdc3>
md: running: <sdc3><sda3>
md: kicking non-fresh sda3 from array!
md: unbind<sda3>
md: export_rdev(sda3)
BUG: warning at fs/block_dev.c:1109/__blkdev_put()

Call Trace:
  [<ffffffff802c00b2>] __blkdev_put+0x9c/0x1bb
  [<ffffffff802c01df>] blkdev_put_partition+0xe/0x10
  [<ffffffff8041f174>] unlock_rdev+0x49/0x50
  [<ffffffff8041f1fb>] export_rdev+0x80/0x90
  [<ffffffff80285919>] printk+0x67/0x69
  [<ffffffff8041f2c2>] kick_rdev_from_array+0x19/0x27
  [<ffffffff8042126c>] do_md_run+0x11c/0x7b8
  [<ffffffff8041fc35>] bind_rdev_to_array+0x1f5/0x210
  [<ffffffff8041fe6b>] mddev_find+0x82/0x1dd
  [<ffffffff8042012f>] md_probe+0x169/0x17a
  [<ffffffff80421bf4>] autorun_devices+0x2ec/0x379
  [<ffffffff8033b5da>] selinux_capable+0x24/0x29
  [<ffffffff804247c5>] md_ioctl+0x135/0x154f
  [<ffffffff8033ace3>] avc_has_perm+0x49/0x5b
  [<ffffffff80350c72>] blkdev_driver_ioctl+0x62/0x80
  [<ffffffff80351386>] blkdev_ioctl+0x6f6/0x75a
  [<ffffffff8023f584>] wake_up_inode+0x18/0x24
  [<ffffffff8033b463>] inode_has_perm+0x62/0x71
  [<ffffffff802c0982>] blkdev_open+0x0/0x61
  [<ffffffff802c09ae>] blkdev_open+0x2c/0x61
  [<ffffffff8033b51c>] file_has_perm+0xaa/0xb9
  [<ffffffff802bfa32>] block_ioctl+0x1b/0x1f
  [<ffffffff8024328a>] do_ioctl+0x2a/0x8f
  [<ffffffff802316eb>] vfs_ioctl+0x27b/0x2a0
  [<ffffffff8024e7ca>] sys_ioctl+0x5f/0x82
  [<ffffffff8022f97d>] sys_fcntl+0x33d/0x34f
  [<ffffffff8025ff7a>] system_call+0x7e/0x83

BUG: warning at fs/block_dev.c:1128/__blkdev_put()

Call Trace:
  [<ffffffff80357be8>] kobject_put+0x19/0x21
  [<ffffffff802c0194>] __blkdev_put+0x17e/0x1bb
  [<ffffffff802c01df>] blkdev_put_partition+0xe/0x10
  [<ffffffff8041f174>] unlock_rdev+0x49/0x50
  [<ffffffff8041f1fb>] export_rdev+0x80/0x90
  [<ffffffff80285919>] printk+0x67/0x69
  [<ffffffff8041f2c2>] kick_rdev_from_array+0x19/0x27
  [<ffffffff8042126c>] do_md_run+0x11c/0x7b8
  [<ffffffff8041fc35>] bind_rdev_to_array+0x1f5/0x210
  [<ffffffff8041fe6b>] mddev_find+0x82/0x1dd
  [<ffffffff8042012f>] md_probe+0x169/0x17a
  [<ffffffff80421bf4>] autorun_devices+0x2ec/0x379
  [<ffffffff8033b5da>] selinux_capable+0x24/0x29
  [<ffffffff804247c5>] md_ioctl+0x135/0x154f
  [<ffffffff8033ace3>] avc_has_perm+0x49/0x5b
  [<ffffffff80350c72>] blkdev_driver_ioctl+0x62/0x80
  [<ffffffff80351386>] blkdev_ioctl+0x6f6/0x75a
  [<ffffffff8023f584>] wake_up_inode+0x18/0x24
  [<ffffffff8033b463>] inode_has_perm+0x62/0x71
  [<ffffffff802c0982>] blkdev_open+0x0/0x61
  [<ffffffff802c09ae>] blkdev_open+0x2c/0x61
  [<ffffffff8033b51c>] file_has_perm+0xaa/0xb9
  [<ffffffff802bfa32>] block_ioctl+0x1b/0x1f
  [<ffffffff8024328a>] do_ioctl+0x2a/0x8f
  [<ffffffff802316eb>] vfs_ioctl+0x27b/0x2a0
  [<ffffffff8024e7ca>] sys_ioctl+0x5f/0x82
  [<ffffffff8022f97d>] sys_fcntl+0x33d/0x34f
  [<ffffffff8025ff7a>] system_call+0x7e/0x83

raid1: raid set md1 active with 1 out of 2 mirrors
md1: bitmap initialized from disk: read 10/10 pages, set 1393 bits, status: 0
created bitmap (150 pages) for device md1
md: considering sdc2 ...
md:  adding sdc2 ...
md:  adding sda2 ...
md: created md0
md: bind<sda2>
md: bind<sdc2>
md: running: <sdc2><sda2>
md: kicking non-fresh sdc2 from array!
md: unbind<sdc2>
md: export_rdev(sdc2)
BUG: warning at fs/block_dev.c:1109/__blkdev_put()

Call Trace:
  [<ffffffff802c00b2>] __blkdev_put+0x9c/0x1bb
  [<ffffffff802c01df>] blkdev_put_partition+0xe/0x10
  [<ffffffff8041f174>] unlock_rdev+0x49/0x50
  [<ffffffff8041f1fb>] export_rdev+0x80/0x90
  [<ffffffff80285919>] printk+0x67/0x69
  [<ffffffff8041f2c2>] kick_rdev_from_array+0x19/0x27
  [<ffffffff8042126c>] do_md_run+0x11c/0x7b8
  [<ffffffff8041fc35>] bind_rdev_to_array+0x1f5/0x210
  [<ffffffff8041fe6b>] mddev_find+0x82/0x1dd
  [<ffffffff80420043>] md_probe+0x7d/0x17a
  [<ffffffff80421bf4>] autorun_devices+0x2ec/0x379
  [<ffffffff8033b5da>] selinux_capable+0x24/0x29
  [<ffffffff804247c5>] md_ioctl+0x135/0x154f
  [<ffffffff8033ace3>] avc_has_perm+0x49/0x5b
  [<ffffffff80350c72>] blkdev_driver_ioctl+0x62/0x80
  [<ffffffff80351386>] blkdev_ioctl+0x6f6/0x75a
  [<ffffffff8023f584>] wake_up_inode+0x18/0x24
  [<ffffffff8033b463>] inode_has_perm+0x62/0x71
  [<ffffffff802c0982>] blkdev_open+0x0/0x61
  [<ffffffff802c09ae>] blkdev_open+0x2c/0x61
  [<ffffffff8033b51c>] file_has_perm+0xaa/0xb9
  [<ffffffff802bfa32>] block_ioctl+0x1b/0x1f
  [<ffffffff8024328a>] do_ioctl+0x2a/0x8f
  [<ffffffff802316eb>] vfs_ioctl+0x27b/0x2a0
  [<ffffffff8024e7ca>] sys_ioctl+0x5f/0x82
  [<ffffffff8022f97d>] sys_fcntl+0x33d/0x34f
  [<ffffffff8025ff7a>] system_call+0x7e/0x83

BUG: warning at fs/block_dev.c:1128/__blkdev_put()

Call Trace:
  [<ffffffff80357be8>] kobject_put+0x19/0x21
  [<ffffffff802c0194>] __blkdev_put+0x17e/0x1bb
  [<ffffffff802c01df>] blkdev_put_partition+0xe/0x10
  [<ffffffff8041f174>] unlock_rdev+0x49/0x50
  [<ffffffff8041f1fb>] export_rdev+0x80/0x90
  [<ffffffff80285919>] printk+0x67/0x69
  [<ffffffff8041f2c2>] kick_rdev_from_array+0x19/0x27
  [<ffffffff8042126c>] do_md_run+0x11c/0x7b8
  [<ffffffff8041fc35>] bind_rdev_to_array+0x1f5/0x210
  [<ffffffff8041fe6b>] mddev_find+0x82/0x1dd
  [<ffffffff80420043>] md_probe+0x7d/0x17a
  [<ffffffff80421bf4>] autorun_devices+0x2ec/0x379
  [<ffffffff8033b5da>] selinux_capable+0x24/0x29
  [<ffffffff804247c5>] md_ioctl+0x135/0x154f
  [<ffffffff8033ace3>] avc_has_perm+0x49/0x5b
  [<ffffffff80350c72>] blkdev_driver_ioctl+0x62/0x80
  [<ffffffff80351386>] blkdev_ioctl+0x6f6/0x75a
  [<ffffffff8023f584>] wake_up_inode+0x18/0x24
  [<ffffffff8033b463>] inode_has_perm+0x62/0x71
  [<ffffffff802c0982>] blkdev_open+0x0/0x61
  [<ffffffff802c09ae>] blkdev_open+0x2c/0x61
  [<ffffffff8033b51c>] file_has_perm+0xaa/0xb9
  [<ffffffff802bfa32>] block_ioctl+0x1b/0x1f
  [<ffffffff8024328a>] do_ioctl+0x2a/0x8f
  [<ffffffff802316eb>] vfs_ioctl+0x27b/0x2a0
  [<ffffffff8024e7ca>] sys_ioctl+0x5f/0x82
  [<ffffffff8022f97d>] sys_fcntl+0x33d/0x34f
  [<ffffffff8025ff7a>] system_call+0x7e/0x83

raid1: raid set md0 active with 1 out of 2 mirrors
md0: bitmap initialized from disk: read 12/12 pages, set 867 bits, status: 0
created bitmap (187 pages) for device md0
md: ... autorun DONE.
Creating root device.
Mounting root filesystem.
kjournald starting.  Commit interval 5 seconds
EXT3-fs: mounted filesystem with ordered data mode.
Setting up other filesystems.
Setting up new root fs
no fstab.sys, mounting internal defaults
Switching to new root and running init.
unmounting old /dev
unmounting old /proc
unmounting old /proc/bus/usb
ERROR unmounting old /proc/bus/usb: No such file or directory
forcing unmount of /proc/bus/usb
unmounting old /sys
SELinux:  Disabled at runtime.
SELinux:  Unregistering netfilter hooks
audit(1151406506.484:2): selinux=0 auid=4294967295
INIT: version 2.86 booting

Which results in this:

[root@tornado ~]# cat /proc/mdstat
Personalities : [raid1]
md1 : active raid1 sdc3[1]
       4891712 blocks [2/1] [_U]
       bitmap: 31/150 pages [124KB], 16KB chunk

md2 : active raid1 sdc5[1]
       4891648 blocks [2/1] [_U]
       bitmap: 45/150 pages [180KB], 16KB chunk

md3 : active raid1 sdc6[1]
       104320 blocks [2/1] [_U]
       bitmap: 1/13 pages [4KB], 4KB chunk

md4 : active raid1 sdc7[1]
       497856 blocks [2/1] [_U]
       bitmap: 18/61 pages [72KB], 4KB chunk

md6 : active raid1 sdc10[1] sda10[0]
       20008832 blocks [2/2] [UU]

md5 : active raid1 sdc11[1] sda11[2](F)
       20008832 blocks [2/1] [_U]

md0 : active raid1 sda2[0]
       24410688 blocks [2/1] [U_]
       bitmap: 54/187 pages [216KB], 64KB chunk

unused devices: <none>
[root@tornado ~]#

cc'ing NeilB in this.......

The arrays were ok before booting into -mm3.

-mm3 is still unusable, mail is still jamming up in the queue, but I'll mention 
that in another post.

Reuben

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: 2.6.17-mm3
  2006-06-27  8:52 2.6.17-mm3 Andrew Morton
                   ` (3 preceding siblings ...)
  2006-06-27 11:17 ` 2.6.17-mm3 Reuben Farrelly
@ 2006-06-27 11:48 ` Reuben Farrelly
  2006-06-27 14:12 ` 2.6.17-mm3 Michal Piotrowski
                   ` (8 subsequent siblings)
  13 siblings, 0 replies; 42+ messages in thread
From: Reuben Farrelly @ 2006-06-27 11:48 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel



On 27/06/2006 8:52 p.m., Andrew Morton wrote:
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.17/2.6.17-mm3/
> 
> 
> - Added the x86 Geode development tree to the -mm lineup, as git-geode.patch
>   (Jordan Crouse).
> 
> - The locking validator patches are back, in a reworked series.

Still seeing the same breakage as I posted about here in -mm2:

http://www.ussg.iu.edu/hypermail/linux/kernel/0606.3/0195.html

I've since noticed that mail delivery is held up by the deliver process. 
'deliver' is a component of the dovecot mail system (http://www.dovecot.org/) 
which does delivery of mails to a user's Maildir and in the process recreates an 
index.

[root@tornado ~]# nice top
top - 23:05:13 up 47 min,  4 users,  load average: 6.48, 4.80, 4.10
Tasks: 170 total,   5 running, 165 sleeping,   0 stopped,   0 zombie
Cpu(s)%:  0.2 us, 98.9 sy,  0.0 ni,  0.6 id,  0.2 wa,  0.2 hi,  0.0 si,  0.0 st
Mem:   1016764k total,   847184k used,   169580k free,    56840k buffers
Swap:   497936k total,        0k used,   497936k free,   267064k cached

   PID USER      PR  NI  VIRT  RES  SHR S %CPU %MEM    TIME+  COMMAND
  2231 reuben    25   0  7984 1392 1136 R   55  0.1  23:20.16 deliver
  2591 reuben    25   0  7988 1392 1136 R   53  0.1  22:41.52 deliver
  2232 reuben    25   0  7988 1392 1136 R   50  0.1  23:23.78 deliver
  2586 reuben    25   0  7984 1392 1136 R   49  0.1  22:28.72 deliver


[root@tornado ~]# strace -p 2232
Process 2232 attached - interrupt to quit

I can't kill these processes with a KILL signal, nor can I strace them.

Revert to -mm1 or any previous kernel release, and it all works fine.  That 
leads me to believe this is probably not a userspace issue.

What patches which could have possibly caused this?

Reuben

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: 2.6.17-mm3: no help text for READAHEAD_ALLOW_OVERHEADS
       [not found]   ` <20060627134337.GA6117@mail.ustc.edu.cn>
@ 2006-06-27 13:43     ` Wu Fengguang
  2006-06-27 14:40     ` Adrian Bunk
  1 sibling, 0 replies; 42+ messages in thread
From: Wu Fengguang @ 2006-06-27 13:43 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: Andrew Morton, linux-kernel

On Tue, Jun 27, 2006 at 11:14:29AM +0200, Adrian Bunk wrote:
> On Tue, Jun 27, 2006 at 01:52:11AM -0700, Andrew Morton wrote:
> >...
> > Changes since 2.6.17-mm2:
> > +readahead-kconfig-option-readahead_allow_overheads.patch
> >...
> >  readahead updates
> >...
> 
> The READAHEAD_ALLOW_OVERHEADS option lacks a help text.

Oh, it just acts as a submenu and a reminder ;)

> Additionally, the "default n" is pointless and should be removed.

I expect the _extra_ features are useless for normal users.
Your reasoning or feeling?

PS.
I'll be on a trip and remain silence for about a week, sorry.

Wu

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: 2.6.17-mm3
  2006-06-27  8:52 2.6.17-mm3 Andrew Morton
                   ` (4 preceding siblings ...)
  2006-06-27 11:48 ` 2.6.17-mm3 Reuben Farrelly
@ 2006-06-27 14:12 ` Michal Piotrowski
  2006-06-27 21:38 ` 2.6.17-mm3 Steve Fox
                   ` (7 subsequent siblings)
  13 siblings, 0 replies; 42+ messages in thread
From: Michal Piotrowski @ 2006-06-27 14:12 UTC (permalink / raw)
  To: Andrew Morton
  Cc: Stephen Hemminger, Ingo Molnar, Arjan van de Ven, linux-kernel,
	netdev

Hi,

On 27/06/06, Andrew Morton <akpm@osdl.org> wrote:
>
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.17/2.6.17-mm3/
>
>

It looks like a skge bug

=========================================================
[ INFO: possible irq lock inversion dependency detected ]
---------------------------------------------------------
swapper/0 just changed the state of lock:
 (tasklist_lock){..-?}, at: [<c0128092>] send_group_sig_info+0x16/0x34
but this lock took another, soft-irq-unsafe lock in the past:
  (&sig->stats_lock){--..}

and interrupts could create inverse lock ordering between them.


other info that might help us debug this:
no locks held by swapper/0.

the first lock's dependencies:
-> (tasklist_lock){..-?} ops: 13763 {
   initial-use  at:
                        [<c01353ab>] lock_acquire+0x60/0x80
                        [<c02d0ce2>] _write_lock_irq+0x29/0x38
                        [<c011c4e3>] copy_process+0xea7/0x13c0
                        [<c011cc6a>] do_fork+0x8d/0x18f
                        [<c010136c>] kernel_thread+0x6c/0x74
                        [<c0100518>] rest_init+0x14/0x3c
                        [<c03b6769>] start_kernel+0x388/0x390
                        [<c0100210>] 0xc0100210
   in-softirq-R at:
[..]

Here is a dmesg log http://www.stardust.webpages.pl/files/mm/2.6.17-mm3/mm-dmesg

Here is a config file
http://www.stardust.webpages.pl/files/mm/2.6.17-mm3/mm-config

Regards,
Michal

-- 
Michal K. K. Piotrowski
LTG - Linux Testers Group
(http://www.stardust.webpages.pl/ltg/wiki/)

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: 2.6.17-mm3: no help text for READAHEAD_ALLOW_OVERHEADS
       [not found]   ` <20060627134337.GA6117@mail.ustc.edu.cn>
  2006-06-27 13:43     ` Wu Fengguang
@ 2006-06-27 14:40     ` Adrian Bunk
       [not found]       ` <20060627155227.GA6014@mail.ustc.edu.cn>
  2006-06-27 17:46       ` Randy.Dunlap
  1 sibling, 2 replies; 42+ messages in thread
From: Adrian Bunk @ 2006-06-27 14:40 UTC (permalink / raw)
  To: Wu Fengguang, Andrew Morton, linux-kernel

On Tue, Jun 27, 2006 at 09:43:37PM +0800, Wu Fengguang wrote:
> On Tue, Jun 27, 2006 at 11:14:29AM +0200, Adrian Bunk wrote:
> > On Tue, Jun 27, 2006 at 01:52:11AM -0700, Andrew Morton wrote:
> > >...
> > > Changes since 2.6.17-mm2:
> > > +readahead-kconfig-option-readahead_allow_overheads.patch
> > >...
> > >  readahead updates
> > >...
> > 
> > The READAHEAD_ALLOW_OVERHEADS option lacks a help text.
> 
> Oh, it just acts as a submenu and a reminder ;)
> 
> > Additionally, the "default n" is pointless and should be removed.
> 
> I expect the _extra_ features are useless for normal users.
> Your reasoning or feeling?
>...

That's not my point, my point is that if you remove the "default n" 
line, nothing changes. The default is still "n", but it's better 
readable.

> Wu

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: 2.6.17-mm3: no help text for READAHEAD_ALLOW_OVERHEADS
       [not found]       ` <20060627155227.GA6014@mail.ustc.edu.cn>
@ 2006-06-27 15:52         ` Wu Fengguang
  0 siblings, 0 replies; 42+ messages in thread
From: Wu Fengguang @ 2006-06-27 15:52 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: Andrew Morton, linux-kernel

On Tue, Jun 27, 2006 at 04:40:19PM +0200, Adrian Bunk wrote:
> On Tue, Jun 27, 2006 at 09:43:37PM +0800, Wu Fengguang wrote:
> > On Tue, Jun 27, 2006 at 11:14:29AM +0200, Adrian Bunk wrote:
> > > On Tue, Jun 27, 2006 at 01:52:11AM -0700, Andrew Morton wrote:
> > > >...
> > > > Changes since 2.6.17-mm2:
> > > > +readahead-kconfig-option-readahead_allow_overheads.patch
> > > >...
> > > >  readahead updates
> > > >...
> > > 
> > > The READAHEAD_ALLOW_OVERHEADS option lacks a help text.
> > 
> > Oh, it just acts as a submenu and a reminder ;)
> > 
> > > Additionally, the "default n" is pointless and should be removed.
> > 
> > I expect the _extra_ features are useless for normal users.
> > Your reasoning or feeling?
> >...
> 
> That's not my point, my point is that if you remove the "default n" 
> line, nothing changes. The default is still "n", but it's better 
> readable.

Sorry, I didn't know that. Thanks.

Wu

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: 2.6.17-mm3: no help text for READAHEAD_ALLOW_OVERHEADS
  2006-06-27 14:40     ` Adrian Bunk
       [not found]       ` <20060627155227.GA6014@mail.ustc.edu.cn>
@ 2006-06-27 17:46       ` Randy.Dunlap
  2006-06-27 17:55         ` Adrian Bunk
  1 sibling, 1 reply; 42+ messages in thread
From: Randy.Dunlap @ 2006-06-27 17:46 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: wfg, akpm, linux-kernel

On Tue, 27 Jun 2006 16:40:19 +0200 Adrian Bunk wrote:

> On Tue, Jun 27, 2006 at 09:43:37PM +0800, Wu Fengguang wrote:
> > On Tue, Jun 27, 2006 at 11:14:29AM +0200, Adrian Bunk wrote:
> > > On Tue, Jun 27, 2006 at 01:52:11AM -0700, Andrew Morton wrote:
> > > >...
> > > > Changes since 2.6.17-mm2:
> > > > +readahead-kconfig-option-readahead_allow_overheads.patch
> > > >...
> > > >  readahead updates
> > > >...
> > > 
> > > The READAHEAD_ALLOW_OVERHEADS option lacks a help text.
> > 
> > Oh, it just acts as a submenu and a reminder ;)
> > 
> > > Additionally, the "default n" is pointless and should be removed.
> > 
> > I expect the _extra_ features are useless for normal users.
> > Your reasoning or feeling?
> >...
> 
> That's not my point, my point is that if you remove the "default n" 
> line, nothing changes. The default is still "n", but it's better 
> readable.

Why is it more readable without the "default n" line?
One could say that supplying the default "default n" line is clearer
than having it omitted.

---
~Randy

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: 2.6.17-mm3: no help text for READAHEAD_ALLOW_OVERHEADS
  2006-06-27 17:46       ` Randy.Dunlap
@ 2006-06-27 17:55         ` Adrian Bunk
  0 siblings, 0 replies; 42+ messages in thread
From: Adrian Bunk @ 2006-06-27 17:55 UTC (permalink / raw)
  To: Randy.Dunlap; +Cc: wfg, akpm, linux-kernel

On Tue, Jun 27, 2006 at 10:46:49AM -0700, Randy.Dunlap wrote:
> On Tue, 27 Jun 2006 16:40:19 +0200 Adrian Bunk wrote:
> 
> > On Tue, Jun 27, 2006 at 09:43:37PM +0800, Wu Fengguang wrote: ...
> > > > Additionally, the "default n" is pointless and should be removed.
> > > 
> > > I expect the _extra_ features are useless for normal users.
> > > Your reasoning or feeling?
> > >...
> > 
> > That's not my point, my point is that if you remove the "default n" 
> > line, nothing changes. The default is still "n", but it's better 
> > readable.
> 
> Why is it more readable without the "default n" line?
> One could say that supplying the default "default n" line is clearer
> than having it omitted.

The majority of options defaults to "n".

It's easier to spot a non-"n" default if this means an additional line 
instead of only one changed letter.

> ~Randy

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: 2.6.17-mm3
  2006-06-27  8:52 2.6.17-mm3 Andrew Morton
                   ` (5 preceding siblings ...)
  2006-06-27 14:12 ` 2.6.17-mm3 Michal Piotrowski
@ 2006-06-27 21:38 ` Steve Fox
  2006-06-27 23:12   ` 2.6.17-mm3 Martin Bligh
  2006-06-27 22:40 ` 2.6.17-mm3: arm: *_irq_wake compile error Adrian Bunk
                   ` (6 subsequent siblings)
  13 siblings, 1 reply; 42+ messages in thread
From: Steve Fox @ 2006-06-27 21:38 UTC (permalink / raw)
  To: linux-kernel

On Tue, 27 Jun 2006 01:52:11 -0700, Andrew Morton wrote:

> 
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.17/2.6.17-mm3/

Got this oops on a ppc64 box while running the reaim test. There were lots
of fs/mount issues during boot, so if anyone thinks that is the problem,
then we can try to fix that up first.

 Oops: Kernel access of bad area, sig: 11 [#1]
SMP NR_CPUS=32 NUMA 
Modules linked in:
NIP: C0000000000A311C LR: C0000000000A30D4 CTR: C0000000000A3024
REGS: c0000007725b38d0 TRAP: 0300   Not tainted  (2.6.17-mm3-autokern1)
MSR: 8000000000001032 <ME,IR,DR>  CR: 28224424  XER: 00000000
DAR: 000000077BCC6180, DSISR: 0000000040000000
TASK = c00000002fc74670[29812] 'cp' THREAD: c0000007725b0000 CPU: 2
GPR00: 0000000000000000 C0000007725B3B50 C00000000063B828 C00000001E303EC0 
GPR04: 0000000000000010 0000000000000000 0000000000000000 FFFFFFFFFFFFFFFD 
GPR08: 0000000000000001 0000000000000000 000000077BCC6180 0000000000000000 
GPR12: 0000000000000000 C00000000051FF80 0000000000000000 0000000000000001 
GPR16: 0000000000000000 0000000000000004 0000000000020000 0000000000000000 
GPR20: 0000000000000000 0000000000000000 C0000007759F9D00 0000000000000000 
GPR24: 0000000000000E42 0000000000000000 000000000000474A C00000001E30F300 
GPR28: 0000000000000000 0000000000000000 C000000000537288 C00000001E303E80 
NIP [C0000000000A311C] .s_show+0xf8/0x364
LR [C0000000000A30D4] .s_show+0xb0/0x364
Call Trace:
[C0000007725B3B50] [C0000000000A3334] .s_show+0x310/0x364 (unreliable)
[C0000007725B3C20] [C0000000000D5E84] .seq_read+0x2f4/0x450
[C0000007725B3D00] [C0000000000AADF8] .vfs_read+0xe0/0x1b4
[C0000007725B3D90] [C0000000000AAFD4] .sys_read+0x54/0x98
[C0000007725B3E30] [C00000000000871C] syscall_exit+0x0/0x40
Instruction dump:
3b180001 7c004a78 79290020 7c0bfe70 7f5a4a14 7d600278 7c005850 54000ffe 
7c094038 2c090000 41820008 ebbe80b0 <e96a0000> 2fab0000 419e0008 7c005a2c 

-- 

Steve Fox
IBM Linux Technology Center



^ permalink raw reply	[flat|nested] 42+ messages in thread

* 2.6.17-mm3: arm: *_irq_wake compile error
  2006-06-27  8:52 2.6.17-mm3 Andrew Morton
                   ` (6 preceding siblings ...)
  2006-06-27 21:38 ` 2.6.17-mm3 Steve Fox
@ 2006-06-27 22:40 ` Adrian Bunk
  2006-06-28  7:09   ` Thomas Gleixner
  2006-06-28 12:03 ` 2.6.17-mm3 - mutex warning in usbhid, battery problem, and slab corruption Rafael J. Wysocki
                   ` (5 subsequent siblings)
  13 siblings, 1 reply; 42+ messages in thread
From: Adrian Bunk @ 2006-06-27 22:40 UTC (permalink / raw)
  To: Andrew Morton, Thomas Gleixner; +Cc: linux-kernel, Ingo Molnar, rmk

genirq-add-irq-wake-power-management-support.patch causes the following 
compile error on arm:

<--  snip  -->

...
  CC      init/main.o
In file included from include/linux/rtc.h:102,
                 from include/linux/efi.h:19,
                 from init/main.c:47:
include/linux/interrupt.h:108: error: conflicting types for 'enable_irq_wake'
include/asm/irq.h:47: error: previous declaration of 'enable_irq_wake' was here
include/linux/interrupt.h:113: error: conflicting types for 'disable_irq_wake'
include/asm/irq.h:46: error: previous declaration of 'disable_irq_wake' was here
make[1]: *** [init/main.o] Error 1

<--  snip  -->

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed



^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: 2.6.17-mm3
  2006-06-27 21:38 ` 2.6.17-mm3 Steve Fox
@ 2006-06-27 23:12   ` Martin Bligh
  0 siblings, 0 replies; 42+ messages in thread
From: Martin Bligh @ 2006-06-27 23:12 UTC (permalink / raw)
  To: Steve Fox; +Cc: linux-kernel

Steve Fox wrote:
> On Tue, 27 Jun 2006 01:52:11 -0700, Andrew Morton wrote:
> 
> 
>>ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.17/2.6.17-mm3/
> 
> 
> Got this oops on a ppc64 box while running the reaim test. There were lots
> of fs/mount issues during boot, so if anyone thinks that is the problem,
> then we can try to fix that up first.

Nope, is not that. It's happening across several boxes.

It started in either -git9 or -git10 ... can't tell for sure, as -git9
didn't compile. I thought it was intermittent, but it seems pretty
persistently broken since then.

>  Oops: Kernel access of bad area, sig: 11 [#1]
> SMP NR_CPUS=32 NUMA 
> Modules linked in:
> NIP: C0000000000A311C LR: C0000000000A30D4 CTR: C0000000000A3024
> REGS: c0000007725b38d0 TRAP: 0300   Not tainted  (2.6.17-mm3-autokern1)
> MSR: 8000000000001032 <ME,IR,DR>  CR: 28224424  XER: 00000000
> DAR: 000000077BCC6180, DSISR: 0000000040000000
> TASK = c00000002fc74670[29812] 'cp' THREAD: c0000007725b0000 CPU: 2
> GPR00: 0000000000000000 C0000007725B3B50 C00000000063B828 C00000001E303EC0 
> GPR04: 0000000000000010 0000000000000000 0000000000000000 FFFFFFFFFFFFFFFD 
> GPR08: 0000000000000001 0000000000000000 000000077BCC6180 0000000000000000 
> GPR12: 0000000000000000 C00000000051FF80 0000000000000000 0000000000000001 
> GPR16: 0000000000000000 0000000000000004 0000000000020000 0000000000000000 
> GPR20: 0000000000000000 0000000000000000 C0000007759F9D00 0000000000000000 
> GPR24: 0000000000000E42 0000000000000000 000000000000474A C00000001E30F300 
> GPR28: 0000000000000000 0000000000000000 C000000000537288 C00000001E303E80 
> NIP [C0000000000A311C] .s_show+0xf8/0x364
> LR [C0000000000A30D4] .s_show+0xb0/0x364
> Call Trace:
> [C0000007725B3B50] [C0000000000A3334] .s_show+0x310/0x364 (unreliable)
> [C0000007725B3C20] [C0000000000D5E84] .seq_read+0x2f4/0x450
> [C0000007725B3D00] [C0000000000AADF8] .vfs_read+0xe0/0x1b4
> [C0000007725B3D90] [C0000000000AAFD4] .sys_read+0x54/0x98
> [C0000007725B3E30] [C00000000000871C] syscall_exit+0x0/0x40
> Instruction dump:
> 3b180001 7c004a78 79290020 7c0bfe70 7f5a4a14 7d600278 7c005850 54000ffe 
> 7c094038 2c090000 41820008 ebbe80b0 <e96a0000> 2fab0000 419e0008 7c005a2c 


^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: 2.6.17-mm3: arm: *_irq_wake compile error
  2006-06-27 22:40 ` 2.6.17-mm3: arm: *_irq_wake compile error Adrian Bunk
@ 2006-06-28  7:09   ` Thomas Gleixner
  2006-06-28  7:12     ` Andrew Morton
  0 siblings, 1 reply; 42+ messages in thread
From: Thomas Gleixner @ 2006-06-28  7:09 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: Andrew Morton, linux-kernel, Ingo Molnar, rmk

On Wed, 2006-06-28 at 00:40 +0200, Adrian Bunk wrote:
> genirq-add-irq-wake-power-management-support.patch causes the following 
> compile error on arm:
> 
> <--  snip  -->
> 
> ...
>   CC      init/main.o
> In file included from include/linux/rtc.h:102,
>                  from include/linux/efi.h:19,
>                  from init/main.c:47:
> include/linux/interrupt.h:108: error: conflicting types for 'enable_irq_wake'
> include/asm/irq.h:47: error: previous declaration of 'enable_irq_wake' was here
> include/linux/interrupt.h:113: error: conflicting types for 'disable_irq_wake'
> include/asm/irq.h:46: error: previous declaration of 'disable_irq_wake' was here
> make[1]: *** [init/main.o] Error 1

Thats a mismerge with LOCKDEP

This section was originally inside #ifdef CONFIG_GENERIC_HARDIRQS

/* IRQ wakeup (PM) control: */
extern int set_irq_wake(unsigned int irq, unsigned int on);

static inline int enable_irq_wake(unsigned int irq)
{
        return set_irq_wake(irq, 1);
}

static inline int disable_irq_wake(unsigned int irq)
{
        return set_irq_wake(irq, 0);
}

The patch is:

lockdep-add-disable-enable_irq_lockdep-api.patch

	tglx



^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: 2.6.17-mm3: arm: *_irq_wake compile error
  2006-06-28  7:09   ` Thomas Gleixner
@ 2006-06-28  7:12     ` Andrew Morton
  2006-06-28  7:20       ` Thomas Gleixner
  0 siblings, 1 reply; 42+ messages in thread
From: Andrew Morton @ 2006-06-28  7:12 UTC (permalink / raw)
  To: tglx; +Cc: bunk, linux-kernel, mingo, rmk

On Wed, 28 Jun 2006 09:09:04 +0200
Thomas Gleixner <tglx@linutronix.de> wrote:

> On Wed, 2006-06-28 at 00:40 +0200, Adrian Bunk wrote:
> > genirq-add-irq-wake-power-management-support.patch causes the following 
> > compile error on arm:
> > 
> > <--  snip  -->
> > 
> > ...
> >   CC      init/main.o
> > In file included from include/linux/rtc.h:102,
> >                  from include/linux/efi.h:19,
> >                  from init/main.c:47:
> > include/linux/interrupt.h:108: error: conflicting types for 'enable_irq_wake'
> > include/asm/irq.h:47: error: previous declaration of 'enable_irq_wake' was here
> > include/linux/interrupt.h:113: error: conflicting types for 'disable_irq_wake'
> > include/asm/irq.h:46: error: previous declaration of 'disable_irq_wake' was here
> > make[1]: *** [init/main.o] Error 1
> 
> Thats a mismerge with LOCKDEP
> 
> This section was originally inside #ifdef CONFIG_GENERIC_HARDIRQS
> 
> /* IRQ wakeup (PM) control: */
> extern int set_irq_wake(unsigned int irq, unsigned int on);
> 
> static inline int enable_irq_wake(unsigned int irq)
> {
>         return set_irq_wake(irq, 1);
> }
> 
> static inline int disable_irq_wake(unsigned int irq)
> {
>         return set_irq_wake(irq, 0);
> }
> 
> The patch is:
> 
> lockdep-add-disable-enable_irq_lockdep-api.patch
> 

OK, so I moved the above lines inside #ifdef CONFIG_GENERIC_HARDIRQS (diff
did a strange-looking thing with it):

diff -puN include/linux/interrupt.h~lockdep-add-disable-enable_irq_lockdep-api-fix include/linux/interrupt.h
--- a/include/linux/interrupt.h~lockdep-add-disable-enable_irq_lockdep-api-fix
+++ a/include/linux/interrupt.h
@@ -71,17 +71,6 @@ static inline void enable_irq_lockdep(un
 #endif
 	enable_irq(irq);
 }
-#else /* !CONFIG_GENERIC_HARDIRQS */
-/*
- * NOTE: non-genirq architectures, if they want to support the lock
- * validator need to define the methods below in their asm/irq.h
- * files, under an #ifdef CONFIG_LOCKDEP section.
- */
-# ifndef CONFIG_LOCKDEP
-#  define disable_irq_nosync_lockdep(irq)	disable_irq_nosync(irq)
-#  define disable_irq_lockdep(irq)		disable_irq(irq)
-#  define enable_irq_lockdep(irq)		enable_irq(irq)
-# endif
 
 /* IRQ wakeup (PM) control: */
 extern int set_irq_wake(unsigned int irq, unsigned int on);
@@ -96,6 +85,18 @@ static inline int disable_irq_wake(unsig
 	return set_irq_wake(irq, 0);
 }
 
+#else /* !CONFIG_GENERIC_HARDIRQS */
+/*
+ * NOTE: non-genirq architectures, if they want to support the lock
+ * validator need to define the methods below in their asm/irq.h
+ * files, under an #ifdef CONFIG_LOCKDEP section.
+ */
+# ifndef CONFIG_LOCKDEP
+#  define disable_irq_nosync_lockdep(irq)	disable_irq_nosync(irq)
+#  define disable_irq_lockdep(irq)		disable_irq(irq)
+#  define enable_irq_lockdep(irq)		enable_irq(irq)
+# endif
+
 #endif /* CONFIG_GENERIC_HARDIRQS */
 
 #ifndef __ARCH_SET_SOFTIRQ_PENDING
_


^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: 2.6.17-mm3: arm: *_irq_wake compile error
  2006-06-28  7:12     ` Andrew Morton
@ 2006-06-28  7:20       ` Thomas Gleixner
  2006-06-28  8:13         ` Ingo Molnar
  0 siblings, 1 reply; 42+ messages in thread
From: Thomas Gleixner @ 2006-06-28  7:20 UTC (permalink / raw)
  To: Andrew Morton; +Cc: bunk, linux-kernel, mingo, rmk

On Wed, 2006-06-28 at 00:12 -0700, Andrew Morton wrote:
> OK, so I moved the above lines inside #ifdef CONFIG_GENERIC_HARDIRQS (diff
> did a strange-looking thing with it):

Yeah, but its nevertheless correct. :)

	tglx



^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: 2.6.17-mm3: arm: *_irq_wake compile error
  2006-06-28  7:20       ` Thomas Gleixner
@ 2006-06-28  8:13         ` Ingo Molnar
  2006-06-28  8:30           ` [patch] genirq: rename desc->handler to desc->chip, sparc64 fix Ingo Molnar
  0 siblings, 1 reply; 42+ messages in thread
From: Ingo Molnar @ 2006-06-28  8:13 UTC (permalink / raw)
  To: Thomas Gleixner; +Cc: Andrew Morton, bunk, linux-kernel, rmk


* Thomas Gleixner <tglx@linutronix.de> wrote:

> On Wed, 2006-06-28 at 00:12 -0700, Andrew Morton wrote:
> > OK, so I moved the above lines inside #ifdef CONFIG_GENERIC_HARDIRQS (diff
> > did a strange-looking thing with it):
> 
> Yeah, but its nevertheless correct. :)

lets hope it builds sparc64 & co too.

/me goes to try

	Ingo

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [patch] genirq: rename desc->handler to desc->chip, sparc64 fix
  2006-06-28  8:13         ` Ingo Molnar
@ 2006-06-28  8:30           ` Ingo Molnar
  2006-06-28  8:39             ` David Miller
  0 siblings, 1 reply; 42+ messages in thread
From: Ingo Molnar @ 2006-06-28  8:30 UTC (permalink / raw)
  To: Thomas Gleixner; +Cc: Andrew Morton, bunk, linux-kernel, rmk, David S. Miller


* Ingo Molnar <mingo@elte.hu> wrote:

> > > OK, so I moved the above lines inside #ifdef CONFIG_GENERIC_HARDIRQS (diff
> > > did a strange-looking thing with it):
> > 
> > Yeah, but its nevertheless correct. :)
> 
> lets hope it builds sparc64 & co too.
> 
> /me goes to try

ok, sparc64 needed the rename fix below, but otherwise it built fine on 
-mm3.

	Ingo

----------------
Subject: genirq: rename desc->handler to desc->chip, sparc64 fix
From: Ingo Molnar <mingo@elte.hu>

make sparc64 build.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/sparc64/kernel/irq.c |   10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Index: linux/arch/sparc64/kernel/irq.c
===================================================================
--- linux.orig/arch/sparc64/kernel/irq.c
+++ linux/arch/sparc64/kernel/irq.c
@@ -151,7 +151,7 @@ int show_interrupts(struct seq_file *p, 
 		for_each_online_cpu(j)
 			seq_printf(p, "%10u ", kstat_cpu(j).irqs[i]);
 #endif
-		seq_printf(p, " %9s", irq_desc[i].handler->typename);
+		seq_printf(p, " %9s", irq_desc[i].chip->typename);
 		seq_printf(p, "  %s", action->name);
 
 		for (action=action->next; action; action = action->next)
@@ -414,8 +414,8 @@ void irq_install_pre_handler(int virt_ir
 	data->pre_handler_arg1 = arg1;
 	data->pre_handler_arg2 = arg2;
 
-	desc->handler = (desc->handler == &sun4u_irq ?
-			 &sun4u_irq_ack : &sun4v_irq_ack);
+	desc->chip = (desc->chip == &sun4u_irq ?
+		      &sun4u_irq_ack : &sun4v_irq_ack);
 }
 
 unsigned int build_irq(int inofixup, unsigned long iclr, unsigned long imap)
@@ -431,7 +431,7 @@ unsigned int build_irq(int inofixup, uns
 	bucket = &ivector_table[ino];
 	if (!bucket->virt_irq) {
 		bucket->virt_irq = virt_irq_alloc(__irq(bucket));
-		irq_desc[bucket->virt_irq].handler = &sun4u_irq;
+		irq_desc[bucket->virt_irq].chip = &sun4u_irq;
 	}
 
 	desc = irq_desc + bucket->virt_irq;
@@ -465,7 +465,7 @@ unsigned int sun4v_build_irq(u32 devhand
 	bucket = &ivector_table[sysino];
 	if (!bucket->virt_irq) {
 		bucket->virt_irq = virt_irq_alloc(__irq(bucket));
-		irq_desc[bucket->virt_irq].handler = &sun4v_irq;
+		irq_desc[bucket->virt_irq].chip = &sun4v_irq;
 	}
 
 	desc = irq_desc + bucket->virt_irq;

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: [patch] genirq: rename desc->handler to desc->chip, sparc64 fix
  2006-06-28  8:30           ` [patch] genirq: rename desc->handler to desc->chip, sparc64 fix Ingo Molnar
@ 2006-06-28  8:39             ` David Miller
  2006-06-28  8:48               ` Andrew Morton
  0 siblings, 1 reply; 42+ messages in thread
From: David Miller @ 2006-06-28  8:39 UTC (permalink / raw)
  To: mingo; +Cc: tglx, akpm, bunk, linux-kernel, rmk

From: Ingo Molnar <mingo@elte.hu>
Date: Wed, 28 Jun 2006 10:30:08 +0200

> 
> * Ingo Molnar <mingo@elte.hu> wrote:
> 
> > > > OK, so I moved the above lines inside #ifdef CONFIG_GENERIC_HARDIRQS (diff
> > > > did a strange-looking thing with it):
> > > 
> > > Yeah, but its nevertheless correct. :)
> > 
> > lets hope it builds sparc64 & co too.
> > 
> > /me goes to try
> 
> ok, sparc64 needed the rename fix below, but otherwise it built fine on 
> -mm3.

Thanks Ingo.

Can we get the genirq stuff into Linus's tree soon?  I'm touching
a lot of stuff in this area on sparc64 right now :)

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: [patch] genirq: rename desc->handler to desc->chip, sparc64 fix
  2006-06-28  8:48               ` Andrew Morton
@ 2006-06-28  8:47                 ` Ingo Molnar
  2006-06-28  9:24                 ` David Miller
  2006-06-29  4:58                 ` Paul Mackerras
  2 siblings, 0 replies; 42+ messages in thread
From: Ingo Molnar @ 2006-06-28  8:47 UTC (permalink / raw)
  To: Andrew Morton; +Cc: David Miller, tglx, bunk, linux-kernel, rmk


* Andrew Morton <akpm@osdl.org> wrote:

> > > ok, sparc64 needed the rename fix below, but otherwise it built fine on 
> > > -mm3.
> > 
> > Thanks Ingo.
> > 
> > Can we get the genirq stuff into Linus's tree soon?
> 
> I'm thinking Thursday/Fridayish.  Is that OK?

fine with me. (Thursday would be slightly better i guess, from a 
dont-work-on-weekends-too-hard POV.)

	Ingo

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: [patch] genirq: rename desc->handler to desc->chip, sparc64 fix
  2006-06-28  8:39             ` David Miller
@ 2006-06-28  8:48               ` Andrew Morton
  2006-06-28  8:47                 ` Ingo Molnar
                                   ` (2 more replies)
  0 siblings, 3 replies; 42+ messages in thread
From: Andrew Morton @ 2006-06-28  8:48 UTC (permalink / raw)
  To: David Miller; +Cc: mingo, tglx, bunk, linux-kernel, rmk

On Wed, 28 Jun 2006 01:39:40 -0700 (PDT)
David Miller <davem@davemloft.net> wrote:

> From: Ingo Molnar <mingo@elte.hu>
> Date: Wed, 28 Jun 2006 10:30:08 +0200
> 
> > 
> > * Ingo Molnar <mingo@elte.hu> wrote:
> > 
> > > > > OK, so I moved the above lines inside #ifdef CONFIG_GENERIC_HARDIRQS (diff
> > > > > did a strange-looking thing with it):
> > > > 
> > > > Yeah, but its nevertheless correct. :)
> > > 
> > > lets hope it builds sparc64 & co too.
> > > 
> > > /me goes to try
> > 
> > ok, sparc64 needed the rename fix below, but otherwise it built fine on 
> > -mm3.
> 
> Thanks Ingo.
> 
> Can we get the genirq stuff into Linus's tree soon?

I'm thinking Thursday/Fridayish.  Is that OK?

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: [patch] genirq: rename desc->handler to desc->chip, sparc64 fix
  2006-06-28  8:48               ` Andrew Morton
  2006-06-28  8:47                 ` Ingo Molnar
@ 2006-06-28  9:24                 ` David Miller
  2006-06-29  4:58                 ` Paul Mackerras
  2 siblings, 0 replies; 42+ messages in thread
From: David Miller @ 2006-06-28  9:24 UTC (permalink / raw)
  To: akpm; +Cc: mingo, tglx, bunk, linux-kernel, rmk

From: Andrew Morton <akpm@osdl.org>
Date: Wed, 28 Jun 2006 01:48:07 -0700

> I'm thinking Thursday/Fridayish.  Is that OK?

Sure :)

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: 2.6.17-mm3 - mutex warning in usbhid, battery problem, and slab corruption
  2006-06-27  8:52 2.6.17-mm3 Andrew Morton
                   ` (7 preceding siblings ...)
  2006-06-27 22:40 ` 2.6.17-mm3: arm: *_irq_wake compile error Adrian Bunk
@ 2006-06-28 12:03 ` Rafael J. Wysocki
  2006-06-28 12:09   ` Andrew Morton
  2006-06-28 14:14 ` 2.6.17-mm3 Cedric Le Goater
                   ` (4 subsequent siblings)
  13 siblings, 1 reply; 42+ messages in thread
From: Rafael J. Wysocki @ 2006-06-28 12:03 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel

On Tuesday 27 June 2006 10:52, Andrew Morton wrote:
> 
> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.17/2.6.17-mm3/

I have three problems with this kernel.

First, there's a mutex lock warning as in the appended trace and my USB
mouse doesn't work.

Second, kpowersave is apparently unable to get the battery status,
although the data in /proc/acpi/battery/BAT0/ seem to be correct
(this also happened with 2.6.17-mm2, but it did not happen with
2.6.17-rc6-mm2).

Finally, I'm still seeing slab corruptions in dmesg (eg. at the end of the
appended trace).

Greetings,
Rafael


  usbdev2.4_ep81: ep_device_release called for usbdev2.4_ep81
 BUG: warning at kernel/mutex.c:132/__mutex_lock_common()
 
 Call Trace:
  [<ffffffff8020ab6f>] show_trace+0x9f/0x240
  [<ffffffff8020af45>] dump_stack+0x15/0x20
  [<ffffffff8047296b>] __mutex_lock_slowpath+0xab/0x280
  [<ffffffff80472b49>] mutex_lock+0x9/0x10
  [<ffffffff803ed909>] input_unregister_device+0x109/0x160
  [<ffffffff88157ab2>] :usbhid:hidinput_disconnect+0x72/0xa0
  [<ffffffff88153d3d>] :usbhid:hid_disconnect+0x9d/0x110
  [<ffffffff803dd85b>] usb_unbind_interface+0x5b/0xb0
  [<ffffffff803bb03d>] __device_release_driver+0x8d/0xb0
  [<ffffffff803bb324>] device_release_driver+0x34/0x50
  [<ffffffff803ba6af>] bus_remove_device+0xaf/0xe0
  [<ffffffff803b9067>] device_del+0x157/0x1a0
  [<ffffffff803dc548>] usb_disable_device+0x108/0x1a0
  [<ffffffff803d44e2>] usb_disconnect+0xd2/0x150
  [<ffffffff803d7c0f>] hub_thread+0x63f/0xff0
  [<ffffffff802435c9>] kthread+0xd9/0x110
  [<ffffffff8020a34a>] child_rip+0x8/0x12
 general protection fault: 0000 [1] PREEMPT 
 last sysfs file: /power/state
 CPU 0 
 Modules linked in: usbserial asus_acpi thermal processor fan button battery ac af_packet snd_pcm_oss snd_mixer_oss snd_seq snd_seq_device bcm43xx ieee80211softmac ieee80211 ieee80211_crypt pcmcia firmware_class ohci1394 ieee1394 sk98lin yenta_socket rsrc_nonstatic pcmcia_core ip6t_REJECT xt_tcpudp ipt_REJECT xt_state iptable_mangle iptable_nat ip_nat iptable_filter usbhid ip6table_mangle ip_conntrack snd_intel8x0 ip_tables snd_ac97_codec snd_ac97_bus snd_pcm snd_timer snd soundcore snd_page_alloc ip6table_filter ip6_tables x_tables ehci_hcd i2c_nforce2 i2c_core ohci_hcd parport_pc lp parport ipv6 dm_mod
 Pid: 110, comm: khubd Not tainted 2.6.17-mm3 #1
 RIP: 0010:[<ffffffff804729b8>]  [<ffffffff804729b8>] __mutex_lock_slowpath+0xf8/0x280
 RSP: 0000:ffff810037e83b58  EFLAGS: 00010046
 RAX: 6b6b6b6b6b6b6b6b RBX: ffff810057d417e0 RCX: 0000000000000000
 RDX: ffff810037e82000 RSI: ffff810037e83b58 RDI: ffff810057d417e0
 RBP: ffff810037e83bb8 R08: 0000000000000002 R09: 0000000000000001
 R10: 0000000000000000 R11: ffffffff80527530 R12: 0000000000000246
 R13: ffff810037f7d040 R14: ffff810057d418a0 R15: ffff810037e83b58
 FS:  00002ba97bcadb00(0000) GS:ffffffff808e6000(0000) knlGS:0000000000000000
 CS:  0010 DS: 0018 ES: 0018 CR0: 000000008005003b
 CR2: 000000000051b2d4 CR3: 0000000059515000 CR4: 00000000000006e0
 Process khubd (pid: 110, threadinfo ffff810037e82000, task ffff810037f7d040)
 Stack:  ffff810057d418a0 ffff810037e83b58 1111111111111111 ffff810057d417e0
  ffff810037e83b58 ffff810057d41000 ffff810037e83b98 ffff810057d417e0
  ffff810057d41000 ffff810057d41ae0 ffff81005f26d088 ffff81005f26d088
 Call Trace:
  [<ffffffff80472b49>] mutex_lock+0x9/0x10
  [<ffffffff803ed909>] input_unregister_device+0x109/0x160
  [<ffffffff88157ab2>] :usbhid:hidinput_disconnect+0x72/0xa0
  [<ffffffff88153d3d>] :usbhid:hid_disconnect+0x9d/0x110
  [<ffffffff803dd85b>] usb_unbind_interface+0x5b/0xb0
  [<ffffffff803bb03d>] __device_release_driver+0x8d/0xb0
  [<ffffffff803bb324>] device_release_driver+0x34/0x50
  [<ffffffff803ba6af>] bus_remove_device+0xaf/0xe0
  [<ffffffff803b9067>] device_del+0x157/0x1a0
  [<ffffffff803dc548>] usb_disable_device+0x108/0x1a0
  [<ffffffff803d44e2>] usb_disconnect+0xd2/0x150
  [<ffffffff803d7c0f>] hub_thread+0x63f/0xff0
  [<ffffffff802435c9>] kthread+0xd9/0x110
  [<ffffffff8020a34a>] child_rip+0x8/0x12
 
 Code: 4c 89 38 48 89 45 a8 4c 89 6d b0 48 c7 c0 ff ff ff ff 87 03 
 RIP  [<ffffffff804729b8>] __mutex_lock_slowpath+0xf8/0x280
  RSP <ffff810037e83b58>

  <3>Slab corruption: start=ffff810057d41000, len=4096
 7e0: 6b 6b 6b 6b 6b 6b 6b 6b 00 00 00 00 6b 6b 6b 6b
 8a0: 6b 6b 6b 6b 6b 6b 6b 6b 58 3b e8 37 00 81 ff ff

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: 2.6.17-mm3 - mutex warning in usbhid, battery problem, and slab corruption
  2006-06-28 12:03 ` 2.6.17-mm3 - mutex warning in usbhid, battery problem, and slab corruption Rafael J. Wysocki
@ 2006-06-28 12:09   ` Andrew Morton
  0 siblings, 0 replies; 42+ messages in thread
From: Andrew Morton @ 2006-06-28 12:09 UTC (permalink / raw)
  To: Rafael J. Wysocki; +Cc: linux-kernel

On Wed, 28 Jun 2006 14:03:33 +0200
"Rafael J. Wysocki" <rjw@sisk.pl> wrote:

> On Tuesday 27 June 2006 10:52, Andrew Morton wrote:
> > 
> > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.17/2.6.17-mm3/
> 
> I have three problems with this kernel.
> 
> First, there's a mutex lock warning as in the appended trace and my USB
> mouse doesn't work.
> 
> Second, kpowersave is apparently unable to get the battery status,
> although the data in /proc/acpi/battery/BAT0/ seem to be correct
> (this also happened with 2.6.17-mm2, but it did not happen with
> 2.6.17-rc6-mm2).
> 
> Finally, I'm still seeing slab corruptions in dmesg (eg. at the end of the
> appended trace).
> 
> Greetings,
> Rafael
> 
> 
>   usbdev2.4_ep81: ep_device_release called for usbdev2.4_ep81
>  BUG: warning at kernel/mutex.c:132/__mutex_lock_common()
>  
>  Call Trace:
>   [<ffffffff8020ab6f>] show_trace+0x9f/0x240
>   [<ffffffff8020af45>] dump_stack+0x15/0x20
>   [<ffffffff8047296b>] __mutex_lock_slowpath+0xab/0x280
>   [<ffffffff80472b49>] mutex_lock+0x9/0x10
>   [<ffffffff803ed909>] input_unregister_device+0x109/0x160
>   [<ffffffff88157ab2>] :usbhid:hidinput_disconnect+0x72/0xa0
>   [<ffffffff88153d3d>] :usbhid:hid_disconnect+0x9d/0x110
>   [<ffffffff803dd85b>] usb_unbind_interface+0x5b/0xb0
>   [<ffffffff803bb03d>] __device_release_driver+0x8d/0xb0
>   [<ffffffff803bb324>] device_release_driver+0x34/0x50
>   [<ffffffff803ba6af>] bus_remove_device+0xaf/0xe0
>   [<ffffffff803b9067>] device_del+0x157/0x1a0
>   [<ffffffff803dc548>] usb_disable_device+0x108/0x1a0
>   [<ffffffff803d44e2>] usb_disconnect+0xd2/0x150
>   [<ffffffff803d7c0f>] hub_thread+0x63f/0xff0
>   [<ffffffff802435c9>] kthread+0xd9/0x110
>   [<ffffffff8020a34a>] child_rip+0x8/0x12

I assume that is the second warning here:

#define spin_lock_mutex(lock, flags)			\
	do {						\
		struct mutex *l = container_of(lock, struct mutex, wait_lock); \
							\
		DEBUG_LOCKS_WARN_ON(in_interrupt());	\
		local_irq_save(flags);			\
		__raw_spin_lock(&(lock)->raw_lock);	\
		DEBUG_LOCKS_WARN_ON(l->magic != l);	\
	} while (0)

(it's a bit awkward that both warnings are at the same line number).

This looks like the bug which Linus has been chasing.  iirc, that's
half-fixed now.

>   <3>Slab corruption: start=ffff810057d41000, len=4096
>  7e0: 6b 6b 6b 6b 6b 6b 6b 6b 00 00 00 00 6b 6b 6b 6b
>  8a0: 6b 6b 6b 6b 6b 6b 6b 6b 58 3b e8 37 00 81 ff ff

This might fix, not sure..

--- a/lib/vsprintf.c~vsnprintf-fix
+++ a/lib/vsprintf.c
@@ -259,7 +259,9 @@ int vsnprintf(char *buf, size_t size, co
 	int len;
 	unsigned long long num;
 	int i, base;
-	char *str, *end, c;
+	char *str;		/* Where we're writing to */
+	char *end;		/* The last byte we can write to */
+	char c;
 	const char *s;
 
 	int flags;		/* flags to number() */
@@ -283,12 +285,12 @@ int vsnprintf(char *buf, size_t size, co
 	}
 
 	str = buf;
-	end = buf + size;
+	end = buf + size - 1;
 
 	/* Make sure end is always >= buf */
-	if (end < buf) {
+	if (end < buf - 1) {
 		end = ((void *)-1);
-		size = end - buf;
+		size = end - buf + 1;
 	}
 
 	for (; *fmt ; ++fmt) {
@@ -494,7 +496,6 @@ int vsnprintf(char *buf, size_t size, co
 	/* the trailing null byte doesn't count towards the total */
 	return str-buf;
 }
-
 EXPORT_SYMBOL(vsnprintf);
 
 /**
_


^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: 2.6.17-mm3
  2006-06-27  8:52 2.6.17-mm3 Andrew Morton
                   ` (8 preceding siblings ...)
  2006-06-28 12:03 ` 2.6.17-mm3 - mutex warning in usbhid, battery problem, and slab corruption Rafael J. Wysocki
@ 2006-06-28 14:14 ` Cedric Le Goater
  2006-06-28 16:54 ` [-mm patch] make drivers/scsi/aic7xxx/aic79xx_core.:ahd_set_tags() static Adrian Bunk
                   ` (3 subsequent siblings)
  13 siblings, 0 replies; 42+ messages in thread
From: Cedric Le Goater @ 2006-06-28 14:14 UTC (permalink / raw)
  To: Andrew Morton
  Cc: linux-kernel, Heiko Carstens, Martin Schwidefsky, Ingo Molnar

From: Cedric Le Goater <clg@fr.ibm.com>
Subject: [s390] fix compile issue when stacktrace is not configured

Signed-off-by: Cedric Le Goater <clg@fr.ibm.com>

---
 arch/s390/kernel/Makefile |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Index: 2.6.17-mm3/arch/s390/kernel/Makefile
===================================================================
--- 2.6.17-mm3.orig/arch/s390/kernel/Makefile
+++ 2.6.17-mm3/arch/s390/kernel/Makefile
@@ -4,7 +4,7 @@

 EXTRA_AFLAGS	:= -traditional

-obj-y	:=  bitmap.o traps.o time.o process.o stacktrace.o \
+obj-y	:=  bitmap.o traps.o time.o process.o \
             setup.o sys_s390.o ptrace.o signal.o cpcmd.o ebcdic.o \
             semaphore.o s390_ext.o debug.o profile.o irq.o reipl_diag.o

@@ -21,6 +21,7 @@ obj-$(CONFIG_COMPAT)		+= compat_linux.o
 obj-$(CONFIG_BINFMT_ELF32)	+= binfmt_elf32.o

 obj-$(CONFIG_VIRT_TIMER)	+= vtime.o
+obj-$(CONFIG_STACKTRACE)	+= stacktrace.o

 # Kexec part
 S390_KEXEC_OBJS := machine_kexec.o crash.o

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [-mm patch] make drivers/scsi/aic7xxx/aic79xx_core.:ahd_set_tags() static
  2006-06-27  8:52 2.6.17-mm3 Andrew Morton
                   ` (9 preceding siblings ...)
  2006-06-28 14:14 ` 2.6.17-mm3 Cedric Le Goater
@ 2006-06-28 16:54 ` Adrian Bunk
  2006-06-28 16:54 ` [-mm patch] kernel/rcutorture.c: make code static Adrian Bunk
                   ` (2 subsequent siblings)
  13 siblings, 0 replies; 42+ messages in thread
From: Adrian Bunk @ 2006-06-28 16:54 UTC (permalink / raw)
  To: Andrew Morton, James.Bottomley; +Cc: linux-kernel, linux-scsi

On Tue, Jun 27, 2006 at 01:52:11AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.17-mm2:
>...
>  git-scsi-misc.patch
>...
>  git trees.
>...

ahd_set_tags() can now become static.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 drivers/scsi/aic7xxx/aic79xx.h      |    5 -----
 drivers/scsi/aic7xxx/aic79xx_core.c |    2 +-
 2 files changed, 1 insertion(+), 6 deletions(-)

--- linux-2.6.17-mm3-full/drivers/scsi/aic7xxx/aic79xx.h.old	2006-06-27 17:46:00.000000000 +0200
+++ linux-2.6.17-mm3-full/drivers/scsi/aic7xxx/aic79xx.h	2006-06-27 17:46:08.000000000 +0200
@@ -1427,11 +1427,6 @@
 	AHD_QUEUE_TAGGED
 } ahd_queue_alg;
 
-void			ahd_set_tags(struct ahd_softc *ahd,
-				     struct scsi_cmnd *cmd,
-				     struct ahd_devinfo *devinfo,
-				     ahd_queue_alg alg);
-
 /**************************** Target Mode *************************************/
 #ifdef AHD_TARGET_MODE
 void		ahd_send_lstate_events(struct ahd_softc *,
--- linux-2.6.17-mm3-full/drivers/scsi/aic7xxx/aic79xx_core.c.old	2006-06-27 17:46:17.000000000 +0200
+++ linux-2.6.17-mm3-full/drivers/scsi/aic7xxx/aic79xx_core.c	2006-06-27 17:46:27.000000000 +0200
@@ -3877,7 +3877,7 @@
 /*
  * Update the current state of tagged queuing for a given target.
  */
-void
+static void
 ahd_set_tags(struct ahd_softc *ahd, struct scsi_cmnd *cmd,
 	     struct ahd_devinfo *devinfo, ahd_queue_alg alg)
 {


^ permalink raw reply	[flat|nested] 42+ messages in thread

* [-mm patch] kernel/rcutorture.c: make code static
  2006-06-27  8:52 2.6.17-mm3 Andrew Morton
                   ` (10 preceding siblings ...)
  2006-06-28 16:54 ` [-mm patch] make drivers/scsi/aic7xxx/aic79xx_core.:ahd_set_tags() static Adrian Bunk
@ 2006-06-28 16:54 ` Adrian Bunk
  2006-06-28 17:13   ` Paul E. McKenney
  2006-06-28 20:18   ` Paul E. McKenney
  2006-06-28 16:55 ` [-mm patch] kernel/lockdep.c: possible cleanups Adrian Bunk
  2006-06-28 16:55 ` [-mm patch] fs/ecryptfs/: " Adrian Bunk
  13 siblings, 2 replies; 42+ messages in thread
From: Adrian Bunk @ 2006-06-28 16:54 UTC (permalink / raw)
  To: Andrew Morton, Paul E. McKenney; +Cc: linux-kernel

This patch makes needlessly global code static.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 kernel/rcutorture.c |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

--- linux-2.6.17-mm3-full/kernel/rcutorture.c.old	2006-06-27 17:59:20.000000000 +0200
+++ linux-2.6.17-mm3-full/kernel/rcutorture.c	2006-06-27 18:01:00.000000000 +0200
@@ -105,11 +105,11 @@
 static DEFINE_PER_CPU(long [RCU_TORTURE_PIPE_LEN + 1], rcu_torture_batch) =
 	{ 0 };
 static atomic_t rcu_torture_wcount[RCU_TORTURE_PIPE_LEN + 1];
-atomic_t n_rcu_torture_alloc;
-atomic_t n_rcu_torture_alloc_fail;
-atomic_t n_rcu_torture_free;
-atomic_t n_rcu_torture_mberror;
-atomic_t n_rcu_torture_error;
+static atomic_t n_rcu_torture_alloc;
+static atomic_t n_rcu_torture_alloc_fail;
+static atomic_t n_rcu_torture_free;
+static atomic_t n_rcu_torture_mberror;
+static atomic_t n_rcu_torture_error;
 
 /*
  * Allocate an element from the rcu_tortures pool.
@@ -338,7 +338,7 @@
 	}
 }
 
-int srcu_torture_stats(char *page)
+static int srcu_torture_stats(char *page)
 {
 	int cnt = 0;
 	int cpu;
@@ -567,7 +567,7 @@
 /* Shuffle tasks such that we allow @rcu_idle_cpu to become idle. A special case
  * is when @rcu_idle_cpu = -1, when we allow the tasks to run on all CPUs.
  */
-void rcu_torture_shuffle_tasks(void)
+static void rcu_torture_shuffle_tasks(void)
 {
 	cpumask_t tmp_mask = CPU_MASK_ALL;
 	int i;


^ permalink raw reply	[flat|nested] 42+ messages in thread

* [-mm patch] kernel/lockdep.c: possible cleanups
  2006-06-27  8:52 2.6.17-mm3 Andrew Morton
                   ` (11 preceding siblings ...)
  2006-06-28 16:54 ` [-mm patch] kernel/rcutorture.c: make code static Adrian Bunk
@ 2006-06-28 16:55 ` Adrian Bunk
  2006-06-29 13:49   ` Ingo Molnar
  2006-06-28 16:55 ` [-mm patch] fs/ecryptfs/: " Adrian Bunk
  13 siblings, 1 reply; 42+ messages in thread
From: Adrian Bunk @ 2006-06-28 16:55 UTC (permalink / raw)
  To: Andrew Morton, Ingo Molnar; +Cc: linux-kernel

On Tue, Jun 27, 2006 at 01:52:11AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.17-mm2:
>...
> +lockdep-core.patch
>...
>  Locking validator
>...

This patch contains the following possible cleanups:
- make the needlessly global variable lockdep_init_error static
- make the needlessly global lockdep_print_held_locks() static
- #if 0 the unused global print_lock_classes()
  (this also implies to #if 0 some static functions)

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 include/linux/lockdep.h    |    5 -----
 kernel/lockdep.c           |   10 ++++++++--
 kernel/lockdep_internals.h |    7 -------
 3 files changed, 8 insertions(+), 14 deletions(-)

--- linux-2.6.17-mm3-full/kernel/lockdep_internals.h.old	2006-06-27 17:53:22.000000000 +0200
+++ linux-2.6.17-mm3-full/kernel/lockdep_internals.h	2006-06-27 17:53:56.000000000 +0200
@@ -49,13 +49,6 @@
 
 #ifdef CONFIG_DEBUG_LOCKDEP
 /*
- * We cannot printk in early bootup code. Not even early_printk()
- * might work. So we mark any initialization errors and printk
- * about it later on, in lockdep_info().
- */
-extern int lockdep_init_error;
-
-/*
  * Various lockdep statistics:
  */
 extern atomic_t chain_lookup_hits;
--- linux-2.6.17-mm3-full/include/linux/lockdep.h.old	2006-06-27 17:54:35.000000000 +0200
+++ linux-2.6.17-mm3-full/include/linux/lockdep.h	2006-06-27 17:54:57.000000000 +0200
@@ -191,9 +191,6 @@
 extern void lockdep_reset_lock(struct lockdep_map *lock);
 extern void lockdep_free_key_range(void *start, unsigned long size);
 
-extern void print_lock_classes(void);
-extern void lockdep_print_held_locks(struct task_struct *task);
-
 extern void lockdep_off(void);
 extern void lockdep_on(void);
 extern int lockdep_internal(void);
@@ -258,8 +255,6 @@
 # define lock_release(l, n, i)			do { } while (0)
 # define lockdep_init()				do { } while (0)
 # define lockdep_info()				do { } while (0)
-# define print_lock_classes()			do { } while (0)
-# define lockdep_print_held_locks(task)		do { (void)(task); } while (0)
 # define lockdep_init_map(lock, name, key)	do { } while (0)
 # define lockdep_set_class(lock, key)		do { (void)(key); } while (0)
 # define INIT_LOCKDEP
--- linux-2.6.17-mm3-full/kernel/lockdep.c.old	2006-06-27 17:54:03.000000000 +0200
+++ linux-2.6.17-mm3-full/kernel/lockdep.c	2006-06-27 18:55:55.000000000 +0200
@@ -262,7 +262,7 @@
  * might work. So we mark any initialization errors and printk
  * about it later on, in lockdep_info().
  */
-int lockdep_init_error;
+static int lockdep_init_error;
 
 /*
  * Various lockdep statistics:
@@ -373,6 +373,7 @@
 	printk("){%c%c%c%c}", c1, c2, c3, c4);
 }
 
+#if 0
 static void print_lock_name_field(struct lock_class *class)
 {
 	const char *name;
@@ -390,6 +391,7 @@
 			printk("/%d", class->subclass);
 	}
 }
+#endif  /*  0  */
 
 static void print_lockdep_cache(struct lockdep_map *lock)
 {
@@ -410,7 +412,7 @@
 	print_ip_sym(hlock->acquire_ip);
 }
 
-void lockdep_print_held_locks(struct task_struct *curr)
+static void lockdep_print_held_locks(struct task_struct *curr)
 {
 	int i, depth = curr->lockdep_depth;
 
@@ -488,6 +490,8 @@
 	}
 }
 
+#if 0
+
 /*
  * printk all locks that are taken after this lock:
  */
@@ -539,6 +543,8 @@
 	}
 }
 
+#endif  /*  0  */
+
 /*
  * Add a new dependency to the head of the list:
  */


^ permalink raw reply	[flat|nested] 42+ messages in thread

* [-mm patch] fs/ecryptfs/: possible cleanups
  2006-06-27  8:52 2.6.17-mm3 Andrew Morton
                   ` (12 preceding siblings ...)
  2006-06-28 16:55 ` [-mm patch] kernel/lockdep.c: possible cleanups Adrian Bunk
@ 2006-06-28 16:55 ` Adrian Bunk
  2006-06-28 18:40   ` Michael Halcrow
  13 siblings, 1 reply; 42+ messages in thread
From: Adrian Bunk @ 2006-06-28 16:55 UTC (permalink / raw)
  To: Andrew Morton, Phillip Hellewell; +Cc: linux-kernel, Michael Halcrow

This patch contains the following possible cleanups:
- make needlessly global functions static
- there's usually no reason for functions in C files to be marked as
  inline - gcc usually knows best whether or not to inline a function

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

BTW: please add a MAINTAINERS entry

 fs/ecryptfs/crypto.c          |   53 +++++++++++++++++++++-------------
 fs/ecryptfs/ecryptfs_kernel.h |   15 ---------
 fs/ecryptfs/inode.c           |   11 +++----
 fs/ecryptfs/keystore.c        |    2 -
 fs/ecryptfs/main.c            |    4 +-
 fs/ecryptfs/mmap.c            |    2 -
 fs/ecryptfs/super.c           |    4 +-
 7 files changed, 46 insertions(+), 45 deletions(-)

--- linux-2.6.17-mm3-full/fs/ecryptfs/ecryptfs_kernel.h.old	2006-06-27 22:54:03.000000000 +0200
+++ linux-2.6.17-mm3-full/fs/ecryptfs/ecryptfs_kernel.h	2006-06-27 22:59:14.000000000 +0200
@@ -398,17 +398,12 @@
 			     const char *name, int length,
 			     char **encoded_name);
 struct dentry *ecryptfs_lower_dentry(struct dentry *this_dentry);
-void ecryptfs_copy_attr_times(struct inode *dest, const struct inode *src);
 void ecryptfs_copy_attr_atime(struct inode *dest, const struct inode *src);
 void ecryptfs_copy_attr_all(struct inode *dest, const struct inode *src);
 void ecryptfs_copy_inode_size(struct inode *dst, const struct inode *src);
 void ecryptfs_dump_hex(char *data, int bytes);
 int virt_to_scatterlist(const void *addr, int size, struct scatterlist *sg,
 			int sg_size);
-int ecryptfs_calculate_md5(char *dst, struct ecryptfs_crypt_stat *crypt_stat,
-			   char *src, int len);
-int ecryptfs_derive_iv(char *iv, struct ecryptfs_crypt_stat *crypt_stat,
-		       pgoff_t offset);
 int ecryptfs_compute_root_iv(struct ecryptfs_crypt_stat *crypt_stat);
 void ecryptfs_rotate_iv(unsigned char *iv);
 void ecryptfs_init_crypt_stat(struct ecryptfs_crypt_stat *crypt_stat);
@@ -439,17 +434,7 @@
 					      struct inode *lower_inode,
 					      struct writeback_control *wbc);
 int ecryptfs_encrypt_page(struct ecryptfs_page_crypt_context *ctx);
-int
-ecryptfs_encrypt_page_offset(struct ecryptfs_crypt_stat *crypt_stat,
-			     struct page *dst_page, int dst_offset,
-			     struct page *src_page, int src_offset, int size,
-			     unsigned char *iv);
 int ecryptfs_decrypt_page(struct file *file, struct page *page);
-int
-ecryptfs_decrypt_page_offset(struct ecryptfs_crypt_stat *crypt_stat,
-			     struct page *dst_page, int dst_offset,
-			     struct page *src_page, int src_offset, int size,
-			     unsigned char *iv);
 int ecryptfs_write_headers(struct dentry *ecryptfs_dentry,
 			   struct file *lower_file);
 int ecryptfs_write_headers_virt(char *page_virt,
--- linux-2.6.17-mm3-full/fs/ecryptfs/crypto.c.old	2006-06-27 22:54:18.000000000 +0200
+++ linux-2.6.17-mm3-full/fs/ecryptfs/crypto.c	2006-06-27 23:01:53.000000000 +0200
@@ -35,6 +35,17 @@
 #include <linux/scatterlist.h>
 #include "ecryptfs_kernel.h"
 
+static int
+ecryptfs_decrypt_page_offset(struct ecryptfs_crypt_stat *crypt_stat,
+			     struct page *dst_page, int dst_offset,
+			     struct page *src_page, int src_offset, int size,
+			     unsigned char *iv);
+static int
+ecryptfs_encrypt_page_offset(struct ecryptfs_crypt_stat *crypt_stat,
+			     struct page *dst_page, int dst_offset,
+			     struct page *src_page, int src_offset, int size,
+			     unsigned char *iv);
+
 /**
  * ecryptfs_to_hex
  * @dst: Buffer to take hex character representation of contents of
@@ -42,7 +53,7 @@
  * @src: Buffer to be converted to a hex string respresentation
  * @src_size: number of bytes to convert
  */
-inline void ecryptfs_to_hex(char *dst, char *src, int src_size)
+void ecryptfs_to_hex(char *dst, char *src, int src_size)
 {
 	int x;
 
@@ -57,7 +68,7 @@
  * @src: Buffer to be converted from a hex string respresentation to raw value
  * @dst_size: size of dst buffer, or number of hex characters pairs to convert
  */
-inline void ecryptfs_from_hex(char *dst, char *src, int dst_size)
+void ecryptfs_from_hex(char *dst, char *src, int dst_size)
 {
 	int x;
 	char tmp[3] = { 0, };
@@ -79,8 +90,9 @@
  * Uses the allocated crypto context that crypt_stat references to
  * generate the MD5 sum of the contents of src.
  */
-int ecryptfs_calculate_md5(char *dst, struct ecryptfs_crypt_stat *crypt_stat,
-			   char *src, int len)
+static int ecryptfs_calculate_md5(char *dst,
+				  struct ecryptfs_crypt_stat *crypt_stat,
+				  char *src, int len)
 {
 	int rc = 0;
 	struct scatterlist sg;
@@ -114,8 +126,8 @@
  *
  * Returns zero on success; non-zero on error.
  */
-int ecryptfs_derive_iv(char *iv, struct ecryptfs_crypt_stat *crypt_stat,
-		       pgoff_t offset)
+static int ecryptfs_derive_iv(char *iv, struct ecryptfs_crypt_stat *crypt_stat,
+			      pgoff_t offset)
 {
 	int rc = 0;
 	char dst[MD5_DIGEST_SIZE];
@@ -284,7 +296,7 @@
 	return rc;
 }
 
-void
+static void
 ecryptfs_extent_to_lwr_pg_idx_and_offset(unsigned long *lower_page_idx,
 					 int *byte_offset,
 					 struct ecryptfs_crypt_stat *crypt_stat,
@@ -326,9 +338,10 @@
 			(*byte_offset));
 }
 
-int ecryptfs_write_out_page(struct ecryptfs_page_crypt_context *ctx,
-			    struct page *lower_page, struct inode *lower_inode,
-			    int byte_offset_in_page, int bytes_to_write)
+static int ecryptfs_write_out_page(struct ecryptfs_page_crypt_context *ctx,
+				   struct page *lower_page,
+				   struct inode *lower_inode,
+				   int byte_offset_in_page, int bytes_to_write)
 {
 	int rc = 0;
 
@@ -356,9 +369,11 @@
 	return rc;
 }
 
-int ecryptfs_read_in_page(struct ecryptfs_page_crypt_context *ctx,
-			  struct page **lower_page, struct inode *lower_inode,
-			  unsigned long lower_page_idx, int byte_offset_in_page)
+static int ecryptfs_read_in_page(struct ecryptfs_page_crypt_context *ctx,
+				 struct page **lower_page,
+				 struct inode *lower_inode,
+				 unsigned long lower_page_idx,
+				 int byte_offset_in_page)
 {
 	int rc = 0;
 
@@ -690,7 +705,7 @@
  *
  * Returns the number of bytes encrypted
  */
-int
+static int
 ecryptfs_encrypt_page_offset(struct ecryptfs_crypt_stat *crypt_stat,
 			     struct page *dst_page, int dst_offset,
 			     struct page *src_page, int src_offset, int size,
@@ -712,7 +727,7 @@
  *
  * Returns the number of bytes decrypted
  */
-int
+static int
 ecryptfs_decrypt_page_offset(struct ecryptfs_crypt_stat *crypt_stat,
 			     struct page *dst_page, int dst_offset,
 			     struct page *src_page, int src_offset, int size,
@@ -1348,7 +1363,7 @@
  * compatibility for files created with the prior versions of
  * eCryptfs.
  */
-inline void set_default_header_data(struct ecryptfs_crypt_stat *crypt_stat)
+static void set_default_header_data(struct ecryptfs_crypt_stat *crypt_stat)
 {
 	crypt_stat->header_extent_size = 4096;
 	crypt_stat->num_header_extents_at_front = 1;
@@ -1362,9 +1377,9 @@
  *
  * Returns zero on success
  */
-int ecryptfs_read_headers_virt(char *page_virt,
-			       struct ecryptfs_crypt_stat *crypt_stat,
-			       struct dentry *ecryptfs_dentry)
+static int ecryptfs_read_headers_virt(char *page_virt,
+				      struct ecryptfs_crypt_stat *crypt_stat,
+				      struct dentry *ecryptfs_dentry)
 {
 	int rc = 0;
 	int offset;
--- linux-2.6.17-mm3-full/fs/ecryptfs/inode.c.old	2006-06-27 22:59:31.000000000 +0200
+++ linux-2.6.17-mm3-full/fs/ecryptfs/inode.c	2006-06-27 23:02:12.000000000 +0200
@@ -32,7 +32,7 @@
 #include <linux/crypto.h>
 #include "ecryptfs_kernel.h"
 
-static inline struct dentry *lock_parent(struct dentry *dentry)
+static struct dentry *lock_parent(struct dentry *dentry)
 {
 	struct dentry *dir;
 
@@ -41,13 +41,13 @@
 	return dir;
 }
 
-static inline void unlock_parent(struct dentry *dentry)
+static void unlock_parent(struct dentry *dentry)
 {
 	mutex_unlock(&(dentry->d_parent->d_inode->i_mutex));
 	dput(dentry->d_parent);
 }
 
-static inline void unlock_dir(struct dentry *dir)
+static void unlock_dir(struct dentry *dir)
 {
 	mutex_unlock(&dir->d_inode->i_mutex);
 	dput(dir);
@@ -66,7 +66,8 @@
 	dest->i_atime = src->i_atime;
 }
 
-void ecryptfs_copy_attr_times(struct inode *dest, const struct inode *src)
+static void ecryptfs_copy_attr_times(struct inode *dest,
+				     const struct inode *src)
 {
 	BUG_ON(!dest);
 	BUG_ON(!src);
@@ -755,7 +756,7 @@
 	return ERR_PTR(rc);
 }
 
-static inline void
+static void
 ecryptfs_put_link(struct dentry *dentry, struct nameidata *nd, void *ptr)
 {
 	/* Free the char* */
--- linux-2.6.17-mm3-full/fs/ecryptfs/keystore.c.old	2006-06-27 23:00:04.000000000 +0200
+++ linux-2.6.17-mm3-full/fs/ecryptfs/keystore.c	2006-06-27 23:00:12.000000000 +0200
@@ -741,7 +741,7 @@
  *
  * Returns zero on success; non-zero on error.
  */
-int
+static int
 write_tag_11_packet(char *dest, int max, char *contents, int contents_length,
 		    int *packet_length)
 {
--- linux-2.6.17-mm3-full/fs/ecryptfs/main.c.old	2006-06-27 23:00:27.000000000 +0200
+++ linux-2.6.17-mm3-full/fs/ecryptfs/main.c	2006-06-27 23:02:27.000000000 +0200
@@ -148,7 +148,7 @@
  *
  * Returns zero on good version; non-zero otherwise
  */
-int ecryptfs_verify_version(u16 version)
+static int ecryptfs_verify_version(u16 version)
 {
 	int rc = 0;
 	unsigned char major;
@@ -374,7 +374,7 @@
  *
  * Preform the cleanup for ecryptfs_read_super()
  */
-static inline void ecryptfs_cleanup_read_super(struct super_block *sb)
+static void ecryptfs_cleanup_read_super(struct super_block *sb)
 {
 	up_write(&sb->s_umount);
 	deactivate_super(sb);
--- linux-2.6.17-mm3-full/fs/ecryptfs/mmap.c.old	2006-06-27 23:00:49.000000000 +0200
+++ linux-2.6.17-mm3-full/fs/ecryptfs/mmap.c	2006-06-27 23:01:06.000000000 +0200
@@ -391,7 +391,7 @@
 	return rc;
 }
 
-void ecryptfs_unmap_and_release_lower_page(struct page *lower_page)
+static void ecryptfs_unmap_and_release_lower_page(struct page *lower_page)
 {
 	kunmap(lower_page);
 	ecryptfs_printk(KERN_DEBUG, "Unlocking lower page with index = "
--- linux-2.6.17-mm3-full/fs/ecryptfs/super.c.old	2006-06-27 23:02:40.000000000 +0200
+++ linux-2.6.17-mm3-full/fs/ecryptfs/super.c	2006-06-27 23:02:47.000000000 +0200
@@ -122,7 +122,7 @@
  * Get the filesystem statistics. Currently, we let this pass right through
  * to the lower filesystem and take no action ourselves.
  */
-static inline int ecryptfs_statfs(struct dentry *dentry, struct kstatfs *buf)
+static int ecryptfs_statfs(struct dentry *dentry, struct kstatfs *buf)
 {
 	return vfs_statfs(ecryptfs_dentry_to_lower(dentry), buf);
 }
@@ -137,7 +137,7 @@
  * on the inode free list. We use this to drop out reference to the
  * lower inode.
  */
-static inline void ecryptfs_clear_inode(struct inode *inode)
+static void ecryptfs_clear_inode(struct inode *inode)
 {
 	iput(ecryptfs_inode_to_lower(inode));
 }


^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: [-mm patch] kernel/rcutorture.c: make code static
  2006-06-28 16:54 ` [-mm patch] kernel/rcutorture.c: make code static Adrian Bunk
@ 2006-06-28 17:13   ` Paul E. McKenney
  2006-06-28 17:17     ` Adrian Bunk
  2006-06-28 20:18   ` Paul E. McKenney
  1 sibling, 1 reply; 42+ messages in thread
From: Paul E. McKenney @ 2006-06-28 17:13 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: Andrew Morton, linux-kernel

On Wed, Jun 28, 2006 at 06:54:45PM +0200, Adrian Bunk wrote:
> This patch makes needlessly global code static.

Looks good to me -- but have you tested it?  If so, I will ack, otherwise
I will test and ack/nack depending on the results.

							Thanx, Paul

> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> 
> ---
> 
>  kernel/rcutorture.c |   14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> --- linux-2.6.17-mm3-full/kernel/rcutorture.c.old	2006-06-27 17:59:20.000000000 +0200
> +++ linux-2.6.17-mm3-full/kernel/rcutorture.c	2006-06-27 18:01:00.000000000 +0200
> @@ -105,11 +105,11 @@
>  static DEFINE_PER_CPU(long [RCU_TORTURE_PIPE_LEN + 1], rcu_torture_batch) =
>  	{ 0 };
>  static atomic_t rcu_torture_wcount[RCU_TORTURE_PIPE_LEN + 1];
> -atomic_t n_rcu_torture_alloc;
> -atomic_t n_rcu_torture_alloc_fail;
> -atomic_t n_rcu_torture_free;
> -atomic_t n_rcu_torture_mberror;
> -atomic_t n_rcu_torture_error;
> +static atomic_t n_rcu_torture_alloc;
> +static atomic_t n_rcu_torture_alloc_fail;
> +static atomic_t n_rcu_torture_free;
> +static atomic_t n_rcu_torture_mberror;
> +static atomic_t n_rcu_torture_error;
>  
>  /*
>   * Allocate an element from the rcu_tortures pool.
> @@ -338,7 +338,7 @@
>  	}
>  }
>  
> -int srcu_torture_stats(char *page)
> +static int srcu_torture_stats(char *page)
>  {
>  	int cnt = 0;
>  	int cpu;
> @@ -567,7 +567,7 @@
>  /* Shuffle tasks such that we allow @rcu_idle_cpu to become idle. A special case
>   * is when @rcu_idle_cpu = -1, when we allow the tasks to run on all CPUs.
>   */
> -void rcu_torture_shuffle_tasks(void)
> +static void rcu_torture_shuffle_tasks(void)
>  {
>  	cpumask_t tmp_mask = CPU_MASK_ALL;
>  	int i;
> 

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: [-mm patch] kernel/rcutorture.c: make code static
  2006-06-28 17:13   ` Paul E. McKenney
@ 2006-06-28 17:17     ` Adrian Bunk
  2006-06-28 17:49       ` Paul E. McKenney
  0 siblings, 1 reply; 42+ messages in thread
From: Adrian Bunk @ 2006-06-28 17:17 UTC (permalink / raw)
  To: Paul E. McKenney; +Cc: Andrew Morton, linux-kernel

On Wed, Jun 28, 2006 at 10:13:09AM -0700, Paul E. McKenney wrote:
> On Wed, Jun 28, 2006 at 06:54:45PM +0200, Adrian Bunk wrote:
> > This patch makes needlessly global code static.
> 
> Looks good to me -- but have you tested it?  If so, I will ack, otherwise
> I will test and ack/nack depending on the results.

I've only tested the compilation (which should be enough considering the 
nature of the patch).

> 							Thanx, Paul

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: [-mm patch] kernel/rcutorture.c: make code static
  2006-06-28 17:17     ` Adrian Bunk
@ 2006-06-28 17:49       ` Paul E. McKenney
  0 siblings, 0 replies; 42+ messages in thread
From: Paul E. McKenney @ 2006-06-28 17:49 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: Andrew Morton, linux-kernel

On Wed, Jun 28, 2006 at 07:17:51PM +0200, Adrian Bunk wrote:
> On Wed, Jun 28, 2006 at 10:13:09AM -0700, Paul E. McKenney wrote:
> > On Wed, Jun 28, 2006 at 06:54:45PM +0200, Adrian Bunk wrote:
> > > This patch makes needlessly global code static.
> > 
> > Looks good to me -- but have you tested it?  If so, I will ack, otherwise
> > I will test and ack/nack depending on the results.
> 
> I've only tested the compilation (which should be enough considering the 
> nature of the patch).

Perhaps it should be, but I am paranoid.  Too many ways for compilers,
include files, and CPP macros to play tricks.  I will test it.

							Thanx, Paul

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: [-mm patch] fs/ecryptfs/: possible cleanups
  2006-06-28 16:55 ` [-mm patch] fs/ecryptfs/: " Adrian Bunk
@ 2006-06-28 18:40   ` Michael Halcrow
  0 siblings, 0 replies; 42+ messages in thread
From: Michael Halcrow @ 2006-06-28 18:40 UTC (permalink / raw)
  To: akpm; +Cc: Adrian Bunk, Phillip Hellewell, linux-kernel

On Wed, Jun 28, 2006 at 06:55:25PM +0200, Adrian Bunk wrote:
> This patch contains the following possible cleanups:
> - make needlessly global functions static
> - there's usually no reason for functions in C files to be marked as
>   inline - gcc usually knows best whether or not to inline a function
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>

Acked-by: Michael Halcrow <mhalcrow@us.ibm.com>

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: [-mm patch] kernel/rcutorture.c: make code static
  2006-06-28 16:54 ` [-mm patch] kernel/rcutorture.c: make code static Adrian Bunk
  2006-06-28 17:13   ` Paul E. McKenney
@ 2006-06-28 20:18   ` Paul E. McKenney
  1 sibling, 0 replies; 42+ messages in thread
From: Paul E. McKenney @ 2006-06-28 20:18 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: Andrew Morton, linux-kernel

On Wed, Jun 28, 2006 at 06:54:45PM +0200, Adrian Bunk wrote:
> This patch makes needlessly global code static.

OK, ran a short test which passed on i386.  So we are set.

						Thanx, Paul

Acked-by: Paul E. McKenney <paulmck@us.ibm.com>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> 
> ---
> 
>  kernel/rcutorture.c |   14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> --- linux-2.6.17-mm3-full/kernel/rcutorture.c.old	2006-06-27 17:59:20.000000000 +0200
> +++ linux-2.6.17-mm3-full/kernel/rcutorture.c	2006-06-27 18:01:00.000000000 +0200
> @@ -105,11 +105,11 @@
>  static DEFINE_PER_CPU(long [RCU_TORTURE_PIPE_LEN + 1], rcu_torture_batch) =
>  	{ 0 };
>  static atomic_t rcu_torture_wcount[RCU_TORTURE_PIPE_LEN + 1];
> -atomic_t n_rcu_torture_alloc;
> -atomic_t n_rcu_torture_alloc_fail;
> -atomic_t n_rcu_torture_free;
> -atomic_t n_rcu_torture_mberror;
> -atomic_t n_rcu_torture_error;
> +static atomic_t n_rcu_torture_alloc;
> +static atomic_t n_rcu_torture_alloc_fail;
> +static atomic_t n_rcu_torture_free;
> +static atomic_t n_rcu_torture_mberror;
> +static atomic_t n_rcu_torture_error;
>  
>  /*
>   * Allocate an element from the rcu_tortures pool.
> @@ -338,7 +338,7 @@
>  	}
>  }
>  
> -int srcu_torture_stats(char *page)
> +static int srcu_torture_stats(char *page)
>  {
>  	int cnt = 0;
>  	int cpu;
> @@ -567,7 +567,7 @@
>  /* Shuffle tasks such that we allow @rcu_idle_cpu to become idle. A special case
>   * is when @rcu_idle_cpu = -1, when we allow the tasks to run on all CPUs.
>   */
> -void rcu_torture_shuffle_tasks(void)
> +static void rcu_torture_shuffle_tasks(void)
>  {
>  	cpumask_t tmp_mask = CPU_MASK_ALL;
>  	int i;
> 

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: [patch] genirq: rename desc->handler to desc->chip, sparc64 fix
  2006-06-28  8:48               ` Andrew Morton
  2006-06-28  8:47                 ` Ingo Molnar
  2006-06-28  9:24                 ` David Miller
@ 2006-06-29  4:58                 ` Paul Mackerras
  2006-06-29  6:42                   ` Ingo Molnar
  2 siblings, 1 reply; 42+ messages in thread
From: Paul Mackerras @ 2006-06-29  4:58 UTC (permalink / raw)
  To: Andrew Morton; +Cc: David Miller, mingo, tglx, bunk, linux-kernel, rmk

Andrew Morton writes:

> I'm thinking Thursday/Fridayish.  Is that OK?

I'm not sure that leaves me time to get Ben H's powerpc genirq stuff
into the powerpc.git tree and get Linus to pull before the end of the
merge window...

Paul.

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: [patch] genirq: rename desc->handler to desc->chip, sparc64 fix
  2006-06-29  4:58                 ` Paul Mackerras
@ 2006-06-29  6:42                   ` Ingo Molnar
  0 siblings, 0 replies; 42+ messages in thread
From: Ingo Molnar @ 2006-06-29  6:42 UTC (permalink / raw)
  To: Paul Mackerras; +Cc: Andrew Morton, David Miller, tglx, bunk, linux-kernel, rmk


* Paul Mackerras <paulus@samba.org> wrote:

> > I'm thinking Thursday/Fridayish.  Is that OK?
> 
> I'm not sure that leaves me time to get Ben H's powerpc genirq stuff 
> into the powerpc.git tree and get Linus to pull before the end of the 
> merge window...

The genirq changes on powerpc qualify as fixes i think - would that help 
the logistics of this merge?

	Ingo

^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: [-mm patch] kernel/lockdep.c: possible cleanups
  2006-06-28 16:55 ` [-mm patch] kernel/lockdep.c: possible cleanups Adrian Bunk
@ 2006-06-29 13:49   ` Ingo Molnar
  0 siblings, 0 replies; 42+ messages in thread
From: Ingo Molnar @ 2006-06-29 13:49 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: Andrew Morton, linux-kernel


* Adrian Bunk <bunk@stusta.de> wrote:

> On Tue, Jun 27, 2006 at 01:52:11AM -0700, Andrew Morton wrote:
> >...
> > Changes since 2.6.17-mm2:
> >...
> > +lockdep-core.patch
> >...
> >  Locking validator
> >...
> 
> This patch contains the following possible cleanups:
> - make the needlessly global variable lockdep_init_error static
> - make the needlessly global lockdep_print_held_locks() static
> - #if 0 the unused global print_lock_classes()
>   (this also implies to #if 0 some static functions)
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>

thanks!

  Acked-by: Ingo Molnar <mingo@elte.hu>

i sent a followup cleanup patch to Andrew that removes those #if 0 
sections for real. Let me know if/when you find anything else.

	Ingo

^ permalink raw reply	[flat|nested] 42+ messages in thread

* [-mm patch] kernel/rcutorture.c: make code static
  2006-07-09  9:11 2.6.18-rc1-mm1 Andrew Morton
@ 2006-07-09 17:53 ` Adrian Bunk
  2006-07-10 14:58   ` Paul E. McKenney
  0 siblings, 1 reply; 42+ messages in thread
From: Adrian Bunk @ 2006-07-09 17:53 UTC (permalink / raw)
  To: Andrew Morton, Paul E. McKenney; +Cc: linux-kernel

On Sun, Jul 09, 2006 at 02:11:06AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.17-mm6:
>...
> -srcu-rcu-variant-permitting-read-side-blocking.patch
> -srcu-2-rcu-variant-permitting-read-side-blocking.patch
> -srcu-add-srcu-operations-to-rcutorture.patch
> -srcu-2-add-srcu-operations-to-rcutorture.patch
> +srcu-3-rcu-variant-permitting-read-side-blocking.patch
> +srcu-3-rcu-variant-permitting-read-side-blocking-fix.patch
> +srcu-3-add-srcu-operations-to-rcutorture.patch
> 
>  Updated srcu patchset.
>...

The contents of the patch below somehow got lost during these updates.

cu
Adrian


<--  snip  -->


This patch makes needlessly global code static.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 kernel/rcutorture.c |   14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

--- linux-2.6.17-mm3-full/kernel/rcutorture.c.old	2006-06-27 17:59:20.000000000 +0200
+++ linux-2.6.17-mm3-full/kernel/rcutorture.c	2006-06-27 18:01:00.000000000 +0200
@@ -105,11 +105,11 @@
 static DEFINE_PER_CPU(long [RCU_TORTURE_PIPE_LEN + 1], rcu_torture_batch) =
 	{ 0 };
 static atomic_t rcu_torture_wcount[RCU_TORTURE_PIPE_LEN + 1];
-atomic_t n_rcu_torture_alloc;
-atomic_t n_rcu_torture_alloc_fail;
-atomic_t n_rcu_torture_free;
-atomic_t n_rcu_torture_mberror;
-atomic_t n_rcu_torture_error;
+static atomic_t n_rcu_torture_alloc;
+static atomic_t n_rcu_torture_alloc_fail;
+static atomic_t n_rcu_torture_free;
+static atomic_t n_rcu_torture_mberror;
+static atomic_t n_rcu_torture_error;
 
 /*
  * Allocate an element from the rcu_tortures pool.
@@ -338,7 +338,7 @@
 	}
 }
 
-int srcu_torture_stats(char *page)
+static int srcu_torture_stats(char *page)
 {
 	int cnt = 0;
 	int cpu;
@@ -567,7 +567,7 @@
 /* Shuffle tasks such that we allow @rcu_idle_cpu to become idle. A special case
  * is when @rcu_idle_cpu = -1, when we allow the tasks to run on all CPUs.
  */
-void rcu_torture_shuffle_tasks(void)
+static void rcu_torture_shuffle_tasks(void)
 {
 	cpumask_t tmp_mask = CPU_MASK_ALL;
 	int i;



^ permalink raw reply	[flat|nested] 42+ messages in thread

* Re: [-mm patch] kernel/rcutorture.c: make code static
  2006-07-09 17:53 ` [-mm patch] kernel/rcutorture.c: make code static Adrian Bunk
@ 2006-07-10 14:58   ` Paul E. McKenney
  0 siblings, 0 replies; 42+ messages in thread
From: Paul E. McKenney @ 2006-07-10 14:58 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: Andrew Morton, linux-kernel

On Sun, Jul 09, 2006 at 07:53:33PM +0200, Adrian Bunk wrote:
> On Sun, Jul 09, 2006 at 02:11:06AM -0700, Andrew Morton wrote:
> >...
> > Changes since 2.6.17-mm6:
> >...
> > -srcu-rcu-variant-permitting-read-side-blocking.patch
> > -srcu-2-rcu-variant-permitting-read-side-blocking.patch
> > -srcu-add-srcu-operations-to-rcutorture.patch
> > -srcu-2-add-srcu-operations-to-rcutorture.patch
> > +srcu-3-rcu-variant-permitting-read-side-blocking.patch
> > +srcu-3-rcu-variant-permitting-read-side-blocking-fix.patch
> > +srcu-3-add-srcu-operations-to-rcutorture.patch
> > 
> >  Updated srcu patchset.
> >...
> 
> The contents of the patch below somehow got lost during these updates.
> 
> cu
> Adrian

My bad...  I have applied this to my local view.

Andrew, please apply.

							Thanx, Paul

> <--  snip  -->
> 
> 
> This patch makes needlessly global code static.

Acked-by: Paul E. McKenney <paulmck@us.ibm.com>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> 
> ---
> 
>  kernel/rcutorture.c |   14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> --- linux-2.6.17-mm3-full/kernel/rcutorture.c.old	2006-06-27 17:59:20.000000000 +0200
> +++ linux-2.6.17-mm3-full/kernel/rcutorture.c	2006-06-27 18:01:00.000000000 +0200
> @@ -105,11 +105,11 @@
>  static DEFINE_PER_CPU(long [RCU_TORTURE_PIPE_LEN + 1], rcu_torture_batch) =
>  	{ 0 };
>  static atomic_t rcu_torture_wcount[RCU_TORTURE_PIPE_LEN + 1];
> -atomic_t n_rcu_torture_alloc;
> -atomic_t n_rcu_torture_alloc_fail;
> -atomic_t n_rcu_torture_free;
> -atomic_t n_rcu_torture_mberror;
> -atomic_t n_rcu_torture_error;
> +static atomic_t n_rcu_torture_alloc;
> +static atomic_t n_rcu_torture_alloc_fail;
> +static atomic_t n_rcu_torture_free;
> +static atomic_t n_rcu_torture_mberror;
> +static atomic_t n_rcu_torture_error;
>  
>  /*
>   * Allocate an element from the rcu_tortures pool.
> @@ -338,7 +338,7 @@
>  	}
>  }
>  
> -int srcu_torture_stats(char *page)
> +static int srcu_torture_stats(char *page)
>  {
>  	int cnt = 0;
>  	int cpu;
> @@ -567,7 +567,7 @@
>  /* Shuffle tasks such that we allow @rcu_idle_cpu to become idle. A special case
>   * is when @rcu_idle_cpu = -1, when we allow the tasks to run on all CPUs.
>   */
> -void rcu_torture_shuffle_tasks(void)
> +static void rcu_torture_shuffle_tasks(void)
>  {
>  	cpumask_t tmp_mask = CPU_MASK_ALL;
>  	int i;
> 
> 

^ permalink raw reply	[flat|nested] 42+ messages in thread

end of thread, other threads:[~2006-07-10 14:58 UTC | newest]

Thread overview: 42+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-27  8:52 2.6.17-mm3 Andrew Morton
2006-06-27  9:14 ` 2.6.17-mm3: no help text for READAHEAD_ALLOW_OVERHEADS Adrian Bunk
     [not found]   ` <20060627134337.GA6117@mail.ustc.edu.cn>
2006-06-27 13:43     ` Wu Fengguang
2006-06-27 14:40     ` Adrian Bunk
     [not found]       ` <20060627155227.GA6014@mail.ustc.edu.cn>
2006-06-27 15:52         ` Wu Fengguang
2006-06-27 17:46       ` Randy.Dunlap
2006-06-27 17:55         ` Adrian Bunk
2006-06-27  9:28 ` [patch] irq: fix arch/i386/kernel/irq.c gcc warning Ingo Molnar
2006-06-27 11:06   ` Björn Steinbrink
2006-06-27 11:14 ` x86_64-mm-ieee1394-early.patch (was Re: 2.6.17-mm3) Stefan Richter
2006-06-27 11:17 ` 2.6.17-mm3 Reuben Farrelly
2006-06-27 11:48 ` 2.6.17-mm3 Reuben Farrelly
2006-06-27 14:12 ` 2.6.17-mm3 Michal Piotrowski
2006-06-27 21:38 ` 2.6.17-mm3 Steve Fox
2006-06-27 23:12   ` 2.6.17-mm3 Martin Bligh
2006-06-27 22:40 ` 2.6.17-mm3: arm: *_irq_wake compile error Adrian Bunk
2006-06-28  7:09   ` Thomas Gleixner
2006-06-28  7:12     ` Andrew Morton
2006-06-28  7:20       ` Thomas Gleixner
2006-06-28  8:13         ` Ingo Molnar
2006-06-28  8:30           ` [patch] genirq: rename desc->handler to desc->chip, sparc64 fix Ingo Molnar
2006-06-28  8:39             ` David Miller
2006-06-28  8:48               ` Andrew Morton
2006-06-28  8:47                 ` Ingo Molnar
2006-06-28  9:24                 ` David Miller
2006-06-29  4:58                 ` Paul Mackerras
2006-06-29  6:42                   ` Ingo Molnar
2006-06-28 12:03 ` 2.6.17-mm3 - mutex warning in usbhid, battery problem, and slab corruption Rafael J. Wysocki
2006-06-28 12:09   ` Andrew Morton
2006-06-28 14:14 ` 2.6.17-mm3 Cedric Le Goater
2006-06-28 16:54 ` [-mm patch] make drivers/scsi/aic7xxx/aic79xx_core.:ahd_set_tags() static Adrian Bunk
2006-06-28 16:54 ` [-mm patch] kernel/rcutorture.c: make code static Adrian Bunk
2006-06-28 17:13   ` Paul E. McKenney
2006-06-28 17:17     ` Adrian Bunk
2006-06-28 17:49       ` Paul E. McKenney
2006-06-28 20:18   ` Paul E. McKenney
2006-06-28 16:55 ` [-mm patch] kernel/lockdep.c: possible cleanups Adrian Bunk
2006-06-29 13:49   ` Ingo Molnar
2006-06-28 16:55 ` [-mm patch] fs/ecryptfs/: " Adrian Bunk
2006-06-28 18:40   ` Michael Halcrow
  -- strict thread matches above, loose matches on Subject: below --
2006-07-09  9:11 2.6.18-rc1-mm1 Andrew Morton
2006-07-09 17:53 ` [-mm patch] kernel/rcutorture.c: make code static Adrian Bunk
2006-07-10 14:58   ` Paul E. McKenney

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox