* remove devinit from ioc4 pci_driver
@ 2006-06-28 19:33 Dave Jones
2006-07-05 15:56 ` Brent Casavant
0 siblings, 1 reply; 2+ messages in thread
From: Dave Jones @ 2006-06-28 19:33 UTC (permalink / raw)
To: Linux Kernel; +Cc: bcasavan
Documention/pci.txt states..
"The struct pci_driver shouldn't be marked with any of these tags."
(Referring to __devinit and friends).
Signed-off-by: Dave Jones <davej@redhat.com>
--- linux-2.6/drivers/sn/ioc4.c~ 2006-06-28 15:31:26.000000000 -0400
+++ linux-2.6/drivers/sn/ioc4.c 2006-06-28 15:32:09.000000000 -0400
@@ -438,7 +438,7 @@ static struct pci_device_id ioc4_id_tabl
{0}
};
-static struct pci_driver __devinitdata ioc4_driver = {
+static struct pci_driver ioc4_driver = {
.name = "IOC4",
.id_table = ioc4_id_table,
.probe = ioc4_probe,
--
http://www.codemonkey.org.uk
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: remove devinit from ioc4 pci_driver
2006-06-28 19:33 remove devinit from ioc4 pci_driver Dave Jones
@ 2006-07-05 15:56 ` Brent Casavant
0 siblings, 0 replies; 2+ messages in thread
From: Brent Casavant @ 2006-07-05 15:56 UTC (permalink / raw)
To: Dave Jones; +Cc: Linux Kernel
It's a bit late and after-the-fact as I was on vacation, however:
Acked-by: Brent Casavant <bcasavan@sgi.com>
On Wed, 28 Jun 2006, Dave Jones wrote:
> Documention/pci.txt states..
> "The struct pci_driver shouldn't be marked with any of these tags."
> (Referring to __devinit and friends).
>
> Signed-off-by: Dave Jones <davej@redhat.com>
>
> --- linux-2.6/drivers/sn/ioc4.c~ 2006-06-28 15:31:26.000000000 -0400
> +++ linux-2.6/drivers/sn/ioc4.c 2006-06-28 15:32:09.000000000 -0400
> @@ -438,7 +438,7 @@ static struct pci_device_id ioc4_id_tabl
> {0}
> };
>
> -static struct pci_driver __devinitdata ioc4_driver = {
> +static struct pci_driver ioc4_driver = {
> .name = "IOC4",
> .id_table = ioc4_id_table,
> .probe = ioc4_probe,
>
> --
> http://www.codemonkey.org.uk
>
--
Brent Casavant All music is folk music. I ain't
bcasavan@sgi.com never heard a horse sing a song.
Silicon Graphics, Inc. -- Louis Armstrong
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-07-05 15:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-28 19:33 remove devinit from ioc4 pci_driver Dave Jones
2006-07-05 15:56 ` Brent Casavant
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox