From: Dave Jones <davej@redhat.com>
To: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Cc: ak@suse.de
Subject: Re: [PATCH] x86_64: Move export symbols to their C functions
Date: Wed, 28 Jun 2006 15:38:41 -0400 [thread overview]
Message-ID: <20060628193841.GA22587@redhat.com> (raw)
In-Reply-To: <200606261902.k5QJ2R93008443@hera.kernel.org>
On Mon, Jun 26, 2006 at 07:02:27PM +0000, Linux Kernel wrote:
> commit 2ee60e17896c65da1df5780d3196c050bccb7d10
> tree 54b41b23c92a79e44c7f27c697c84c64052cb85d
> parent 45486f81c9aa07218b73a38cbcf62ffa66e99088
> author Andi Kleen <ak@suse.de> Mon, 26 Jun 2006 13:59:44 +0200
> committer Linus Torvalds <torvalds@g5.osdl.org> Tue, 27 Jun 2006 00:48:22 -0700
>
> [PATCH] x86_64: Move export symbols to their C functions
>
> Only exports for assembler files are left in x8664_ksyms.c
>
> -
> -EXPORT_SYMBOL_GPL(set_nmi_callback);
> -EXPORT_SYMBOL_GPL(unset_nmi_callback);
These two exports were never re-added, which broke modular oprofile.
Signed-off-by: Dave Jones <davej@redhat.com>
--- linux-2.6/arch/x86_64/kernel/nmi.c~ 2006-06-28 15:35:34.000000000 -0400
+++ linux-2.6/arch/x86_64/kernel/nmi.c 2006-06-28 15:36:12.000000000 -0400
@@ -607,11 +607,13 @@ void set_nmi_callback(nmi_callback_t cal
vmalloc_sync_all();
rcu_assign_pointer(nmi_callback, callback);
}
+EXPORT_SYMBOL_GPL(set_nmi_callback);
void unset_nmi_callback(void)
{
nmi_callback = dummy_nmi_callback;
}
+EXPORT_SYMBOL_GPL(unset_nmi_callback);
#ifdef CONFIG_SYSCTL
--
http://www.codemonkey.org.uk
next parent reply other threads:[~2006-06-28 19:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200606261902.k5QJ2R93008443@hera.kernel.org>
2006-06-28 19:38 ` Dave Jones [this message]
2006-06-28 19:52 ` [PATCH] x86_64: Move export symbols to their C functions Andi Kleen
2006-06-28 19:56 ` Dave Jones
2006-06-28 20:13 ` Dave Jones
2006-06-28 20:31 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060628193841.GA22587@redhat.com \
--to=davej@redhat.com \
--cc=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox