Re: [PATCH] x86_64: Move export symbols to their C functions

Dave Jones
2006-06-28T19:38:46Z

On Mon, Jun 26, 2006 at 07:02:27PM +0000, Linux Kernel wrote:
> commit 2ee60e17896c65da1df5780d3196c050bccb7d10
> tree 54b41b23c92a79e44c7f27c697c84c64052cb85d
> parent 45486f81c9aa07218b73a38cbcf62ffa66e99088
> author Andi Kleen <ak@suse.de> Mon, 26 Jun 2006 13:59:44 +0200
> committer Linus Torvalds <torvalds@g5.osdl.org> Tue, 27 Jun 2006 00:48:22 -0700
>
> [PATCH] x86_64: Move export symbols to their C functions
>
> Only exports for assembler files are left in x8664_ksyms.c
>
> -
> -EXPORT_SYMBOL_GPL(set_nmi_callback);
> -EXPORT_SYMBOL_GPL(unset_nmi_callback);

These two exports were never re-added, which broke modular oprofile.

Signed-off-by: Dave Jones <davej@redhat.com>

--- linux-2.6/arch/x86_64/kernel/nmi.c~ 2006-06-28 15:35:34.000000000 -0400
+++ linux-2.6/arch/x86_64/kernel/nmi.c 2006-06-28 15:36:12.000000000 -0400
@@ -607,11 +607,13 @@ void set_nmi_callback(nmi_callback_t cal
vmalloc_sync_all();
rcu_assign_pointer(nmi_callback, callback);
}
+EXPORT_SYMBOL_GPL(set_nmi_callback);

void unset_nmi_callback(void)
{
nmi_callback = dummy_nmi_callback;
}
+EXPORT_SYMBOL_GPL(unset_nmi_callback);

#ifdef CONFIG_SYSCTL