* Re: [PATCH] x86_64: Move export symbols to their C functions [not found] <200606261902.k5QJ2R93008443@hera.kernel.org> @ 2006-06-28 19:38 ` Dave Jones 2006-06-28 19:52 ` Andi Kleen 0 siblings, 1 reply; 5+ messages in thread From: Dave Jones @ 2006-06-28 19:38 UTC (permalink / raw) To: Linux Kernel Mailing List; +Cc: ak On Mon, Jun 26, 2006 at 07:02:27PM +0000, Linux Kernel wrote: > commit 2ee60e17896c65da1df5780d3196c050bccb7d10 > tree 54b41b23c92a79e44c7f27c697c84c64052cb85d > parent 45486f81c9aa07218b73a38cbcf62ffa66e99088 > author Andi Kleen <ak@suse.de> Mon, 26 Jun 2006 13:59:44 +0200 > committer Linus Torvalds <torvalds@g5.osdl.org> Tue, 27 Jun 2006 00:48:22 -0700 > > [PATCH] x86_64: Move export symbols to their C functions > > Only exports for assembler files are left in x8664_ksyms.c > > - > -EXPORT_SYMBOL_GPL(set_nmi_callback); > -EXPORT_SYMBOL_GPL(unset_nmi_callback); These two exports were never re-added, which broke modular oprofile. Signed-off-by: Dave Jones <davej@redhat.com> --- linux-2.6/arch/x86_64/kernel/nmi.c~ 2006-06-28 15:35:34.000000000 -0400 +++ linux-2.6/arch/x86_64/kernel/nmi.c 2006-06-28 15:36:12.000000000 -0400 @@ -607,11 +607,13 @@ void set_nmi_callback(nmi_callback_t cal vmalloc_sync_all(); rcu_assign_pointer(nmi_callback, callback); } +EXPORT_SYMBOL_GPL(set_nmi_callback); void unset_nmi_callback(void) { nmi_callback = dummy_nmi_callback; } +EXPORT_SYMBOL_GPL(unset_nmi_callback); #ifdef CONFIG_SYSCTL -- http://www.codemonkey.org.uk ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] x86_64: Move export symbols to their C functions 2006-06-28 19:38 ` [PATCH] x86_64: Move export symbols to their C functions Dave Jones @ 2006-06-28 19:52 ` Andi Kleen 2006-06-28 19:56 ` Dave Jones 0 siblings, 1 reply; 5+ messages in thread From: Andi Kleen @ 2006-06-28 19:52 UTC (permalink / raw) To: Dave Jones; +Cc: Linux Kernel Mailing List > These two exports were never re-added, which broke modular oprofile. Everybody and their dog sent patches for that by now and I assume Linus already merged Andrew's version -Andi ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] x86_64: Move export symbols to their C functions 2006-06-28 19:52 ` Andi Kleen @ 2006-06-28 19:56 ` Dave Jones 2006-06-28 20:13 ` Dave Jones 0 siblings, 1 reply; 5+ messages in thread From: Dave Jones @ 2006-06-28 19:56 UTC (permalink / raw) To: Andi Kleen; +Cc: Linux Kernel Mailing List On Wed, Jun 28, 2006 at 09:52:20PM +0200, Andi Kleen wrote: > > > These two exports were never re-added, which broke modular oprofile. > > Everybody and their dog sent patches for that by now and I assume > Linus already merged Andrew's version Ah, didn't see them, and my tree seems to be stale. Yes, looks fixed. Dave -- http://www.codemonkey.org.uk ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] x86_64: Move export symbols to their C functions 2006-06-28 19:56 ` Dave Jones @ 2006-06-28 20:13 ` Dave Jones 2006-06-28 20:31 ` Andi Kleen 0 siblings, 1 reply; 5+ messages in thread From: Dave Jones @ 2006-06-28 20:13 UTC (permalink / raw) To: Andi Kleen, Linux Kernel Mailing List On Wed, Jun 28, 2006 at 03:56:32PM -0400, Dave Jones wrote: > On Wed, Jun 28, 2006 at 09:52:20PM +0200, Andi Kleen wrote: > > > > > These two exports were never re-added, which broke modular oprofile. > > > > Everybody and their dog sent patches for that by now and I assume > > Linus already merged Andrew's version > > Ah, didn't see them, and my tree seems to be stale. > Yes, looks fixed. Actually, I take that back, I was looking at the wrong tree (again). It's not fixed in Linus tree yet in a git pull from a few minutes ago. Anyone else notice that head-commits is also really slow ? Lately I get commit mails from 12-24hrs earlier from it. Dave -- http://www.codemonkey.org.uk ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] x86_64: Move export symbols to their C functions 2006-06-28 20:13 ` Dave Jones @ 2006-06-28 20:31 ` Andi Kleen 0 siblings, 0 replies; 5+ messages in thread From: Andi Kleen @ 2006-06-28 20:31 UTC (permalink / raw) To: Dave Jones; +Cc: Linux Kernel Mailing List On Wednesday 28 June 2006 22:13, Dave Jones wrote: > On Wed, Jun 28, 2006 at 03:56:32PM -0400, Dave Jones wrote: > > On Wed, Jun 28, 2006 at 09:52:20PM +0200, Andi Kleen wrote: > > > > > > > These two exports were never re-added, which broke modular oprofile. > > > > > > Everybody and their dog sent patches for that by now and I assume > > > Linus already merged Andrew's version > > > > Ah, didn't see them, and my tree seems to be stale. > > Yes, looks fixed. > > Actually, I take that back, I was looking at the wrong tree (again). > It's not fixed in Linus tree yet in a git pull from a few minutes ago. At least Andrew has already sent the patch. I assume it will get in if it hasn't already. -Andi ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2006-06-28 20:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <200606261902.k5QJ2R93008443@hera.kernel.org>
2006-06-28 19:38 ` [PATCH] x86_64: Move export symbols to their C functions Dave Jones
2006-06-28 19:52 ` Andi Kleen
2006-06-28 19:56 ` Dave Jones
2006-06-28 20:13 ` Dave Jones
2006-06-28 20:31 ` Andi Kleen
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox