Re: [Suspend2][ 0/9] Extents support.

Nigel Cunningham
2006-06-28T12:42:29Z

[-- Attachment #1: Type: text/plain, Size: 1421 bytes --]

Hi.

On Wednesday 28 June 2006 21:28, Rahul Karnik wrote:
> On 6/27/06, Nigel Cunningham <nigel@suspend2.net> wrote:
> > Suspend2 is a
> > reimplementation of swsusp, not a series of incremental modifications. It
> > uses completely different methods for writing the image, storing the
> > metadata and so on. Until recently, the only thing it shared with swsusp
> > was the refrigerator and driver model calls, and even now the sharing of
> > lowlevel code is only a tiny fraction of all that is done.
>
> This is something I don't understand. Why can you not submit patches
> that simply do things like "change method for writing image" and
> reduce the difference between suspend2 and mainline? It may be more
> work, but I think you will find that incremental changes are a lot
> easier for people to review and merge.

It's because it's all so interconnected. Adding the modular infrastructure is
useless without something to use the modules. Changing to use the pageflags
functionality requires modifications in both the preparation of the image and
in the I/O. There are bits that could be done incrementally, but they're
minor. I did start with the same codebase that Pavel forked, but then did
substantial rewrites in going from the betas to 1.0 and to 2.0.

Thanks for the email.

Nigel
--
See http://www.suspend2.net for Howtos, FAQs, mailing
lists, wiki and bugzilla info.

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]