Re: 2.6.18 -mm merge plans -- GFS

Russell King
2006-06-05T14:10:49Z

On Mon, Jun 05, 2006 at 02:38:50PM +0100, David Woodhouse wrote:
> You didn't mention GFS2 either -- is that ready to go upstream?
> It contains this in its user<->kernel communication (whitespace sic)...
>
> /* struct passed to the lock write */
> struct dlm_lock_params {
> __u8 mode;
> __u16 flags;
> __u32 lkid;
> __u32 parent;
> __u8 namelen;

Hmm. This is going to be subject to random compiler padding. It would
be much better to have:

__u8 mode;
__u8 namelen;
__u16 flags;
__u32 lkid;
__u32 parent;

which should be less subject to compiler padding.

> struct dlm_write_request {
> __u32 version[3];
> __u8 cmd;

Ditto - though maybe following this by:

__u8 unused[3];

would be a sane solution.

> struct dlm_lock_result {
> __u32 length;
> void __user * user_astaddr;
> void __user * user_astparam;
> struct dlm_lksb __user * user_lksb;
> struct dlm_lksb lksb;
> __u8 bast_mode;

Ditto.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core