Re: 2.6.17-mm4 undefined reference to `alternatives_smp_module_del'

[Andrew Morton <akpm@osdl.org>]

Gregoire Favre <gregoire.favre@gmail.com> wrote:
>
> Hello,
> 
> just tried to compil 2.6.17-mm4 under amd64 and it fails with :
> 
>   AR      arch/x86_64/lib/lib.a
>   GEN     .version
>   CHK     include/linux/compile.h
>   UPD     include/linux/compile.h
>   CC      init/version.o
>   LD      init/built-in.o
>   LD      .tmp_vmlinux1
> arch/x86_64/kernel/built-in.o: In function `module_arch_cleanup':
> (.text.module_arch_cleanup+0x1): undefined reference to `alternatives_smp_module_del'
> arch/x86_64/kernel/built-in.o: In function `module_finalize':
> (.text.module_finalize+0xe8): undefined reference to `alternatives_smp_module_add'
> make: *** [.tmp_vmlinux1] Error 1
> 
> 

Thanks.  Reverting
ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.17/2.6.17-mm4/broken-out/x86-dont-print-out-smp-info-on-up-kernels.patch
will fix it.

<looks at davej>

That patch is pretty yuk anyway

 void module_arch_cleanup(struct module *mod)
 {
+#ifdef CONFIG_SMP
	alternatives_smp_module_del(mod);
+#endif
 }

Should be a stub in a header file, which would fix this problem too.