From: Nigel Cunningham <nigel@suspend2.net>
To: "Pekka Enberg" <penberg@cs.helsinki.fi>
Cc: "Rahul Karnik" <rahul@genebrew.com>, "Jens Axboe" <axboe@suse.de>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
linux-kernel@vger.kernel.org
Subject: Re: [Suspend2][ 0/9] Extents support.
Date: Thu, 29 Jun 2006 15:44:14 +1000 [thread overview]
Message-ID: <200606291544.18392.nigel@suspend2.net> (raw)
In-Reply-To: <84144f020606282219n269fffe2i27bdd789758cc268@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1911 bytes --]
Hi.
On Thursday 29 June 2006 15:19, Pekka Enberg wrote:
> On 6/29/06, Nigel Cunningham <nigel@suspend2.net> wrote:
> > Sure, I know where I'd be headed, but it would be a huge waste of time
> > and effort.
>
> Perhaps to you Nigel. For the rest of us reviewing your patches, it's
> much better. I suspect it would be better for the users down the road
> as well. I don't know if you realize it, but what you're doing now
> is, "here's a big chunck of code, take it or leave it". And at least
> historically people have had hard time doing getting stuff merged like
> that.
I did try really hard not to do that (big chunk of code, take it or leave it).
That's why it's split up into so many little patches. The problem seems to be
that it's not split up in the way some people wanted, rather than not split
up at all. I want to make it easier on you guys, but it just seems to me like
regardless of what I do, it's not the right thing.
I can understand wanting small changes to swsusp to transform it into
suspend2, but I also understand that I've spent approximately 5 years of
developing from the point Pavel forked the code base until today, and part of
that has been two complete reworkings of the way in which the data is stored
and the thing operates - irreducible complexity that just doesn't fit into
the incremental change model. So I'm trying to do what seems to me to be the
next best thing. Having arranged functions that deal with particular parts of
the system into individual files, I've broken the files up into logical parts
and submitted them in groups. If we consider the more primitive parts first,
then move to the increasingly abstract operations (or vice versa), I think
we'll have a good approach with what's already done.
Regards,
Nigel
--
See http://www.suspend2.net for Howtos, FAQs, mailing
lists, wiki and bugzilla info.
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2006-06-29 5:58 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-26 16:54 [Suspend2][ 0/9] Extents support Nigel Cunningham
2006-06-26 16:54 ` [Suspend2][ 1/9] [Suspend2] Extents header Nigel Cunningham
2006-06-26 16:54 ` [Suspend2][ 2/9] [Suspend2] Extent allocation routines Nigel Cunningham
2006-06-26 16:54 ` [Suspend2][ 3/9] [Suspend2] Free a whole extent chain Nigel Cunningham
2006-06-26 16:54 ` [Suspend2][ 4/9] [Suspend2] Add extent to " Nigel Cunningham
2006-06-26 16:54 ` [Suspend2][ 5/9] [Suspend2] Serialise extent chains Nigel Cunningham
2006-06-26 16:54 ` [Suspend2][ 6/9] [Suspend2] Get next extent in an extent state Nigel Cunningham
2006-06-26 16:54 ` [Suspend2][ 7/9] [Suspend2] Extent state to the start Nigel Cunningham
2006-06-26 16:54 ` [Suspend2][ 8/9] [Suspend2] Extent state save and restore Nigel Cunningham
2006-06-26 16:54 ` [Suspend2][ 9/9] [Suspend2] Extent header Nigel Cunningham
2006-06-26 21:20 ` [Suspend2][ 0/9] Extents support Rafael J. Wysocki
2006-06-27 4:28 ` Nigel Cunningham
2006-06-27 5:36 ` Jens Axboe
2006-06-27 5:39 ` Nigel Cunningham
2006-06-27 7:05 ` Jens Axboe
2006-06-27 7:39 ` Nigel Cunningham
2006-06-27 7:59 ` Jens Axboe
2006-06-27 8:12 ` Greg KH
2006-06-27 8:22 ` Jens Axboe
2006-06-27 8:58 ` Nigel Cunningham
2006-06-28 21:11 ` Pavel Machek
2006-06-28 22:25 ` Nigel Cunningham
2006-06-28 22:44 ` Pavel Machek
2006-06-28 23:14 ` Nigel Cunningham
2006-06-30 17:36 ` Pavel Machek
2006-06-29 3:11 ` Martin J. Bligh
2006-06-27 9:07 ` Nigel Cunningham
2006-06-27 9:26 ` Rafael J. Wysocki
2006-06-27 9:35 ` Nigel Cunningham
2006-06-27 22:19 ` Rafael J. Wysocki
2006-06-27 23:47 ` Nigel Cunningham
2006-06-28 22:35 ` Rafael J. Wysocki
2006-06-28 23:26 ` Nigel Cunningham
2006-06-29 20:52 ` Rafael J. Wysocki
2006-06-30 17:58 ` Pavel Machek
2006-06-28 11:28 ` Rahul Karnik
2006-06-28 12:42 ` Nigel Cunningham
2006-06-28 14:42 ` Pekka Enberg
2006-06-28 23:37 ` Nigel Cunningham
2006-06-29 5:19 ` Pekka Enberg
2006-06-29 5:44 ` Nigel Cunningham [this message]
2006-06-29 21:11 ` Rafael J. Wysocki
2006-06-30 17:55 ` suspend2 merge [was Re: [Suspend2][ 0/9] Extents support.] Pavel Machek
2006-07-01 9:31 ` Dumitru Ciobarcianu
2006-06-28 22:41 ` [Suspend2][ 0/9] Extents support Rafael J. Wysocki
2006-06-28 14:37 ` Olivier Galibert
2006-06-28 21:05 ` Pavel Machek
2006-06-27 7:06 ` Greg KH
2006-06-27 7:27 ` Nigel Cunningham
2006-06-27 7:53 ` Greg KH
2006-06-27 9:08 ` Nigel Cunningham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200606291544.18392.nigel@suspend2.net \
--to=nigel@suspend2.net \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=rahul@genebrew.com \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox