From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751088AbWF2Rcu (ORCPT ); Thu, 29 Jun 2006 13:32:50 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751089AbWF2Rcu (ORCPT ); Thu, 29 Jun 2006 13:32:50 -0400 Received: from [141.84.69.5] ([141.84.69.5]:34575 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S1751088AbWF2Rct (ORCPT ); Thu, 29 Jun 2006 13:32:49 -0400 Date: Thu, 29 Jun 2006 19:32:06 +0200 From: Adrian Bunk To: David Woodhouse Cc: linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org, juha.yrjola@solidboot.com Subject: Re: [2.6 patch] make drivers/mtd/cmdlinepart.c:mtdpart_setup() static Message-ID: <20060629173206.GF19712@stusta.de> References: <20060626220215.GI23314@stusta.de> <1151416141.17609.140.camel@hades.cambridge.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1151416141.17609.140.camel@hades.cambridge.redhat.com> User-Agent: Mutt/1.5.11+cvs20060403 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 27, 2006 at 02:49:00PM +0100, David Woodhouse wrote: > On Tue, 2006-06-27 at 00:02 +0200, Adrian Bunk wrote: > > This patch makes the needlessly global mtdpart_setup() static. > > > > Signed-off-by: Adrian Bunk > > > > --- linux-2.6.17-mm2-full/drivers/mtd/cmdlinepart.c.old 2006-06-26 23:18:39.000000000 +0200 > > +++ linux-2.6.17-mm2-full/drivers/mtd/cmdlinepart.c 2006-06-26 23:18:51.000000000 +0200 > > @@ -346,7 +346,7 @@ > > * > > * This function needs to be visible for bootloaders. > > */ > > -int mtdpart_setup(char *s) > > +static int mtdpart_setup(char *s) > > Patch lacks sufficient explanation. Explain the relevance of the comment > immediately above the function declaration, in the context of your > patch. Explain your decision to change the behaviour, but not change the > comment itself. My explanation regarding the relevance of the comment is that it seems to be nonsense. Do I miss something, or why and how should a bootloader access in-kernel functions? > Think. Or you will be replaced with a small shell script. No problem, I'm waiting for your submission of Adrian 1.0 ;-) > dwmw2 cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed