* [2.6 patch] mm/mmzone.c: EXPORT_UNUSED_SYMBOL
@ 2006-06-30 11:32 Adrian Bunk
2006-07-01 3:35 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2006-06-30 11:32 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
This patch marks three unused exports as EXPORT_UNUSED_SYMBOL.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
mm/mmzone.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
--- linux-2.6.17-mm4-full/mm/mmzone.c.old 2006-06-30 02:54:10.000000000 +0200
+++ linux-2.6.17-mm4-full/mm/mmzone.c 2006-06-30 02:54:55.000000000 +0200
@@ -15,7 +15,7 @@
return NODE_DATA(first_online_node);
}
-EXPORT_SYMBOL(first_online_pgdat);
+EXPORT_UNUSED_SYMBOL(first_online_pgdat); /* June 2006 */
struct pglist_data *next_online_pgdat(struct pglist_data *pgdat)
{
@@ -25,7 +25,7 @@
return NULL;
return NODE_DATA(nid);
}
-EXPORT_SYMBOL(next_online_pgdat);
+EXPORT_UNUSED_SYMBOL(next_online_pgdat); /* June 2006 */
/*
@@ -46,5 +46,5 @@
}
return zone;
}
-EXPORT_SYMBOL(next_zone);
+EXPORT_UNUSED_SYMBOL(next_zone); /* June 2006 */
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [2.6 patch] mm/mmzone.c: EXPORT_UNUSED_SYMBOL
2006-06-30 11:32 [2.6 patch] mm/mmzone.c: EXPORT_UNUSED_SYMBOL Adrian Bunk
@ 2006-07-01 3:35 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2006-07-01 3:35 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-kernel
On Fri, 30 Jun 2006 13:32:48 +0200
Adrian Bunk <bunk@stusta.de> wrote:
> -EXPORT_SYMBOL(first_online_pgdat);
> +EXPORT_UNUSED_SYMBOL(first_online_pgdat); /* June 2006 */
for_each_zone() and for_each_online_pgdat() need this. So the export is an
internal implementation detail to support those macros. Those macros are
reasonable(ish) things to be doing from modules - could be that people
are using for_each_zone() already.
> -EXPORT_SYMBOL(next_online_pgdat);
> +EXPORT_UNUSED_SYMBOL(next_online_pgdat); /* June 2006 */
Ditto
> -EXPORT_SYMBOL(next_zone);
> +EXPORT_UNUSED_SYMBOL(next_zone); /* June 2006 */
>
Tritto.
We could give it a whizz, but I'd expect that we'll end up dropping it.
But then again, zones are fairly low-level things. Let's give it a try.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-07-01 3:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-06-30 11:32 [2.6 patch] mm/mmzone.c: EXPORT_UNUSED_SYMBOL Adrian Bunk
2006-07-01 3:35 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox