public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Pantelis Antoniou <pantelis.antoniou@gmail.com>
To: "Rune Torgersen" <runet@innovsys.com>
Cc: "Kumar Gala" <galak@kernel.crashing.org>,
	"linuxppc-dev list" <linuxppc-dev@ozlabs.org>,
	"Paul Mackerras" <paulus@samba.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc:Fix rheap alignment problem
Date: Sun, 2 Jul 2006 08:18:26 +0300	[thread overview]
Message-ID: <200607020818.27603.pantelis.antoniou@gmail.com> (raw)
In-Reply-To: <DCEAAC0833DD314AB0B58112AD99B93B07B36F@ismail.innsys.innovsys.com>

On Sunday 02 July 2006 06:54, Rune Torgersen wrote:
> From: Pantelis Antoniou
> Sent: Sat 7/1/2006 9:50 AM
> >Since genalloc is the blessed linux thing it might be best to use that & remove
> >rheap completely. Oh well...
> 
> Two problems with genalloc that I can see (for CPM programming):
> 1) (minor) Does not have a way to specify alignment (genalloc does it for you)
> 2) (major problerm, at least for me) Does not have a way to allocate a specified address in the pool.
> 
> 2 is needed esp when programming MCC drivers, since a lot of the datastructures must be in DP RAM _and_ be in a specific spot. And if you cannot tell the allocator that I am using a specific address, then the allocator might very well give somebody else that portion of RAM. The only solution without a fixed allocator is to allocate ALL memory in the DP RAM and use your own allocator. 
> 

Yeah, that too.

Too bad there are no main tree drivers like that, but they do exist.

One could conceivably hack genalloc to do that, but will end up with
something complex too.

BTW, there are other uEngine based architectures with similar alignment
requirements.

So in conclusion, for the in-tree drivers genalloc is sufficient as an cpm memory allocator.
For some out of tree drivers, it is not.

Pantelis

  parent reply	other threads:[~2006-07-02  5:17 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-30 13:02 [PATCH] powerpc:Fix rheap alignment problem Li Yang-r58472
2006-06-30 23:13 ` Benjamin Herrenschmidt
     [not found]   ` <DCEAAC0833DD314AB0B58112AD99B93B07B36E@ismail.innsys.innovsys.com>
     [not found]     ` <a0bc9bf80606302335p7ba227afwf69dc42e2eada64b@mail.gmail.com>
2006-07-01  7:21       ` Benjamin Herrenschmidt
2006-07-01 10:25         ` Christoph Hellwig
2006-07-01 14:34           ` Kumar Gala
2006-07-01 14:50             ` Pantelis Antoniou
     [not found]               ` <DCEAAC0833DD314AB0B58112AD99B93B07B36F@ismail.innsys.innovsys.com>
2006-07-02  5:18                 ` Pantelis Antoniou [this message]
2006-07-03 11:08                   ` Benjamin Herrenschmidt
  -- strict thread matches above, loose matches on Subject: below --
2006-07-03  6:49 Li Yang-r58472
2006-07-03 12:19 Li Yang-r58472

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200607020818.27603.pantelis.antoniou@gmail.com \
    --to=pantelis.antoniou@gmail.com \
    --cc=galak@kernel.crashing.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    --cc=runet@innovsys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox