From: Dmitry Torokhov <dtor@insightbb.com>
To: Michael Hanselmann <linux-kernel@hansmi.ch>
Cc: linux-kernel@vger.kernel.org, lm-sensors@lm-sensors.org,
khali@linux-fr.org, linux-kernel@killerfox.forkbomb.ch,
benh@kernel.crashing.org, johannes@sipsolutions.net,
stelian@popies.net, chainsaw@gentoo.org
Subject: Re: [RFC] Apple Motion Sensor driver
Date: Sun, 2 Jul 2006 22:33:41 -0400 [thread overview]
Message-ID: <200607022233.42055.dtor@insightbb.com> (raw)
In-Reply-To: <20060702222649.GA13411@hansmi.ch>
Hi Michael,
On Sunday 02 July 2006 18:26, Michael Hanselmann wrote:
>
> +
> + if (x)
> + *x = tmpx;
> + if (y)
> + *y = tmpy;
> + if (z)
> + *z = tmpz;
All callers of ams_sensors use all 3 arguments, why bother with temps?
> +
> + ams.idev->name = "Apple Motion Sensor";
> + ams.idev->id.bustype = BUS_I2C;
Should it be always BUS_I2C? Maybe it should be BUS_HOST in case of PMU?
> + ams.idev->id.vendor = 0;
Please add:
ams.idev->cdev.dev = &ams.of_dev->dev;
so that the input device has a proper parent in sysfs hierarchy.
--
Dmitry
next prev parent reply other threads:[~2006-07-03 2:33 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-02 22:26 [RFC] Apple Motion Sensor driver Michael Hanselmann
2006-07-03 2:33 ` Dmitry Torokhov [this message]
2006-07-03 3:14 ` Andrew Morton
2006-07-03 3:47 ` Benjamin Herrenschmidt
2006-07-03 4:00 ` Andrew Morton
2006-07-03 6:56 ` Michael Hanselmann
2006-07-03 9:02 ` Stelian Pop
2006-07-03 7:29 ` Jean Delvare
2006-07-03 8:52 ` Benjamin Herrenschmidt
2006-07-03 10:12 ` Stelian Pop
2006-07-03 10:19 ` Johannes Berg
2006-07-03 10:45 ` Michael Hanselmann
2006-07-03 10:49 ` Benjamin Herrenschmidt
2006-07-03 11:31 ` Stelian Pop
2006-07-03 13:16 ` Dmitry Torokhov
2006-07-03 13:25 ` Stefan Richter
2006-07-03 13:44 ` Dmitry Torokhov
2006-07-03 22:45 ` Michael Hanselmann
2006-07-04 16:45 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200607022233.42055.dtor@insightbb.com \
--to=dtor@insightbb.com \
--cc=benh@kernel.crashing.org \
--cc=chainsaw@gentoo.org \
--cc=johannes@sipsolutions.net \
--cc=khali@linux-fr.org \
--cc=linux-kernel@hansmi.ch \
--cc=linux-kernel@killerfox.forkbomb.ch \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=stelian@popies.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox