From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750700AbWGCHmE (ORCPT ); Mon, 3 Jul 2006 03:42:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750724AbWGCHmE (ORCPT ); Mon, 3 Jul 2006 03:42:04 -0400 Received: from caramon.arm.linux.org.uk ([212.18.232.186]:21512 "EHLO caramon.arm.linux.org.uk") by vger.kernel.org with ESMTP id S1750700AbWGCHmC (ORCPT ); Mon, 3 Jul 2006 03:42:02 -0400 Date: Mon, 3 Jul 2006 08:41:55 +0100 From: Russell King To: Andrew Morton Cc: tglx@linutronix.de, torvalds@osdl.org, mingo@elte.hu, linux-kernel@vger.kernel.org Subject: Re: [PATCH] genirq: ARM dyntick cleanup Message-ID: <20060703074155.GA28235@flint.arm.linux.org.uk> Mail-Followup-To: Andrew Morton , tglx@linutronix.de, torvalds@osdl.org, mingo@elte.hu, linux-kernel@vger.kernel.org References: <1151885928.24611.24.camel@localhost.localdomain> <20060702173527.cbdbf0e1.akpm@osdl.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20060702173527.cbdbf0e1.akpm@osdl.org> User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 02, 2006 at 05:35:27PM -0700, Andrew Morton wrote: > This is not exactly a thing of beauty either. It's much cleaner to use > __attribute__((weak)), but that will add an empty call-return to everyone's > interrupts. Let's not go overboard with the weak stuff - it does not get removed at link time, so it remains as dead code in the kernel image. -- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core