Re: [RFC] Apple Motion Sensor driver

Dmitry Torokhov
2006-07-03T02:33:44Z

Hi Michael,

On Sunday 02 July 2006 18:26, Michael Hanselmann wrote:
>
> +
> + if (x)
> + *x = tmpx;
> + if (y)
> + *y = tmpy;
> + if (z)
> + *z = tmpz;

All callers of ams_sensors use all 3 arguments, why bother with temps?

> +
> + ams.idev->name = "Apple Motion Sensor";
> + ams.idev->id.bustype = BUS_I2C;

Should it be always BUS_I2C? Maybe it should be BUS_HOST in case of PMU?

> + ams.idev->id.vendor = 0;

Please add:

ams.idev->cdev.dev = &ams.of_dev->dev;

so that the input device has a proper parent in sysfs hierarchy.

--
Dmitry