From: Theodore Tso <tytso@mit.edu>
To: Christoph Hellwig <hch@infradead.org>,
akpm@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [patch 6/8] inode-diet: Move i_cindex from struct inode to struct file
Date: Mon, 3 Jul 2006 10:05:52 -0400 [thread overview]
Message-ID: <20060703140552.GB8099@thunk.org> (raw)
In-Reply-To: <20060703090532.GA8242@infradead.org>
On Mon, Jul 03, 2006 at 10:05:32AM +0100, Christoph Hellwig wrote:
> On Sun, Jul 02, 2006 at 08:53:39PM -0400, Theodore Ts'o wrote:
> > inode.i_cindex isn't initialized until the character device is opened
> > anyway, and there are far more struct inodes in memory than there are
> > struct file. So move the cindex field to file.f_cindex, and change
> > the one(!) user of cindex to use file pointer, which is in fact simpler.
>
> I think you got a pretty clear NACK from Al on this one.
>
I explained my reasoning to him --- that inode.i_cindex isn't
initialized until after the VFS-specific char-open is called, so you
can never depend on index.i_cindex being valid except in char device
driver's open method --- and that function gets passed a file pointer
as well as an index pointer. So the clean up that Al wants to do can
just as easily be done by having the device drivers use file->f_cindex
instead of inode->i_cindex.
- Ted
next prev parent reply other threads:[~2006-07-03 14:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-03 0:53 [patch 0/8] Inode slimming patches, part 1 Theodore Ts'o
2006-07-03 0:53 ` [patch 1/8] inode_diet: Replace inode.u.generic_ip with inode.i_private Theodore Ts'o
2006-07-03 0:53 ` [patch 2/8] inode-diet: Move i_pipe into a union Theodore Ts'o
2006-07-03 0:53 ` [patch 3/8] inode-diet: Move i_bdev " Theodore Ts'o
2006-07-03 0:53 ` [patch 4/8] inode-diet: Move i_cdev " Theodore Ts'o
2006-07-03 0:53 ` [patch 5/8] inode-diet: Eliminate i_blksize and use a per-superblock default Theodore Ts'o
2006-07-03 0:53 ` [patch 6/8] inode-diet: Move i_cindex from struct inode to struct file Theodore Ts'o
2006-07-03 9:05 ` Christoph Hellwig
2006-07-03 14:05 ` Theodore Tso [this message]
2006-07-03 0:53 ` [patch 7/8] inode-diet: Use a union for i_blocks and i_size, i_rdev and i_devices Theodore Ts'o
2006-07-03 8:27 ` Andrew Morton
2006-07-03 14:35 ` Hugh Dickins
2006-07-03 9:06 ` Christoph Hellwig
2006-07-03 14:02 ` Theodore Tso
2006-07-03 14:42 ` Jan Engelhardt
2006-07-03 15:18 ` H. Peter Anvin
2006-07-03 0:53 ` [patch 8/8] inode-diet: Fix size of i_blkbits, i_version, and i_dnotify_mask Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060703140552.GB8099@thunk.org \
--to=tytso@mit.edu \
--cc=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox