From: Dave Jones <davej@redhat.com>
To: Lukas Hejtmanek <xhejtman@mail.muni.cz>
Cc: lkml <linux-kernel@vger.kernel.org>, akpm <akpm@osdl.org>
Subject: Re: [Ubuntu PATCH] Add Dothan frequency tables for speedstep
Date: Tue, 4 Jul 2006 15:53:34 -0400 [thread overview]
Message-ID: <20060704195334.GD20952@redhat.com> (raw)
In-Reply-To: <20060704191411.GA9787@mail.muni.cz>
On Tue, Jul 04, 2006 at 09:14:11PM +0200, Lukas Hejtmanek wrote:
> On Mon, Jul 03, 2006 at 05:44:03PM -0400, Dave Jones wrote:
> > Yes it works great if your system is wired up to use VID#C,
> > but what if it isn't ? It's got a 1 in 4 chance of working,
> > and what it'll do in the other 3 cases is anyones guess.
> >
> > As there's no way to tell which VID is in use, the only
> > option on these systems is to use either the acpi
> > mode of this driver, or acpi-cpufreq instead.
>
> Is this the same reason why this patch wasn't accepted in mainline?
> http://fabrice.bellamy.club.fr/bdz.undervolt.2005.10.22.a.patch
No. That's was rejected due to the
"don't give people semi-automatic weapons to shoot their feet off with" principle.
The problem with patches like this, and the "let cpufreq overclock" patches,
and the "let me input my own voltage/freq pairs via sysfs" patches
is some lucky soul (yours truly) gets to deal with the fallout when peoples
computers crash after trying patches like this. My inbox has more than enough
problems for me to dig into, without introducing more problems that are
frankly, undebuggable.
Dave
--
http://www.codemonkey.org.uk
prev parent reply other threads:[~2006-07-04 19:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-03 20:47 [Ubuntu PATCH] Add Dothan frequency tables for speedstep Randy Dunlap
2006-07-03 20:51 ` Arjan van de Ven
2006-07-03 21:44 ` Dave Jones
2006-07-04 19:14 ` Lukas Hejtmanek
2006-07-04 19:53 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060704195334.GD20952@redhat.com \
--to=davej@redhat.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xhejtman@mail.muni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox