Re: [PATCH 1/2] batch-write.patch

[Alexander Zarochentsev <zam@namesys.com>]

On Tuesday 04 July 2006 15:48, Christoph Hellwig wrote:
> On Tue, Jul 04, 2006 at 03:12:56PM +0400, Vladimir V. Saveliev wrote:
> > > Should this be an address_space_operation or a file_operation?
> >
> > I was seeking to be minimal in my changes to the philosophy of the
> > code. So, it was an address_space operation. Now it is a file
> > operation.
>
> It definitly should not be a file_operation! 
 
> It works at the 
> address_space 

generic_batch_write works with the page cache, another batch_write 
implementation may not.

Except the cached_page and pagevec which are generic_batch_write 
context, the batch_write switch leaves file stuff _before_ the switch 
and using of the page cache _after_ the switch.  It gives much 
flexibility to a file system to choose between simple page cache 
buffered write, batch version of page cache write or even not a 
page-oriented write method like reiser4 write method for packed (tails 
only) files.  address space op which does not use the page cache looks 
better as a file op.

> not the much higher file level.

> Maybe all three should 
> become callbacks for the generic write routines, but that's left for
> the future.

Thanks,
Alex.