From: Andrew Morton <akpm@osdl.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: davej@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Limit VIA and SIS AGP choices to x86
Date: Wed, 5 Jul 2006 11:10:57 -0700 [thread overview]
Message-ID: <20060705111057.a03fbcec.akpm@osdl.org> (raw)
In-Reply-To: <20060705175725.GL1605@parisc-linux.org>
On Wed, 5 Jul 2006 11:57:25 -0600
Matthew Wilcox <matthew@wil.cx> wrote:
> As far as I am aware, Alpha, PPC and IA64 don't have VIA or SIS AGP
> chipsets available.
>
> ...
>
> config AGP_SIS
> tristate "SiS chipset support"
> - depends on AGP
> + depends on AGP && X86
I never know what to do here.
Sure, the driver will not be used on that architecture. But there is some
benefit in being able to cross-compile that driver on other architectures
anyway. Sometimes it will pick up missed #includes, sometimes printk
mismatches, various other assumptions which might be OK for x86 right now
but which might cause problems in the future.
Need to balance a very minor con against some very minor pros ;)
next prev parent reply other threads:[~2006-07-05 18:11 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-05 17:57 [PATCH] Limit VIA and SIS AGP choices to x86 Matthew Wilcox
2006-07-05 18:10 ` Andrew Morton [this message]
2006-07-05 18:24 ` Ben Pfaff
2006-07-05 19:24 ` Dave Jones
2006-07-05 19:21 ` Dave Jones
2006-07-05 19:27 ` Arjan van de Ven
2006-07-05 19:36 ` Dave Jones
2006-07-05 21:39 ` H. Peter Anvin
2006-07-07 7:31 ` Indrek Kruusa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060705111057.a03fbcec.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox