[PATCH] Limit VIA and SIS AGP choices to x86

[PATCH] Limit VIA and SIS AGP choices to x86

[Matthew Wilcox]

As far as I am aware, Alpha, PPC and IA64 don't have VIA or SIS AGP
chipsets available.

Signed-off-by: Matthew Wilcox <matthew@wil.cx>

Index: ./drivers/char/agp/Kconfig
===================================================================
RCS file: /var/cvs/linux-2.6/drivers/char/agp/Kconfig,v
retrieving revision 1.16
diff -u -p -r1.16 Kconfig
--- ./drivers/char/agp/Kconfig	13 Jun 2006 16:25:20 -0000	1.16
+++ ./drivers/char/agp/Kconfig	5 Jul 2006 17:52:48 -0000
@@ -75,8 +75,6 @@ config AGP_INTEL
 	  E7205 and E7505 chipsets and full support for the 810, 815, 830M,
 	  845G, 852GM, 855GM, 865G and I915 integrated graphics chipsets.
 
-
-
 config AGP_NVIDIA
 	tristate "NVIDIA nForce/nForce2 chipset support"
 	depends on AGP && X86_32
@@ -86,7 +84,7 @@ config AGP_NVIDIA
 
 config AGP_SIS
 	tristate "SiS chipset support"
-	depends on AGP
+	depends on AGP && X86
 	help
 	  This option gives you AGP support for the GLX component of
 	  X on Silicon Integrated Systems [SiS] chipsets.
@@ -103,7 +101,7 @@ config AGP_SWORKS
 
 config AGP_VIA
 	tristate "VIA chipset support"
-	depends on AGP
+	depends on AGP && X86
 	help
 	  This option gives you AGP support for the GLX component of
 	  X on VIA MVP3/Apollo Pro chipsets.

Re: [PATCH] Limit VIA and SIS AGP choices to x86

[Andrew Morton]

On Wed, 5 Jul 2006 11:57:25 -0600
Matthew Wilcox <matthew@wil.cx> wrote:

> As far as I am aware, Alpha, PPC and IA64 don't have VIA or SIS AGP
> chipsets available.
> 
> ...
>
>  config AGP_SIS
>  	tristate "SiS chipset support"
> -	depends on AGP
> +	depends on AGP && X86

I never know what to do here.

Sure, the driver will not be used on that architecture.  But there is some
benefit in being able to cross-compile that driver on other architectures
anyway.  Sometimes it will pick up missed #includes, sometimes printk
mismatches, various other assumptions which might be OK for x86 right now
but which might cause problems in the future.

Need to balance a very minor con against some very minor pros ;)

Re: [PATCH] Limit VIA and SIS AGP choices to x86

[Ben Pfaff]

Andrew Morton <akpm@osdl.org> writes:

> On Wed, 5 Jul 2006 11:57:25 -0600
> Matthew Wilcox <matthew@wil.cx> wrote:
>
>> As far as I am aware, Alpha, PPC and IA64 don't have VIA or SIS AGP
>> chipsets available.
>> 
>> ...
>>
>>  config AGP_SIS
>>  	tristate "SiS chipset support"
>> -	depends on AGP
>> +	depends on AGP && X86
>
> I never know what to do here.
>
> Sure, the driver will not be used on that architecture.  But there is some
> benefit in being able to cross-compile that driver on other architectures
> anyway.  Sometimes it will pick up missed #includes, sometimes printk
> mismatches, various other assumptions which might be OK for x86 right now
> but which might cause problems in the future.

Should we have a NONNATIVE config option analogous to
EXPERIMENTAL, so that it could be expressed as
        depends on AGP && (X86 || NONNATIVE)
Seems to express the actual intentions.
-- 
Ben Pfaff 
email: blp@cs.stanford.edu
web: http://benpfaff.org

Re: [PATCH] Limit VIA and SIS AGP choices to x86

[Dave Jones]

On Wed, Jul 05, 2006 at 11:24:22AM -0700, Ben Pfaff wrote:
 > > Sure, the driver will not be used on that architecture.  But there is some
 > > benefit in being able to cross-compile that driver on other architectures
 > > anyway.  Sometimes it will pick up missed #includes, sometimes printk
 > > mismatches, various other assumptions which might be OK for x86 right now
 > > but which might cause problems in the future.
 > 
 > Should we have a NONNATIVE config option analogous to
 > EXPERIMENTAL, so that it could be expressed as
 >         depends on AGP && (X86 || NONNATIVE)
 > Seems to express the actual intentions.

Gah, that would be awful. It'd end up riddled through kconfigs everywhere.
It's also not really buying anything more than
(X86 || !X86) , at which point, they cancel each other out ;)

		Dave

-- 
http://www.codemonkey.org.uk

Re: [PATCH] Limit VIA and SIS AGP choices to x86

[Dave Jones]

On Wed, Jul 05, 2006 at 11:57:25AM -0600, Matthew Wilcox wrote:
 > 
 > As far as I am aware, Alpha, PPC and IA64 don't have VIA or SIS AGP
 > chipsets available.

VIA has turned up on PPC (some Apple notebooks).
SiS I'm not sure about.

		Dave

-- 
http://www.codemonkey.org.uk

Re: [PATCH] Limit VIA and SIS AGP choices to x86

[Arjan van de Ven]

On Wed, 2006-07-05 at 15:21 -0400, Dave Jones wrote:
> On Wed, Jul 05, 2006 at 11:57:25AM -0600, Matthew Wilcox wrote:
>  > 
>  > As far as I am aware, Alpha, PPC and IA64 don't have VIA or SIS AGP
>  > chipsets available.
> 
> VIA has turned up on PPC (some Apple notebooks).

only the southbridge... agp is a northbridge thing...

Re: [PATCH] Limit VIA and SIS AGP choices to x86

[Dave Jones]

On Wed, Jul 05, 2006 at 09:27:56PM +0200, Arjan van de Ven wrote:
 > On Wed, 2006-07-05 at 15:21 -0400, Dave Jones wrote:
 > > On Wed, Jul 05, 2006 at 11:57:25AM -0600, Matthew Wilcox wrote:
 > >  > 
 > >  > As far as I am aware, Alpha, PPC and IA64 don't have VIA or SIS AGP
 > >  > chipsets available.
 > > 
 > > VIA has turned up on PPC (some Apple notebooks).
 > 
 > only the southbridge... agp is a northbridge thing...

Maybe my memory is flaky, but I'm sure I recall a VIA
northbridge in the ibook.

benh ?

		Dave

-- 
http://www.codemonkey.org.uk

Re: [PATCH] Limit VIA and SIS AGP choices to x86

[H. Peter Anvin]

Arjan van de Ven wrote:
> On Wed, 2006-07-05 at 15:21 -0400, Dave Jones wrote:
>> On Wed, Jul 05, 2006 at 11:57:25AM -0600, Matthew Wilcox wrote:
>>  > 
>>  > As far as I am aware, Alpha, PPC and IA64 don't have VIA or SIS AGP
>>  > chipsets available.
>>
>> VIA has turned up on PPC (some Apple notebooks).
> 
> only the southbridge... agp is a northbridge thing...
> 

Not necessarily.  Some HyperTransport southbridges have AGP on them, for 
example.

	-hpa

Re: [PATCH] Limit VIA and SIS AGP choices to x86

[Indrek Kruusa]

H. Peter Anvin wrote:
> Arjan van de Ven wrote:
>> On Wed, 2006-07-05 at 15:21 -0400, Dave Jones wrote:
>>> On Wed, Jul 05, 2006 at 11:57:25AM -0600, Matthew Wilcox wrote:
>>>  >  > As far as I am aware, Alpha, PPC and IA64 don't have VIA or 
>>> SIS AGP
>>>  > chipsets available.
>>>
>>> VIA has turned up on PPC (some Apple notebooks).
>>
>> only the southbridge... agp is a northbridge thing...
>>
>
> Not necessarily.  Some HyperTransport southbridges have AGP on them, 
> for example.

Yes, and this is evil because historically 90% people think about 
"xxxxxbridge" as "right bunch" of implemented electrical interfaces and 
not by MSR's or whatever else :)


Indrek