From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+willy=40w.ods.org-S1030194AbWGFF7X@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1030194AbWGFF7X (ORCPT <rfc822;willy@w.ods.org>);
	Thu, 6 Jul 2006 01:59:23 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1030210AbWGFF7X
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Thu, 6 Jul 2006 01:59:23 -0400
Received: from smtp.osdl.org ([65.172.181.4]:41652 "EHLO smtp.osdl.org")
	by vger.kernel.org with ESMTP id S1030194AbWGFF7W (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Thu, 6 Jul 2006 01:59:22 -0400
Date: Wed, 5 Jul 2006 22:59:05 -0700
From: Andrew Morton <akpm@osdl.org>
To: ebiederm@xmission.com (Eric W. Biederman)
Cc: kmannth@gmail.com, linux-kernel@vger.kernel.org, mingo@elte.hu,
       tglx@linutronix.de, Natalie.Protasevich@UNISYS.com
Subject: Re: 2.6.17-mm6
Message-Id: <20060705225905.53e61ca0.akpm@osdl.org>
In-Reply-To: <m1u05v2st3.fsf@ebiederm.dsl.xmission.com>
References: <20060703030355.420c7155.akpm@osdl.org>
	<a762e240607051447x3c3c6e15k9cdb38804cf13f35@mail.gmail.com>
	<20060705155037.7228aa48.akpm@osdl.org>
	<a762e240607051628n42bf3b79v34178c7251ad7d92@mail.gmail.com>
	<20060705164457.60e6dbc2.akpm@osdl.org>
	<20060705164820.379a69ba.akpm@osdl.org>
	<a762e240607051705h33952e5elf6bd09c1ccea8ab4@mail.gmail.com>
	<20060705172545.815872b6.akpm@osdl.org>
	<m1u05v2st3.fsf@ebiederm.dsl.xmission.com>
X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.17; i686-pc-linux-gnu)
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, 05 Jul 2006 23:42:00 -0600
ebiederm@xmission.com (Eric W. Biederman) wrote:

> So I suspect that we need to de-percpuify kernel_stat.irqs.

I think so.  We do:

	struct irq_desc *desc = irq_desc + irq;

	kstat_this_cpu.irqs[irq]++;

followed immediately by

	spin_lock(&desc->lock);

false optimisation, or what?