From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964999AbWGFIYp (ORCPT ); Thu, 6 Jul 2006 04:24:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S965012AbWGFIYp (ORCPT ); Thu, 6 Jul 2006 04:24:45 -0400 Received: from smtp.osdl.org ([65.172.181.4]:46053 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S964999AbWGFIYo (ORCPT ); Thu, 6 Jul 2006 04:24:44 -0400 Date: Thu, 6 Jul 2006 01:24:40 -0700 From: Andrew Morton To: Mike Galbraith Cc: linux-kernel@vger.kernel.org Subject: Re: 2.6.17-mm6 vmstat breakage Message-Id: <20060706012440.967c4908.akpm@osdl.org> In-Reply-To: <1152171523.8098.22.camel@Homer.TheSimpsons.net> References: <20060703030355.420c7155.akpm@osdl.org> <20060705155037.7228aa48.akpm@osdl.org> <20060705164457.60e6dbc2.akpm@osdl.org> <20060705164820.379a69ba.akpm@osdl.org> <20060705172545.815872b6.akpm@osdl.org> <20060705225905.53e61ca0.akpm@osdl.org> <1152171523.8098.22.camel@Homer.TheSimpsons.net> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.17; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 06 Jul 2006 09:38:43 +0200 Mike Galbraith wrote: > Greetings, > > My single P4/HT box is showing incorrect pgpgin pgpgout numbers with > this kernel. While disk throughput for dd if=/dev/hdc of=/dev=null > bs=4096 count=1000000 produces about 57MB/S (up ~14% over 2.6.17 btw), > vmstat (procps version 3.2.5) is only showing about 7MB/S. > > Looking at the numbers in /proc/vmstat, it looks kinda like pgpgin might > be pages instead of the KB it used to be, with some added >>=1 action on > the side. At any rate, the numbers below are horse-pookey ;-) > > procs -----------memory---------- ---swap-- -----io---- --system-- ----cpu---- > r b swpd free buff cache si so bi bo in cs us sy id wa > 1 1 3820 9400 810128 46052 0 0 7040 0 1163 1283 2 7 48 44 > 1 1 3820 9220 810288 46156 0 0 7040 0 1151 1335 3 6 48 45 > 1 1 3820 9280 810176 46204 0 0 7168 0 1156 1207 1 7 48 44 > 2 1 3820 9408 810048 46068 0 0 7168 0 1160 1192 1 6 49 46 > 2.6.18-rc1 has the same bug. --- a/include/linux/vmstat.h~count_vm_events-fix +++ a/include/linux/vmstat.h @@ -57,7 +57,7 @@ static inline void __count_vm_events(enu static inline void count_vm_events(enum vm_event_item item, long delta) { - get_cpu_var(vm_event_states.event[item])++; + get_cpu_var(vm_event_states.event[item]) += delta; put_cpu(); } _