From: Thomas Tuttle <thinkinginbinary@gmail.com>
To: "Randy.Dunlap" <rdunlap@xenotime.net>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: PATCH: Create new LED trigger for CPU activity (ledtrig-cpu) (UPDATED)
Date: Wed, 5 Jul 2006 23:03:37 -0400 [thread overview]
Message-ID: <20060706030337.GC25835@phoenix> (raw)
In-Reply-To: <20060705200126.48f83ec0.rdunlap@xenotime.net>
[-- Attachment #1: Type: text/plain, Size: 934 bytes --]
On July 05 at 23:01 EDT, Randy.Dunlap hastily scribbled:
> On Wed, 5 Jul 2006 22:48:17 -0400 Thomas Tuttle wrote:
>
> > Here is a new version of the patch, incorporating code style tips from
> > Randy Dunlap <rdunlap@xenotime.net>, and based on 2.6.17-git25, rather
> > than 2.6.17.1.
> >
> > I noticed that there's a Heartbeat LED trigger in the git version. I
> > hope this isn't too similar.
>
> I missed at least one thing:
>
> Don't #include <linux/config.h>
> That is done automatically now by Kbuild. Source files
> should not do it. (you could wait to see if there are other comments. :)
>
> ---
> ~Randy
Are you sure? Will it rebuild a file if a config entry is changed that
is simply mentioned in an #ifdef?
Is this a recent change? It wasn't working this way in 2.6.17.1--it
automatically noticed changes to the config of the file itself, but not
to config symbols tested using #ifdef.
[-- Attachment #2: Type: application/pgp-signature, Size: 191 bytes --]
next prev parent reply other threads:[~2006-07-06 3:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-06 2:48 PATCH: Create new LED trigger for CPU activity (ledtrig-cpu) (UPDATED) Thomas Tuttle
2006-07-06 3:01 ` Randy.Dunlap
2006-07-06 3:03 ` Thomas Tuttle [this message]
2006-07-06 3:13 ` Randy.Dunlap
2006-07-06 4:39 ` Andrew Morton
2006-07-06 13:54 ` Thomas Tuttle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060706030337.GC25835@phoenix \
--to=thinkinginbinary@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox