Re: [klibc 30/31] Remove in-kernel resume-from-disk invocation code

Nigel Cunningham
2006-07-06T00:37:15Z

[-- Attachment #1: Type: text/plain, Size: 1020 bytes --]

Hi.

On Thursday 06 July 2006 10:11, H. Peter Anvin wrote:
> Nigel Cunningham wrote:
> > This patch doesn't look right to me. After it is applied, the user will
> > have no way of saying that they don't want to resume (noresume). I assume
> > the removal of resume= isn't a problem because you're expecting them to
> > use that other undocumented way of setting resume= that Pavel mentioned a
> > while ago?
>
> Yes, they have. The handing of resume= and noresume are now done in
> kinit; resume is invoked from userspace by direct command only.

Ah. So it's still valid to have resume= and noresume on the commandline, and
klibc greps /proc/cmdline?

So, for Suspend2, would I be ok just leaving people to add the echo
> /proc/suspend2/do_resume, as we currently do for initrds and initramfses?

> There is nothing undocumented about it.

Ok. I guess my memory is stale :).

Regards,

Nigel
--
Nigel, Michelle and Alisdair Cunningham
5 Mitchell Street
Cobden 3266
Victoria, Australia

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]