Re: [klibc 30/31] Remove in-kernel resume-from-disk invocation code

Nigel Cunningham
2006-07-05T23:40:45Z

[-- Attachment #1: Type: text/plain, Size: 830 bytes --]

Hi.

Sorry for coming late to the party. I received a request to provide a Suspend2
patch for current -mm this morning, so I've only just had impetus to look at
the impact of klibc.

On Wednesday 28 June 2006 15:17, H. Peter Anvin wrote:
> This removes the part of resume from disk that have been replaced by
> functionality in kinit.
>
> Signed-off-by: H. Peter Anvin <hpa@zytor.com>

This patch doesn't look right to me. After it is applied, the user will have
no way of saying that they don't want to resume (noresume). I assume the
removal of resume= isn't a problem because you're expecting them to use that
other undocumented way of setting resume= that Pavel mentioned a while ago?

Regards,

Nigel
--
Nigel, Michelle and Alisdair Cunningham
5 Mitchell Street
Cobden 3266
Victoria, Australia

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]