From: Andrew Morton <akpm@osdl.org>
To: David Howells <dhowells@redhat.com>
Cc: dhowells@redhat.com, torvalds@osdl.org, bernds_cb1@t-online.de,
sam@ravnborg.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/6] FRV: Fix FRV arch compile errors [try #3]
Date: Thu, 6 Jul 2006 11:39:22 -0700 [thread overview]
Message-ID: <20060706113922.ac32eff3.akpm@osdl.org> (raw)
In-Reply-To: <25855.1152210303@warthog.cambridge.redhat.com>
On Thu, 06 Jul 2006 19:25:03 +0100
David Howells <dhowells@redhat.com> wrote:
> Andrew Morton <akpm@osdl.org> wrote:
>
> > - The __init-style tags on declarations don't actually do anything and
> > the compiler doesn't check for consistency with the definition - it's
> > best to just omit it from the declaration.
>
> Well, you're wrong. They *do* do something. They stop the compiler using the
> register-relative addressing reserved for small data. If this isn't in there,
> then the linker will spit out a relocation error.
Sigh. So if we get this wrong (and we have, and we shall) then the error
gets silently accepted by the toolchain until someone comes along and tries
to link it on FVR.
Is there anything we can do about that? Mangling the names with some macro
isn't attractive. Teach sparse about it? Dunno.
Right now we're showing a grand total of two identifiers tagged with
__initdata in all of include/. Why isn't FRV blowing up all over the
place? Is there something about nr_kernel_pages which made us get unlucky?
next prev parent reply other threads:[~2006-07-06 18:39 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-06 12:47 [PATCH 0/6] Fix FRV, ELF-FDPIC and NOMMU stuff [try #3] David Howells
2006-07-06 12:47 ` [PATCH 1/6] FDPIC: Fix FDPIC compile errors " David Howells
2006-07-06 13:40 ` David Woodhouse
2006-07-07 9:41 ` David Howells
2006-07-06 12:47 ` [PATCH 2/6] FRV: Fix FRV arch " David Howells
2006-07-06 17:31 ` Andrew Morton
2006-07-06 18:25 ` David Howells
2006-07-06 18:39 ` Andrew Morton [this message]
2006-07-06 19:02 ` David Howells
2006-07-06 17:36 ` Andrew Morton
2006-07-06 18:29 ` David Howells
2006-07-06 12:47 ` [PATCH 3/6] NOMMU: Fix execution off of ramfs with mmap() " David Howells
2006-07-06 12:47 ` [PATCH 4/6] FDPIC: Adjust the ELF-FDPIC driver to conform more to the CodingStyle " David Howells
2006-07-06 12:47 ` [PATCH 5/6] FDPIC: Add coredump capability for the ELF-FDPIC binfmt " David Howells
2006-07-06 17:52 ` Andrew Morton
2006-07-06 18:38 ` David Howells
2006-07-06 23:27 ` Andrew Morton
2006-07-07 9:46 ` David Howells
2006-07-07 10:54 ` David Howells
2006-07-07 11:00 ` David Howells
2006-07-07 11:12 ` Andrew Morton
2006-07-07 9:54 ` David Howells
2006-07-07 10:20 ` Andrew Morton
2006-07-07 10:34 ` David Howells
2006-07-06 12:47 ` [PATCH 6/6] FRV: Introduce asm-offsets for FRV arch " David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060706113922.ac32eff3.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=bernds_cb1@t-online.de \
--cc=dhowells@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox