From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750725AbWGFTW7 (ORCPT ); Thu, 6 Jul 2006 15:22:59 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1750741AbWGFTW7 (ORCPT ); Thu, 6 Jul 2006 15:22:59 -0400 Received: from smtp.osdl.org ([65.172.181.4]:12255 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1750725AbWGFTW6 (ORCPT ); Thu, 6 Jul 2006 15:22:58 -0400 Date: Thu, 6 Jul 2006 12:22:50 -0700 From: Andrew Morton To: Greg KH Cc: tiwai@suse.de, arjan@infradead.org, kkeil@suse.de, torvalds@osdl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] hisax fix usage of __init* Message-Id: <20060706122250.34fdeded.akpm@osdl.org> In-Reply-To: <20060706191129.GA20255@kroah.com> References: <20060705112357.GA7003@pingi.kke.suse.de> <1152099459.3201.19.camel@laptopd505.fenrus.org> <20060706191129.GA20255@kroah.com> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.17; i686-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 6 Jul 2006 12:11:29 -0700 Greg KH wrote: > > > Tips: > > > The module_init()/module_exit() functions (and all initialization > > > functions called only from these) should be marked __init/exit. > > > The struct pci_driver shouldn't be marked with any of these tags. > > > The ID table array should be marked __devinitdata. > > Yes, and that is correct. They should never be marked __initdata, as > that is wrong for when CONFIG_HOTPLUG is enabled and the module is built > in. > > So either use __devinitdata, or nothing (as it's only a memory savings > if CONFIG_HOTPLUG is not enabled, which is real tough these days, and > the driver is built into the system.) I think the problem is that pci_driver has a pointer to the id_table. So we have a ref to __devinitdata from .text. That's runtimely-correct, but the new section checker could get offended.