Re: Linux 2.6.17.4

[Willy Tarreau <w@1wt.eu>]

On Thu, Jul 06, 2006 at 03:46:14PM -0700, Greg KH wrote:
> On Thu, Jul 06, 2006 at 05:43:53PM -0500, Scott J. Harmon wrote:
> > Greg KH wrote:
> > > diff --git a/Makefile b/Makefile
> > > index 8c72521..abcf2d7 100644
> > > --- a/Makefile
> > > +++ b/Makefile
> > > @@ -1,7 +1,7 @@
> > >  VERSION = 2
> > >  PATCHLEVEL = 6
> > >  SUBLEVEL = 17
> > > -EXTRAVERSION = .3
> > > +EXTRAVERSION = .4
> > >  NAME=Crazed Snow-Weasel
> > >  
> > >  # *DOCUMENTATION*
> > > diff --git a/kernel/sys.c b/kernel/sys.c
> > > index 0b6ec0e..59273f7 100644
> > > --- a/kernel/sys.c
> > > +++ b/kernel/sys.c
> > > @@ -1991,7 +1991,7 @@ asmlinkage long sys_prctl(int option, un
> > >  			error = current->mm->dumpable;
> > >  			break;
> > >  		case PR_SET_DUMPABLE:
> > > -			if (arg2 < 0 || arg2 > 2) {
> > > +			if (arg2 < 0 || arg2 > 1) {
> > >  				error = -EINVAL;
> > >  				break;
> > >  			}
> > Just curious as to why this isn't just
> > ...
> > 			if (arg2 != 1) {
> > ...
> 
> Because that would be incorrect :)

Interestingly, 2.4 tests (arg2 !=0 && arg2 != 1) so from the code changes
above, it looks like the value 2 was added on purpose, but for what ? Maybe
the fix is not really correct yet ?

Cheers,
Willy

> 
> thanks,
> 
> greg k-h
> -
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/