public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Michael Kerrisk" <michael.kerrisk@gmx.net>
To: Manfred Spraul <manfred@colorfullife.com>, mtk-manpages@gmx.net
Cc: linux-kernel@vger.kernel.org, tytso@mit.edu, torvalds@osdl.org,
	drepper@redhat.com, paire@ri.silicomp.fr, eggert@cs.ucla.edu,
	roland@redhat.com, rlove@rlove.org, mtk-lkml@gmx.net
Subject: Re: Re: Strange Linux behaviour with blocking syscalls and stop signals+SIGCONT
Date: Fri, 07 Jul 2006 06:28:54 +0200	[thread overview]
Message-ID: <20060707042854.186800@gmx.net> (raw)
In-Reply-To: <44AD599D.70803@colorfullife.com>

Von: Manfred Spraul <manfred@colorfullife.com>
> Michael Kerrisk wrote:
> 
> >  
> >
> >>Michael: Could you replace the EINTR in inotify.c with ERESTARTNOHAND? 
> >>That should prevent the kernel from showing the signal to user space.
> >>I'd guess that most instances of EINTR are wrong, except in device 
> >>drivers: It means we return from the syscall, even if the signal 
> >>handler
> >>wants to restart the system call.
> >>    
> >>
> >
> >I'll try patching a kernel to s/EINTR/ERESTARTNOHAND/ in relevant
> >places, and see how that goes.  If it goes well, I'll submit a 
> >patch.
> >
> >  
> >
> 1) I would go further and try ERESTARTSYS: ERESTARTSYS means that the 
> kernel signal handler honors SA_RESTART

Yes, this is a separate but related issue: some system calls
are not restarted by SA_RESTART.  This set of system calls
overlaps with, but is not quite the same as, the set of
system calls that demonstrate the stop+SIGCONT ==> EINTR
strangeness.  I thought to tackle the latter problem
first (since the fix seems easy), and then perhaps
get onto the other one later (it is more likely to
lead to visible ABI changes).

Cheers,

Michael
-- 


Der GMX SmartSurfer hilft bis zu 70% Ihrer Onlinekosten zu sparen!
Ideal für Modem und ISDN: http://www.gmx.net/de/go/smartsurfer

      parent reply	other threads:[~2006-07-07  4:28 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-03 14:46 Strange Linux behaviour with blocking syscalls and stop signals+SIGCONT Michael Kerrisk
2006-07-04 19:02 ` Manfred Spraul
2006-07-06  9:23   ` Michael Kerrisk
2006-07-06 18:42     ` Manfred Spraul
2006-07-06 18:55       ` Ulrich Drepper
2006-07-06 19:02         ` Manfred Spraul
2006-07-06 19:10           ` Ulrich Drepper
2006-07-06 19:18           ` Linus Torvalds
2006-07-06 19:28             ` Manfred Spraul
2006-07-06 19:29               ` Manfred Spraul
2006-07-07  4:57             ` Michael Kerrisk
2006-07-07  5:10               ` Linus Torvalds
2006-07-07  5:12                 ` Linus Torvalds
2009-11-07 19:43             ` angelo.borsotti
2006-07-07  4:32         ` Michael Kerrisk
2006-07-07  4:57           ` Ulrich Drepper
2006-07-07  5:07             ` Michael Kerrisk
2006-07-07  6:20               ` Ulrich Drepper
2006-07-07  7:03                 ` Michael Kerrisk
2006-07-07  7:20                   ` Arjan van de Ven
2006-07-07  8:02                     ` Michael Kerrisk
2006-07-07  9:26                       ` Jakub Jelinek
2006-07-07 13:36                         ` Ulrich Drepper
2006-07-07  4:28       ` Michael Kerrisk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060707042854.186800@gmx.net \
    --to=michael.kerrisk@gmx.net \
    --cc=drepper@redhat.com \
    --cc=eggert@cs.ucla.edu \
    --cc=linux-kernel@vger.kernel.org \
    --cc=manfred@colorfullife.com \
    --cc=mtk-lkml@gmx.net \
    --cc=mtk-manpages@gmx.net \
    --cc=paire@ri.silicomp.fr \
    --cc=rlove@rlove.org \
    --cc=roland@redhat.com \
    --cc=torvalds@osdl.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox