Re: [PATCH 0/13: eCryptfs] eCryptfs Patch Set

Nick Piggin
2006-05-14T02:59:39Z

Michael Thompson wrote:
> On 5/12/06, Nick Piggin <nickpiggin@yahoo.com.au> wrote:

>> BTW. I'm not sure if linux-fsdevel has different conventions; however
>> usually you don't break up a patch according to files, but logical
>> components or transformations from one "sane" kernel tree to the next.
>> And that means things keep compiling and working.
>
>
> The files themselves are broken down into logical components, so the
> per-file patch approach seems reasonable to me.

Half a filesystem is a logical component?

At the very least it wires up all the kconfig stuff _first_, so it
breaks the tree from about patch 3 until 13.

>
>> Sometimes big patches are justified.
>
>
> This patch format (a whole repost) was requested.

I don't know that whole repost means break up the patches per-file...
Logical might be 1: whole filesystem; 2: debug file+debug calls
throughout 1; 3: documentation.

--
SUSE Labs, Novell Inc.
Send instant messages to your online friends http://au.messenger.yahoo.com