Re: [PATCH 0/13: eCryptfs] eCryptfs Patch Set

Michael Thompson
2006-05-13T16:21:12Z

On 5/12/06, Nick Piggin <nickpiggin@yahoo.com.au> wrote:
> Phillip Hellewell wrote:
> > This patch set constitutes the 0.1.7 release of the eCryptfs
> > cryptographic filesystem:
> >
> > http://ecryptfs.sourceforge.net/
> >
> > It includes numerous updates based on comments on the 0.1.6 submission
> > made on May 4th. The only functional change worth noting is the
> > removal of the unnecessary second read in ecryptfs_get1page() and
> > ecryptfs_do_readpage().
> >
> > This patch set was produced and tested against the 2.6.17-rc3-mm1
> > release of the kernel.
>
> BTW. I'm not sure if linux-fsdevel has different conventions; however
> usually you don't break up a patch according to files, but logical
> components or transformations from one "sane" kernel tree to the next.
> And that means things keep compiling and working.

The files themselves are broken down into logical components, so the
per-file patch approach seems reasonable to me.

> Sometimes big patches are justified.

This patch format (a whole repost) was requested.

Thanks,
Mike

--
Michael C. Thompson <mcthomps@us.ibm.com>
Software-Engineer, IBM LTC Security