Re: [PATCH 0/13: eCryptfs] eCryptfs Patch Set

Andrew Morton
2006-05-14T03:17:13Z

Nick Piggin <nickpiggin@yahoo.com.au> wrote:
>
> Michael Thompson wrote:
> > On 5/12/06, Nick Piggin <nickpiggin@yahoo.com.au> wrote:
>
> >> BTW. I'm not sure if linux-fsdevel has different conventions; however
> >> usually you don't break up a patch according to files, but logical
> >> components or transformations from one "sane" kernel tree to the next.
> >> And that means things keep compiling and working.
> >
> >
> > The files themselves are broken down into logical components, so the
> > per-file patch approach seems reasonable to me.
>
> Half a filesystem is a logical component?
>
> At the very least it wires up all the kconfig stuff _first_, so it
> breaks the tree from about patch 3 until 13.

Doesn't matter. The rule is stated as "kernel should compile at each
step", but the _real_ rule is "don't break git-bisect".

Nobody is going to include a half-applied filesystem in their .config while
performing git-bisection, so it can go in in any order.