Re: [PATCH 10/13: eCryptfs] Mmap operations

Pekka Enberg
2006-06-28T14:16:40Z

Hi,

Sorry for the late comment...

On 5/13/06, Phillip Hellewell <phillip@hellewell.homeip.net> wrote:
> +static struct page *ecryptfs_get1page(struct file *file, int index)
> +{
> + struct page *page;
> + struct dentry *dentry;
> + struct inode *inode;
> + struct address_space *mapping;
> +
> + dentry = file->f_dentry;
> + inode = dentry->d_inode;
> + mapping = inode->i_mapping;
> + page = read_cache_page(mapping, index,
> + (filler_t *)mapping->a_ops->readpage,
> + (void *)file);
> + if (IS_ERR(page))
> + goto out;
> + wait_on_page_locked(page);

Why no check for PageUptodate?

> +out:
> + return page;
> +}