From: Andi Kleen <ak@suse.de>
To: Christoph Lameter <clameter@sgi.com>
Cc: linux-kernel@vger.kernel.org,
Nick Piggin <nickpiggin@yahoo.com.au>,
Christoph Hellwig <hch@infradead.org>,
Marcelo Tosatti <marcelo@kvack.org>,
Arjan van de Ven <arjan@infradead.org>,
Martin Bligh <mbligh@google.com>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Subject: Re: [RFC 4/8] page allocator: Optional ZONE_DMA
Date: Sat, 8 Jul 2006 02:23:01 +0200 [thread overview]
Message-ID: <200607080223.01380.ak@suse.de> (raw)
In-Reply-To: <20060708000522.3829.85832.sendpatchset@schroedinger.engr.sgi.com>
On Saturday 08 July 2006 02:05, Christoph Lameter wrote:
> Make ZONE_DMA optional in the page allocator
Hmm, we should rename you the "ifdef warrior"
> - ifdef all code for ZONE_DMA and related definition
>
> - Without ZONE_DMA, ZONE_HIGHMEM and ZONE_DMA32 we fall back
> to an empty GFP_ZONEMASK and a ZONES_SHIFT of zero (since there
> is only one zone....).
>
> - We need to fix the use of ZONE_DMA in the memory policy layer.
> ZONE_DMA is used there as the first zone so use 0 instead.
Is the barely better code really worth all the ugliness from the ifdefs? I have doubts.
I think your idea of saving some cache lines by not having the unused
zones in the fallback lists etc. is a good one, but your current implementation
with its ifdef maze is extremly ugly. Surely this can be a done less
intrusively?
-Andi
next prev parent reply other threads:[~2006-07-08 0:23 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-08 0:05 [RFC 0/8] Optional ZONE_DMA Christoph Lameter
2006-07-08 0:05 ` [RFC 1/8] Add CONFIG_ZONE_DMA to all archesM Christoph Lameter
2006-07-10 0:52 ` KAMEZAWA Hiroyuki
2006-07-10 15:56 ` Christoph Lameter
2006-07-11 7:11 ` KAMEZAWA Hiroyuki
2006-07-08 0:05 ` [RFC 2/8] slab allocator: Make DMA support configurable Christoph Lameter
2006-07-08 0:05 ` [RFC 3/8] eventcounters: Optional ZONE_DMA Christoph Lameter
2006-07-08 0:05 ` [RFC 4/8] page allocator: " Christoph Lameter
2006-07-08 0:23 ` Andi Kleen [this message]
2006-07-08 0:41 ` Christoph Lameter
2006-07-08 0:05 ` [RFC 5/8] x86_64 without ZONE_DMA Christoph Lameter
2006-07-08 0:20 ` Andi Kleen
2006-07-08 0:42 ` Christoph Lameter
2006-07-08 1:00 ` Andi Kleen
2006-07-08 1:25 ` Christoph Lameter
2006-07-08 0:05 ` [RFC 6/8] i386 " Christoph Lameter
2006-07-08 0:05 ` [RFC 7/8] Single zone optimizations Christoph Lameter
2006-07-08 0:19 ` Andi Kleen
2006-07-08 0:05 ` [RFC 8/8] Optimize mempolicies for a single zone Christoph Lameter
2006-07-08 0:17 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200607080223.01380.ak@suse.de \
--to=ak@suse.de \
--cc=arjan@infradead.org \
--cc=clameter@sgi.com \
--cc=hch@infradead.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo@kvack.org \
--cc=mbligh@google.com \
--cc=nickpiggin@yahoo.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox