RE: fs/xfs/xfs_vnodeops.c:xfs_readdir(): NULL variable dereferenced

Hua Zhong
2006-07-06T23:38:06Z

> > <-- snip -->
> >
> > Note that tp is never assigned any value other than NULL (and the
> > Coverity checker found a way how tp might be dereferenced four
> > function calls later).
>
> Then the bug is probably in the function call that uses tp
> without first checking whether it's null. Can you tell us
> where that dereference occurs?
>
> Cheers,
>
> Dave.

Maybe, but the above code is confusing too.

Why not get rid of tp and explicitly pass NULL as "xfs_dir_getdents(NULL, dp, uiop, eofp);"?

Hua