Re: [Suspend2-devel] Re: uswsusp history lesson

Rafael J. Wysocki
2006-07-09T21:36:29Z

On Sunday 09 July 2006 23:06, Nigel Cunningham wrote:
]-- snip --[
> > Now there's the separate problem that we have to share _some_ code.
> > To an absolute minimum, we have to share the freezer code and the
> > code that handles devices, because it's also shared by suspend-to-RAM.
> > The code that handles devices is already shared, but we also _have_ _to_
> > share the freezer code. Therefore, as long as suspend2 adds some code
> > to the freezer, it's not even close to be considerable for merging.
>
> If Suspend2 added code in a way that broke swsusp, I would agree. But it
> doesn't.

This is not a matter of any breakage or lack thereof. The problem is that the
freezer is _not_ _an_ _swsusp-only_ _code_. It is used by someone else too,
and having two different freezers in the tree would be _insane_, because too
many things depend on that. This would be like having two different memory
management systems, but at a smaller scale.

As far as I'm concerned, we _must_ find a way to have _one_ common freezer,
before we can _think_ of anything more. Still that's not even complicated,
because your freezer changes are quite well separeted, so please resubmit
them and we'll discuss them again. Perhaps we'll be able to reach an
agreement on what's mergeable and what's not and why. Then, I'll do my
best to get the mergeable stuff merged, and when it gets merged, you will
drop the non-mergeable freezer changes. I hope this is fair enough.

Rafael