Re: uswsusp history lesson [was Re: [Suspend2-devel] Re: swsusp / suspend2 reliability]

Nigel Cunningham
2006-07-08T22:25:39Z

[-- Attachment #1: Type: text/plain, Size: 900 bytes --]

Hi.

On Sunday 09 July 2006 07:04, Pavel Machek wrote:
> > Some way to go without bmapping. I'm assuming you're going to have to add
> > some kernel code to at least do the bmapping. By the way, watch out for
> > block sizes. Especially with XFS. It's the best test of whether your code
> > is right because the blocksize XFS uses might not be the same as the
> > underlying block device's blocksize.
>
> Why is bmapping evil?

I didn't mean it's evil. I just mean it's complicated and potentially
confusing because the result of bmap needs to modified by the number of
blocks per sector to get the right value to pass to bio_submit. Maybe you're
more experienced in these things than me, so it will be simple for you, but
it took a while for me to get right.

Regards,

Nigel
--
Nigel, Michelle and Alisdair Cunningham
5 Mitchell Street
Cobden 3266
Victoria, Australia

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]