Re: 2.6.17-mm6: kernel/sysctl.c: PROC_FS=n compile error

[Adrian Bunk <bunk@stusta.de>]

On Sun, Jul 09, 2006 at 01:52:28PM -0500, Serge E. Hallyn wrote:
> Quoting Adrian Bunk (bunk@stusta.de):
> > namespaces-utsname-sysctl-hack.patch and ipc-namespace-sysctls.patch 
> > cause the following compile error with CONFIG_PROC_FS=n:
> > 
> > <--  snip  -->
> > 
> > ...
> >   CC      kernel/sysctl.o
> > kernel/sysctl.c:107: warning: #proc_do_ipc_string# used but never defined
> > kernel/sysctl.c:150: warning: #proc_do_utsns_string# used but never defined
> > kernel/sysctl.c:2465: warning: #proc_do_uts_string# defined but not used
> > ...
> >   LD      .tmp_vmlinux1
> > kernel/built-in.o:(.data+0x938): undefined reference to `proc_do_utsns_string'
> > kernel/built-in.o:(.data+0x964): undefined reference to `proc_do_utsns_string'
> > kernel/built-in.o:(.data+0x990): undefined reference to `proc_do_utsns_string'
> > kernel/built-in.o:(.data+0x9bc): undefined reference to `proc_do_utsns_string'
> > kernel/built-in.o:(.data+0x9e8): undefined reference to `proc_do_utsns_string'
> > kernel/built-in.o:(.data+0xc24): undefined reference to `proc_do_ipc_string'
> > kernel/built-in.o:(.data+0xc50): undefined reference to `proc_do_ipc_string'
> > kernel/built-in.o:(.data+0xc7c): undefined reference to `proc_do_ipc_string'
> > kernel/built-in.o:(.data+0xca8): undefined reference to `proc_do_ipc_string'
> > kernel/built-in.o:(.data+0xcd4): undefined reference to `proc_do_ipc_string'
> > kernel/built-in.o:(.data+0xd00): more undefined references to `proc_do_ipc_string' follow
> > make: *** [.tmp_vmlinux1] Error 1
> 
> Does the below patch fix this for you?  Took me awhile to get a valid

I can confirm this patch fixes the compilation for me.

> CONFIG_PROC_FS=n .config, and I'm having other -mm s390 build failures
> which I'll look into tomorrow, but this seems to fix the problem.

CONFIG_EMBEDDED=y is required for CONFIG_PROC_FS=n, but apart from this 
there was no problem for me.

Did you observe any other problems (besides a small ATM compile error 
Dave has just merged my patch for) with CONFIG_PROC_FS=n?

> thanks,
> -serge
>...

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed