From: Andi Kleen <ak@suse.de>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Milton Miller <miltonm@bga.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [RFC] Use target filename in BUG_ON and friends
Date: Mon, 10 Jul 2006 02:03:07 +0200 [thread overview]
Message-ID: <200607100203.07206.ak@suse.de> (raw)
In-Reply-To: <20060708205707.GB13124@mars.ravnborg.org>
On Saturday 08 July 2006 22:57, Sam Ravnborg wrote:
> On Sat, Jul 08, 2006 at 11:45:49AM -0500, Milton Miller wrote:
> >
> > On Jul 8, 2006, at 04:45:54 EST, Sam Ravnborg wrote:
> > > When building the kernel using make O=.. all uses of __FILE__ becomes
> > > filenames with absolute path resulting in increased text size.
> > > Following patch supply the target filename as a commandline define
> > > KBUILD_TARGET_FILE="mmslab.o"
> >
> > Unfortunately this ignores the fact that __LINE__ is meaningless
> > without __FILE__ because there are way too many BUGs in header
> > files.
>
> __LINE__ gives a very precise hint of the offending .h file.
> For x86_64 there are only one line-number clash in include/ for uses of
> __FILE__.
It's a nasty encoding. Maybe you could add a script to resolve them?
-Andi
next prev parent reply other threads:[~2006-07-10 0:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-08 8:47 [RFC] Use target filename in BUG_ON and friends Sam Ravnborg
2006-07-08 14:00 ` Andi Kleen
2006-07-08 20:50 ` Sam Ravnborg
2006-07-08 16:45 ` Milton Miller
2006-07-08 20:57 ` Sam Ravnborg
2006-07-10 0:03 ` Andi Kleen [this message]
2006-07-23 17:58 ` Sam Ravnborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200607100203.07206.ak@suse.de \
--to=ak@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=miltonm@bga.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox