From: Andi Kleen <ak@suse.de>
To: Chuck Ebbert <76306.1226@compuserve.com>
Cc: Andrew Morton <akpm@osdl.org>,
"gregoire.favre" <gregoire.favre@gmail.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
Vojtech Pavlik <vojtech@suse.cz>,
"Rafael J. Wysocki" <rjw@sisk.pl>
Subject: Re: 2.6.18-rc1-mm1 fails on amd64 (smp_call_function_single)
Date: Mon, 10 Jul 2006 04:25:07 +0200 [thread overview]
Message-ID: <200607100425.07750.ak@suse.de> (raw)
In-Reply-To: <200607092152_MC3-1-C488-18A8@compuserve.com>
On Monday 10 July 2006 03:49, Chuck Ebbert wrote:
> In-Reply-To: <20060709154445.60d6619c.akpm@osdl.org>
>
> On Sun, 9 Jul 2006 15:44:45 -0700, Andrew Morton wrote:
>
> > I meant, in smp.h:
> >
> > #else /* CONFIG_SMP */
> > #define smp_call_function_single(cpu, fn, arg, x, y) fn(arg)
> > #endif /* CONFIG_SMP */
>
> But smp_call_function_single() generates an error if you try to call
> it on your own CPU, so that doesn't make sense.
I have a full patch to be mirrored out soon.
Your patch is still wrong because now it won't be initialized on the BP
>
> I fixed it like this, because that register defaults to zero
> anyway and doesn't need initialization on CPU 0.
>
> What I can't figure out is how this ever gets called on CPU 0
> during init, whether it's SMP or not.
The notifier is called from time.c
-Andi
next prev parent reply other threads:[~2006-07-10 2:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-10 1:49 2.6.18-rc1-mm1 fails on amd64 (smp_call_function_single) Chuck Ebbert
2006-07-10 2:25 ` Andi Kleen [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-07-09 9:11 2.6.18-rc1-mm1 Andrew Morton
2006-07-09 11:49 ` 2.6.18-rc1-mm1 fails on amd64 (smp_call_function_single) Gregoire Favre
2006-07-09 13:00 ` Adrian Bunk
2006-07-09 14:11 ` Gregoire Favre
2006-07-09 20:39 ` Rafael J. Wysocki
2006-07-09 21:03 ` Andrew Morton
2006-07-09 22:37 ` Rafael J. Wysocki
2006-07-09 22:44 ` Andrew Morton
2006-07-10 0:08 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200607100425.07750.ak@suse.de \
--to=ak@suse.de \
--cc=76306.1226@compuserve.com \
--cc=akpm@osdl.org \
--cc=gregoire.favre@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
--cc=vojtech@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox