From: Ingo Molnar <mingo@elte.hu>
To: David Brownell <david-b@pacbell.net>,
Linux Kernel list <linux-kernel@vger.kernel.org>,
tglx@linutronix.de, mingo@redhat.com,
Andrew Victor <andrew@sanpeople.com>,
Alessandro Zummo <alessandro.zummo@towertech.it>
Subject: Re: [patch 2.6.18-rc1] genirq: {en,dis}able_irq_wake() need refcounting too
Date: Mon, 10 Jul 2006 11:12:30 +0200 [thread overview]
Message-ID: <20060710091230.GA7611@elte.hu> (raw)
In-Reply-To: <20060710091340.GA4400@flint.arm.linux.org.uk>
* Russell King <rmk+lkml@arm.linux.org.uk> wrote:
> > we should also add disable_irq_wake() / enable_irq_wake() APIs and
> > start migrating most ARM users over to the new APIs, agreed? That
> > makes the APIs more symmetric and the code more readable too.
>
> That _is_ the API anyway. set_irq_wake() was never intended to be
> called directly from drivers.
doh - right. So the patch is the right thing to do :-)
Ingo
next prev parent reply other threads:[~2006-07-10 9:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-09 21:58 [patch 2.6.18-rc1] genirq: {en,dis}able_irq_wake() need refcounting too David Brownell
2006-07-10 8:58 ` Ingo Molnar
2006-07-10 9:13 ` Russell King
2006-07-10 9:12 ` Ingo Molnar [this message]
2006-07-10 9:19 ` Russell King
2006-07-10 9:16 ` Ingo Molnar
2006-07-10 9:32 ` Thomas Gleixner
2006-07-15 1:31 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060710091230.GA7611@elte.hu \
--to=mingo@elte.hu \
--cc=alessandro.zummo@towertech.it \
--cc=andrew@sanpeople.com \
--cc=david-b@pacbell.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox