From: Jesper Juhl <jesper.juhl@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: jesper.juhl@gmail.com
Subject: [RFC][PATCH 2/9] -Wshadow: Fix warnings in mconf
Date: Mon, 10 Jul 2006 13:12:37 +0200 [thread overview]
Message-ID: <200607101312.38149.jesper.juhl@gmail.com> (raw)
(please see the mail titled
"[RFC][PATCH 0/9] -Wshadow: Making the kernel build clean with -Wshadow"
for an explanation of why I'm doing this)
Fix the following -Wshadow warnings in mconf :
scripts/kconfig/mconf.c:279: warning: declaration of 'filename' shadows a global declaration
scripts/kconfig/mconf.c:261: warning: shadowed declaration is here
scripts/kconfig/mconf.c:867: warning: declaration of 'filename' shadows a global declaration
scripts/kconfig/mconf.c:261: warning: shadowed declaration is here
This makes make all[no|mod|yes]config -Wshadow clean.
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---
scripts/kconfig/mconf.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
--- linux-2.6.18-rc1-orig/scripts/kconfig/mconf.c 2006-06-18 03:49:35.000000000 +0200
+++ linux-2.6.18-rc1/scripts/kconfig/mconf.c 2006-07-09 19:48:05.000000000 +0200
@@ -276,7 +276,7 @@ static void conf_save(void);
static void show_textbox(const char *title, const char *text, int r, int c);
static void show_helptext(const char *title, const char *text);
static void show_help(struct menu *menu);
-static void show_file(const char *filename, const char *title, int r, int c);
+static void show_file(const char *fname, const char *title, int r, int c);
static void cprint_init(void);
static int cprint1(const char *fmt, ...);
@@ -864,7 +864,7 @@ static void show_help(struct menu *menu)
str_free(&help);
}
-static void show_file(const char *filename, const char *title, int r, int c)
+static void show_file(const char *fname, const char *title, int r, int c)
{
do {
cprint_init();
@@ -873,7 +873,7 @@ static void show_file(const char *filena
cprint("%s", title);
}
cprint("--textbox");
- cprint("%s", filename);
+ cprint("%s", fname);
cprint("%d", r ? r : rows);
cprint("%d", c ? c : cols);
} while (exec_conf() < 0);
next reply other threads:[~2006-07-10 11:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-10 11:12 Jesper Juhl [this message]
2006-07-10 15:53 ` [RFC][PATCH 2/9] -Wshadow: Fix warnings in mconf Martin Waitz
2006-07-10 16:18 ` Jan-Benedict Glaw
2006-07-10 22:16 ` Jesper Juhl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200607101312.38149.jesper.juhl@gmail.com \
--to=jesper.juhl@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox