From: "Paul E. McKenney" <paulmck@us.ibm.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [-mm patch] kernel/rcutorture.c: make code static
Date: Mon, 10 Jul 2006 07:58:38 -0700 [thread overview]
Message-ID: <20060710145838.GA1446@us.ibm.com> (raw)
In-Reply-To: <20060709175333.GL13938@stusta.de>
On Sun, Jul 09, 2006 at 07:53:33PM +0200, Adrian Bunk wrote:
> On Sun, Jul 09, 2006 at 02:11:06AM -0700, Andrew Morton wrote:
> >...
> > Changes since 2.6.17-mm6:
> >...
> > -srcu-rcu-variant-permitting-read-side-blocking.patch
> > -srcu-2-rcu-variant-permitting-read-side-blocking.patch
> > -srcu-add-srcu-operations-to-rcutorture.patch
> > -srcu-2-add-srcu-operations-to-rcutorture.patch
> > +srcu-3-rcu-variant-permitting-read-side-blocking.patch
> > +srcu-3-rcu-variant-permitting-read-side-blocking-fix.patch
> > +srcu-3-add-srcu-operations-to-rcutorture.patch
> >
> > Updated srcu patchset.
> >...
>
> The contents of the patch below somehow got lost during these updates.
>
> cu
> Adrian
My bad... I have applied this to my local view.
Andrew, please apply.
Thanx, Paul
> <-- snip -->
>
>
> This patch makes needlessly global code static.
Acked-by: Paul E. McKenney <paulmck@us.ibm.com>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> ---
>
> kernel/rcutorture.c | 14 +++++++-------
> 1 file changed, 7 insertions(+), 7 deletions(-)
>
> --- linux-2.6.17-mm3-full/kernel/rcutorture.c.old 2006-06-27 17:59:20.000000000 +0200
> +++ linux-2.6.17-mm3-full/kernel/rcutorture.c 2006-06-27 18:01:00.000000000 +0200
> @@ -105,11 +105,11 @@
> static DEFINE_PER_CPU(long [RCU_TORTURE_PIPE_LEN + 1], rcu_torture_batch) =
> { 0 };
> static atomic_t rcu_torture_wcount[RCU_TORTURE_PIPE_LEN + 1];
> -atomic_t n_rcu_torture_alloc;
> -atomic_t n_rcu_torture_alloc_fail;
> -atomic_t n_rcu_torture_free;
> -atomic_t n_rcu_torture_mberror;
> -atomic_t n_rcu_torture_error;
> +static atomic_t n_rcu_torture_alloc;
> +static atomic_t n_rcu_torture_alloc_fail;
> +static atomic_t n_rcu_torture_free;
> +static atomic_t n_rcu_torture_mberror;
> +static atomic_t n_rcu_torture_error;
>
> /*
> * Allocate an element from the rcu_tortures pool.
> @@ -338,7 +338,7 @@
> }
> }
>
> -int srcu_torture_stats(char *page)
> +static int srcu_torture_stats(char *page)
> {
> int cnt = 0;
> int cpu;
> @@ -567,7 +567,7 @@
> /* Shuffle tasks such that we allow @rcu_idle_cpu to become idle. A special case
> * is when @rcu_idle_cpu = -1, when we allow the tasks to run on all CPUs.
> */
> -void rcu_torture_shuffle_tasks(void)
> +static void rcu_torture_shuffle_tasks(void)
> {
> cpumask_t tmp_mask = CPU_MASK_ALL;
> int i;
>
>
next prev parent reply other threads:[~2006-07-10 14:58 UTC|newest]
Thread overview: 109+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-09 9:11 2.6.18-rc1-mm1 Andrew Morton
2006-07-09 10:20 ` 2.6.18-rc1-mm1 Michal Piotrowski
2006-07-09 10:26 ` 2.6.18-rc1-mm1 Fabio Comolli
2006-07-09 10:45 ` 2.6.18-rc1-mm1 Andrew Morton
2006-07-09 12:37 ` 2.6.18-rc1-mm1 Nick Piggin
2006-07-09 12:55 ` 2.6.18-rc1-mm1 Nick Piggin
2006-07-10 8:50 ` 2.6.18-rc1-mm1 Arjan van de Ven
2006-07-09 10:32 ` 2.6.18-rc1-mm1 Michal Piotrowski
2006-07-09 10:33 ` 2.6.18-rc1-mm1 Michal Piotrowski
2006-07-09 10:52 ` 2.6.18-rc1-mm1 Andrew Morton
2006-07-09 21:06 ` 2.6.18-rc1-mm1 Arjan van de Ven
2006-07-10 7:40 ` 2.6.18-rc1-mm1 Ingo Molnar
2006-07-10 9:22 ` 2.6.18-rc1-mm1 Michal Piotrowski
2006-07-10 9:25 ` 2.6.18-rc1-mm1 Ingo Molnar
2006-07-10 10:01 ` 2.6.18-rc1-mm1 Michal Piotrowski
2006-07-10 10:37 ` 2.6.18-rc1-mm1 Michal Piotrowski
2006-07-10 10:37 ` 2.6.18-rc1-mm1 Ingo Molnar
2006-07-10 10:57 ` 2.6.18-rc1-mm1 Michal Piotrowski
2006-07-09 11:02 ` 2.6.18-rc1-mm1 Michal Piotrowski
2006-07-09 11:13 ` 2.6.18-rc1-mm1 Michal Piotrowski
2006-07-09 12:10 ` 2.6.18-rc1-mm1 Andrew Morton
2006-07-09 13:19 ` 2.6.18-rc1-mm1 Michal Piotrowski
2006-07-09 11:22 ` 2.6.18-rc1-mm1 Reuben Farrelly
2006-07-09 12:22 ` 2.6.18-rc1-mm1 Andrew Morton
2006-07-09 12:56 ` 2.6.18-rc1-mm1 Alan Cox
2006-07-09 14:21 ` 2.6.18-rc1-mm1 Reuben Farrelly
2006-07-09 16:29 ` 2.6.18-rc1-mm1 Jeff Garzik
2006-07-09 18:35 ` 2.6.18-rc1-mm1 Andi Kleen
2006-07-11 19:37 ` 2.6.18-rc1-mm1 Greg KH
2006-07-09 21:10 ` 2.6.18-rc1-mm1 john stultz
2006-07-09 17:33 ` 2.6.18-rc1-mm1 Randy.Dunlap
2006-07-09 21:40 ` 2.6.18-rc1-mm1 Andrew Morton
2006-07-10 4:56 ` 2.6.18-rc1-mm1 Randy.Dunlap
2006-07-10 5:01 ` 2.6.18-rc1-mm1 Andrew Morton
2006-07-10 5:35 ` 2.6.18-rc1-mm1 Randy.Dunlap
2006-07-09 11:49 ` 2.6.18-rc1-mm1 fails on amd64 (smp_call_function_single) Gregoire Favre
2006-07-09 13:00 ` Adrian Bunk
2006-07-09 14:11 ` Gregoire Favre
2006-07-09 20:39 ` Rafael J. Wysocki
2006-07-09 21:03 ` Andrew Morton
2006-07-09 22:37 ` Rafael J. Wysocki
2006-07-09 22:44 ` Andrew Morton
2006-07-10 0:08 ` Andi Kleen
2006-07-09 12:46 ` modpost error about size inconsitency Sam Ravnborg
2006-07-09 12:49 ` Sam Ravnborg
2006-07-09 14:28 ` [-mm patch] fix MODULES=n compile Adrian Bunk
2006-07-09 14:28 ` [-mm patch] proper prototype for drivers/scsi/arcmsr/arcmsr_attr.c:arcmsr_free_sysfs_attr() Adrian Bunk
2006-07-09 16:19 ` 2.6.18-rc1-mm1 oops on x86_64 Cedric Le Goater
2006-07-09 20:21 ` Andrew Morton
2006-07-09 20:35 ` Rafael J. Wysocki
2006-07-09 20:59 ` Andrew Morton
2006-07-09 21:11 ` Rafael J. Wysocki
2006-07-10 15:54 ` Christoph Lameter
2006-07-10 17:22 ` Christoph Lameter
2006-07-10 16:20 ` Christoph Lameter
2006-07-10 17:38 ` Christoph Lameter
2006-07-10 20:27 ` Cedric Le Goater
2006-07-10 20:32 ` Rafael J. Wysocki
2006-07-09 17:28 ` 2.6.18-rc1-mm1 Dominik Karall
2006-07-09 20:24 ` 2.6.18-rc1-mm1 Andrew Morton
2006-07-10 7:11 ` 2.6.18-rc1-mm1 Mauro Carvalho Chehab
2006-07-10 22:25 ` 2.6.18-rc1-mm1 Dominik Karall
2006-07-13 22:10 ` 2.6.18-rc1-mm1 Dominik Karall
2006-07-09 17:53 ` [-mm patch] make arch/i386/kernel/cpu/cpufreq/longhaul.c:longhaul_walk_callback() static Adrian Bunk
2006-07-09 17:53 ` [-mm patch] kernel/rcutorture.c: make code static Adrian Bunk
2006-07-10 14:58 ` Paul E. McKenney [this message]
2006-07-09 18:22 ` 2.6.18-rc1-mm1: /sys/class/net/ethN becoming symlink befuddled /sbin/ifup Mike Galbraith
2006-07-09 19:01 ` Mike Galbraith
2006-07-09 20:51 ` Andrew Morton
2006-07-10 0:32 ` David Miller
2006-07-11 22:59 ` Greg KH
2006-07-12 6:29 ` Kay Sievers
2006-07-10 1:29 ` Jeremy Fitzhardinge
2006-07-10 5:01 ` Mike Galbraith
2006-07-09 19:24 ` 2.6.18-rc1-mm1 Valdis.Kletnieks
2006-07-09 21:11 ` 2.6.18-rc1-mm1 john stultz
2006-07-09 21:37 ` 2.6.18-rc1-mm1 inconsistent lock state in netpoll_send_skb Laurent Riffard
2006-07-10 8:40 ` Arjan van de Ven
2006-07-10 19:06 ` Laurent Riffard
2006-07-11 8:40 ` Arjan van de Ven
2006-07-11 22:00 ` Laurent Riffard
2006-07-09 21:47 ` 2.6.18-rc1-mm1 reiser4 module calls generic_file_read Laurent Riffard
2006-07-10 13:37 ` Edward Shishkin
2006-07-09 23:32 ` [-mm patch] fs/ocfs2/ioctl.c should #include "ioctl.h" Adrian Bunk
2006-07-10 0:33 ` 2.6.18-rc1-mm1 J.A. Magallón
2006-07-10 10:02 ` 2.6.18-rc1-mm1 Alan Cox
2006-07-10 1:10 ` 2.6.18-rc1-mm1 Brice Goglin
2006-07-10 15:22 ` 2.6.18-rc1-mm1 Rafael J. Wysocki
2006-07-10 18:33 ` [-mm patch] include/scsi/libsas.h should #include <linux/scatterlist.h> Adrian Bunk
2006-07-10 19:29 ` [PATCH -mm] sysfs_remove_bin_file: no return value, no check needed Randy.Dunlap
2006-07-10 21:43 ` Andrew Morton
2006-07-11 0:36 ` Randy.Dunlap
2006-07-11 6:05 ` [PATCH -mm] sysfs_remove_bin_file: no return value, dump_stack on error Randy.Dunlap
2006-07-10 22:21 ` 2.6.18-rc1-mm1 J.A. Magallón
2006-07-11 12:47 ` [-mm patch] MICROCODE should select FW_LOADER Adrian Bunk
2006-07-11 12:52 ` 2.6.18-rc1-mm1: drivers/ide/pci/jmicron.c warning Adrian Bunk
2006-07-11 14:02 ` Alan Cox
2006-07-11 22:10 ` Adrian Bunk
2006-07-11 23:10 ` Alan Cox
2006-07-11 23:23 ` Andrew Morton
2006-07-11 23:27 ` Adrian Bunk
2006-07-12 20:45 ` 2.6.18-rc1-mm1 Reuben Farrelly
2006-07-13 20:18 ` [-mm patch] DEBUG_SHIRQ should depend on DEBUG_KERNEL Adrian Bunk
2006-07-15 13:41 ` Thomas Gleixner
-- strict thread matches above, loose matches on Subject: below --
2006-06-27 8:52 2.6.17-mm3 Andrew Morton
2006-06-28 16:54 ` [-mm patch] kernel/rcutorture.c: make code static Adrian Bunk
2006-06-28 17:13 ` Paul E. McKenney
2006-06-28 17:17 ` Adrian Bunk
2006-06-28 17:49 ` Paul E. McKenney
2006-06-28 20:18 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060710145838.GA1446@us.ibm.com \
--to=paulmck@us.ibm.com \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox