From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422652AbWGJPbd (ORCPT ); Mon, 10 Jul 2006 11:31:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1422654AbWGJPbd (ORCPT ); Mon, 10 Jul 2006 11:31:33 -0400 Received: from calculon.skynet.ie ([193.1.99.88]:28584 "EHLO calculon.skynet.ie") by vger.kernel.org with ESMTP id S1422652AbWGJPbc (ORCPT ); Mon, 10 Jul 2006 11:31:32 -0400 Date: Mon, 10 Jul 2006 16:31:30 +0100 To: David Howells Cc: akpm@osdl.org, davej@codemonkey.org.uk, tony.luck@intel.com, linux-mm@kvack.org, ak@suse.de, bob.picco@hp.com, linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org Subject: Re: [PATCH 6/6] Account for memmap and optionally the kernel image as holes Message-ID: <20060710153129.GA26077@skynet.ie> References: <20060708111243.28664.74956.sendpatchset@skynet.skynet.ie> <20060708111042.28664.14732.sendpatchset@skynet.skynet.ie> <7220.1152531055@warthog.cambridge.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <7220.1152531055@warthog.cambridge.redhat.com> User-Agent: Mutt/1.5.9i From: mel@skynet.ie (Mel Gorman) Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On (10/07/06 12:30), David Howells didst pronounce: > Mel Gorman wrote: > > > +unsigned long __initdata dma_reserve; > > Should this be static? Or should it be predeclared in a header file > somewhere? > It should be static as it's set by set_dma_reserve(). Thanks. diff -rup -X /usr/src/patchset-0.6/bin//dontdiff linux-2.6.17-mm6-106-account_kernel_mmap/mm/page_alloc.c linux-2.6.17-mm6-107-fixstatic/mm/page_alloc.c --- linux-2.6.17-mm6-106-account_kernel_mmap/mm/page_alloc.c 2006-07-10 15:55:09.000000000 +0100 +++ linux-2.6.17-mm6-107-fixstatic/mm/page_alloc.c 2006-07-10 16:03:26.000000000 +0100 @@ -87,7 +87,7 @@ int min_free_kbytes = 1024; unsigned long __meminitdata nr_kernel_pages; unsigned long __meminitdata nr_all_pages; -unsigned long __initdata dma_reserve; +static unsigned long __initdata dma_reserve; #ifdef CONFIG_ARCH_POPULATES_NODE_MAP /*