public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Michael Kerrisk" <mtk-manpages@gmx.net>
To: Jens Axboe <axboe@suse.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: splice() and file offsets
Date: Mon, 10 Jul 2006 17:48:54 +0200	[thread overview]
Message-ID: <20060710154854.26270@gmx.net> (raw)
In-Reply-To: <20060710142245.GG5210@suse.de>

Jens,

> > Yes, I understand what the code is doing, but *why* do 
> > things this way?  (To put things another way: why not *always 
> > have splice() update the file offset?)  I realise there may be
> > some good reason for this, and if there is, it will go into the
> > man page!
> 
> The good reason is why update the current position? I just told the
> kernel to ignore the current position and use the given offset, why
> would I bother updating the current position? The whole point of
> providing an offset is to ignore the current position.
> 
> I must say I cannot understand why you are confused or find this
> illogical, it makes perfect sense to me.

Yes, now it's clear to me too.

[...]

> > No!  It does not!  See the sendfile.2 man page: "sendfile() 
> > does not modify the current file offset of in_fd."  
> 
> I didn't read the man page, I read the source. And it clearly updates
> the file offset, in fact the actual sendfile portion is just a supplied
> actor to the generic page cache read functions.

Doh!  I took what I "knew", re-read the sendfile.2 manual page to 
check, misread the source, and then wrote an inadequate 
test program :-{.  (The sendfile manual page is now fixed.)

> If you don't believe me, read the source and do another test app.
> splice() behaves identically, as previously stated.

Now I believe you; sorry to have wasted your time...

Cheers,

Michael
-- 
Michael Kerrisk
maintainer of Linux man pages Sections 2, 3, 4, 5, and 7 

Want to help with man page maintenance?  
Grab the latest tarball at
ftp://ftp.win.tue.nl/pub/linux-local/manpages/, 
read the HOWTOHELP file and grep the source 
files for 'FIXME'.

  reply	other threads:[~2006-07-10 15:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-10 12:11 splice() and file offsets Michael Kerrisk
2006-07-10 12:51 ` Jens Axboe
2006-07-10 13:07   ` Michael Kerrisk
2006-07-10 13:25     ` Jens Axboe
2006-07-10 13:54       ` Michael Kerrisk
2006-07-10 14:22         ` Jens Axboe
2006-07-10 15:48           ` Michael Kerrisk [this message]
2006-07-10 16:51             ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060710154854.26270@gmx.net \
    --to=mtk-manpages@gmx.net \
    --cc=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox