From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422793AbWGJTdp (ORCPT ); Mon, 10 Jul 2006 15:33:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1422798AbWGJTdp (ORCPT ); Mon, 10 Jul 2006 15:33:45 -0400 Received: from emailhub.stusta.mhn.de ([141.84.69.5]:266 "HELO mailout.stusta.mhn.de") by vger.kernel.org with SMTP id S1422679AbWGJTdo (ORCPT ); Mon, 10 Jul 2006 15:33:44 -0400 Date: Mon, 10 Jul 2006 21:33:42 +0200 From: Adrian Bunk To: Marcel Holtmann Cc: maxk@qualcomm.com, bluez-devel@lists.sourceforge.net, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux390@de.ibm.com Subject: [2.6 patch] let BT_HIDP depend on INPUT Message-ID: <20060710193342.GF13938@stusta.de> References: <20060710183154.GD13938@stusta.de> <1152558440.32554.4.camel@localhost> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1152558440.32554.4.camel@localhost> User-Agent: Mutt/1.5.11+cvs20060403 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jul 10, 2006 at 09:07:20PM +0200, Marcel Holtmann wrote: > Hi Adrian, > > > This patch let's BT_HIDP depend on instead of select INPUT. > > > > This fixes the following warning during an s390 build: > > > > <-- snip --> > > > > ... > > net/bluetooth/hidp/Kconfig:4:warning: 'select' used by config symbol 'BT_HIDP' refer to undefined symbol 'INPUT' > > ... > > > > <-- snip --> > > > > A dependency on INPUT also implies !S390 (and therefore makes the > > explicit dependency obsolete) since INPUT is not available on s390. > > > > The practical difference should be nearly zero, since INPUT is always > > set to y unless EMBEDDED=y (or S390=y). > > I actually have no idea why we ended up with using select, but depends > is also fine by me. Except I like to see it "BT && BT_L2CAP && INPUT" ;) Updated patch below. > Regards > > Marcel cu Adrian <-- snip --> This patch lets BT_HIDP depend on instead of select INPUT. This fixes the following warning during an s390 build: <-- snip --> ... net/bluetooth/hidp/Kconfig:4:warning: 'select' used by config symbol 'BT_HIDP' r efer to undefined symbol 'INPUT' ... <-- snip --> A dependency on INPUT also implies !S390 (and therefore makes the explicit dependency obsolete) since INPUT is not available on s390. The practical difference should be nearly zero, since INPUT is always set to y unless EMBEDDED=y (or S390=y). Signed-off-by: Adrian Bunk --- linux-2.6.18-rc1-mm1-full/net/bluetooth/hidp/Kconfig.old 2006-07-10 16:51:59.000000000 +0200 +++ linux-2.6.18-rc1-mm1-full/net/bluetooth/hidp/Kconfig 2006-07-10 21:21:46.000000000 +0200 @@ -1,7 +1,6 @@ config BT_HIDP tristate "HIDP protocol support" - depends on BT && BT_L2CAP && (BROKEN || !S390) - select INPUT + depends on BT && BT_L2CAP && INPUT help HIDP (Human Interface Device Protocol) is a transport layer for HID reports. HIDP is required for the Bluetooth Human