public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [2.6 patch] make sound/isa/gus/gusextreme.c:devices static
@ 2006-07-10 22:02 Adrian Bunk
  2006-07-11 10:17 ` [Alsa-devel] " Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2006-07-10 22:02 UTC (permalink / raw)
  To: perex; +Cc: alsa-devel, linux-kernel

"devices" is not a good name for a global variable.

Thankfully, it can become static.

Signed-off-by: Adrian Bunk <bunk@stusta.de>

--- linux-2.6.18-rc1-mm1-full/sound/isa/gus/gusextreme.c.old	2006-07-10 01:15:13.000000000 +0200
+++ linux-2.6.18-rc1-mm1-full/sound/isa/gus/gusextreme.c	2006-07-10 01:15:20.000000000 +0200
@@ -87,7 +87,7 @@
 module_param_array(pcm_channels, int, NULL, 0444);
 MODULE_PARM_DESC(pcm_channels, "Reserved PCM channels for GUS Extreme driver.");
 
-struct platform_device *devices[SNDRV_CARDS];
+static struct platform_device *devices[SNDRV_CARDS];
 
 
 #define PFX	"gusextreme: "


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [Alsa-devel] [2.6 patch] make sound/isa/gus/gusextreme.c:devices static
  2006-07-10 22:02 [2.6 patch] make sound/isa/gus/gusextreme.c:devices static Adrian Bunk
@ 2006-07-11 10:17 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2006-07-11 10:17 UTC (permalink / raw)
  To: Adrian Bunk; +Cc: perex, alsa-devel, linux-kernel

At Tue, 11 Jul 2006 00:02:36 +0200,
Adrian Bunk wrote:
> 
> "devices" is not a good name for a global variable.
> 
> Thankfully, it can become static.
> 
> Signed-off-by: Adrian Bunk <bunk@stusta.de>

Applied to ALSA tree now.  Thanks.


Takashi


> 
> --- linux-2.6.18-rc1-mm1-full/sound/isa/gus/gusextreme.c.old	2006-07-10 01:15:13.000000000 +0200
> +++ linux-2.6.18-rc1-mm1-full/sound/isa/gus/gusextreme.c	2006-07-10 01:15:20.000000000 +0200
> @@ -87,7 +87,7 @@
>  module_param_array(pcm_channels, int, NULL, 0444);
>  MODULE_PARM_DESC(pcm_channels, "Reserved PCM channels for GUS Extreme driver.");
>  
> -struct platform_device *devices[SNDRV_CARDS];
> +static struct platform_device *devices[SNDRV_CARDS];
>  
>  
>  #define PFX	"gusextreme: "
> 
> 
> 
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/alsa-devel
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-07-11 10:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-07-10 22:02 [2.6 patch] make sound/isa/gus/gusextreme.c:devices static Adrian Bunk
2006-07-11 10:17 ` [Alsa-devel] " Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox